diff mbox

[v2,2/2] mtd: nand: Update dependency of IFC for LS1021A

Message ID 1483411266-45875-2-git-send-email-b18965@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alison Wang Jan. 3, 2017, 2:41 a.m. UTC 
As NAND support for Freescale/NXP IFC controller is available on
LS1021A, the dependency for LS1021A is added.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
---
Changes in v2:
- None

 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut Jan. 3, 2017, 11:46 a.m. UTC | #1 
On 01/03/2017 03:41 AM, Alison Wang wrote:
> As NAND support for Freescale/NXP IFC controller is available on
> LS1021A, the dependency for LS1021A is added.

Does LS stand for LayerScape ? Yes it does. So why does ARCH_LAYERSCAPE
not cover LS1021 ?

> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> ---
> Changes in v2:
> - None
> 
>  drivers/mtd/nand/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 353a9dd..85e3860 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -441,7 +441,7 @@ config MTD_NAND_FSL_ELBC
>  
>  config MTD_NAND_FSL_IFC
>  	tristate "NAND support for Freescale IFC controller"
> -	depends on FSL_SOC || ARCH_LAYERSCAPE
> +	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A
>  	select FSL_IFC
>  	select MEMORY
>  	help
>
Alison Wang Jan. 4, 2017, 1:46 a.m. UTC | #2 
> On 01/03/2017 03:41 AM, Alison Wang wrote:
> > As NAND support for Freescale/NXP IFC controller is available on
> > LS1021A, the dependency for LS1021A is added.
> 
> Does LS stand for LayerScape ? Yes it does. So why does ARCH_LAYERSCAPE
> not cover LS1021 ?
[Alison Wang] LS1021A is an earlier product and is not compatible with later Layerscape architecture. So ARCH_LAYERSCAPE can't cover LS1021A.

> 
> > Signed-off-by: Alison Wang <alison.wang@nxp.com>
> > ---
> > Changes in v2:
> > - None
> >
> >  drivers/mtd/nand/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index
> > 353a9dd..85e3860 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -441,7 +441,7 @@ config MTD_NAND_FSL_ELBC
> >
> >  config MTD_NAND_FSL_IFC
> >  	tristate "NAND support for Freescale IFC controller"
> > -	depends on FSL_SOC || ARCH_LAYERSCAPE
> > +	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A
> >  	select FSL_IFC
> >  	select MEMORY
> >  	help
> >

Best Regards,
Alison Wang
Marek Vasut Jan. 4, 2017, 1:50 a.m. UTC | #3 
On 01/04/2017 02:46 AM, Alison Wang wrote:
>> On 01/03/2017 03:41 AM, Alison Wang wrote:
>>> As NAND support for Freescale/NXP IFC controller is available on
>>> LS1021A, the dependency for LS1021A is added.
>>
>> Does LS stand for LayerScape ? Yes it does. So why does ARCH_LAYERSCAPE
>> not cover LS1021 ?
> [Alison Wang] LS1021A is an earlier product and is not compatible with later Layerscape architecture. So ARCH_LAYERSCAPE can't cover LS1021A.

Ah ok, I see. That information would be useful in the commit message ;-)

>>
>>> Signed-off-by: Alison Wang <alison.wang@nxp.com>
>>> ---
>>> Changes in v2:
>>> - None
>>>
>>>  drivers/mtd/nand/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index
>>> 353a9dd..85e3860 100644
>>> --- a/drivers/mtd/nand/Kconfig
>>> +++ b/drivers/mtd/nand/Kconfig
>>> @@ -441,7 +441,7 @@ config MTD_NAND_FSL_ELBC
>>>
>>>  config MTD_NAND_FSL_IFC
>>>  	tristate "NAND support for Freescale IFC controller"
>>> -	depends on FSL_SOC || ARCH_LAYERSCAPE
>>> +	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A
>>>  	select FSL_IFC
>>>  	select MEMORY
>>>  	help
>>>
> 
> Best Regards,
> Alison Wang
>
Alison Wang Jan. 5, 2017, 2:02 a.m. UTC | #4 
> On 01/04/2017 02:46 AM, Alison Wang wrote:
> >> On 01/03/2017 03:41 AM, Alison Wang wrote:
> >>> As NAND support for Freescale/NXP IFC controller is available on
> >>> LS1021A, the dependency for LS1021A is added.
> >>
> >> Does LS stand for LayerScape ? Yes it does. So why does
> >> ARCH_LAYERSCAPE not cover LS1021 ?
> > [Alison Wang] LS1021A is an earlier product and is not compatible
> with later Layerscape architecture. So ARCH_LAYERSCAPE can't cover
> LS1021A.
> 
> Ah ok, I see. That information would be useful in the commit message ;-)
> 
[Alison Wang] Ok. :)
> >>
> >>> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> >>> ---
> >>> Changes in v2:
> >>> - None
> >>>
> >>>  drivers/mtd/nand/Kconfig | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> >> index
> >>> 353a9dd..85e3860 100644
> >>> --- a/drivers/mtd/nand/Kconfig
> >>> +++ b/drivers/mtd/nand/Kconfig
> >>> @@ -441,7 +441,7 @@ config MTD_NAND_FSL_ELBC
> >>>
> >>>  config MTD_NAND_FSL_IFC
> >>>  	tristate "NAND support for Freescale IFC controller"
> >>> -	depends on FSL_SOC || ARCH_LAYERSCAPE
> >>> +	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A
> >>>  	select FSL_IFC
> >>>  	select MEMORY
> >>>  	help
> >>>
> >
> > Best Regards,
> > Alison Wang
> >
> 
> 
> --
> Best regards,
> Marek Vasut

Best Regards,
Alison Wang
Boris BREZILLON Feb. 6, 2017, 9:05 a.m. UTC | #5 
Hi Alison,

On Thu, 5 Jan 2017 02:02:30 +0000
Alison Wang <alison.wang@nxp.com> wrote:

> > On 01/04/2017 02:46 AM, Alison Wang wrote:  
> > >> On 01/03/2017 03:41 AM, Alison Wang wrote:  
> > >>> As NAND support for Freescale/NXP IFC controller is available on
> > >>> LS1021A, the dependency for LS1021A is added.  
> > >>
> > >> Does LS stand for LayerScape ? Yes it does. So why does
> > >> ARCH_LAYERSCAPE not cover LS1021 ?  
> > > [Alison Wang] LS1021A is an earlier product and is not compatible  
> > with later Layerscape architecture. So ARCH_LAYERSCAPE can't cover
> > LS1021A.
> > 
> > Ah ok, I see. That information would be useful in the commit message ;-)
> >   
> [Alison Wang] Ok. :)

Would you mind sending a v3 with the updated commit message?

Thanks,

Boris
Alison Wang Feb. 13, 2017, 6:59 a.m. UTC | #6 
Hi, Boris,

> On Thu, 5 Jan 2017 02:02:30 +0000
> Alison Wang <alison.wang@nxp.com> wrote:
> 
> > > On 01/04/2017 02:46 AM, Alison Wang wrote:
> > > >> On 01/03/2017 03:41 AM, Alison Wang wrote:
> > > >>> As NAND support for Freescale/NXP IFC controller is available
> on
> > > >>> LS1021A, the dependency for LS1021A is added.
> > > >>
> > > >> Does LS stand for LayerScape ? Yes it does. So why does
> > > >> ARCH_LAYERSCAPE not cover LS1021 ?
> > > > [Alison Wang] LS1021A is an earlier product and is not compatible
> > > with later Layerscape architecture. So ARCH_LAYERSCAPE can't cover
> > > LS1021A.
> > >
> > > Ah ok, I see. That information would be useful in the commit
> message
> > > ;-)
> > >
> > [Alison Wang] Ok. :)
> 
> Would you mind sending a v3 with the updated commit message?
> 
[Alison Wang] I will send the v3 patches at once. :)


Best Regards,
Alison Wang
diff mbox

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 353a9dd..85e3860 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -441,7 +441,7 @@  config MTD_NAND_FSL_ELBC
 
 config MTD_NAND_FSL_IFC
 	tristate "NAND support for Freescale IFC controller"
-	depends on FSL_SOC || ARCH_LAYERSCAPE
+	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A
 	select FSL_IFC
 	select MEMORY
 	help