| Message ID | ca24586f16d0a9ff4d5882156e358600e94fd71c.1486493982.git.gmatthsim@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 07, 2017 at 11:11:22AM -0800, Matthieu Simon wrote: > checkpatch noticed possible precedence issues resulting in the definition > of PEEK32 and POKE32. So, these arguments should be enclosed in > parentheses. > > Signed-off-by: Matthieu Simon <gmatthsim@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h > index e63b8b293816..a5f910344373 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.h > +++ b/drivers/staging/sm750fb/ddk750_chip.h > @@ -10,8 +10,8 @@ > #include <linux/uaccess.h> > > /* software control endianness */ > -#define PEEK32(addr) readl(addr + mmio750) > -#define POKE32(addr, data) writel(data, addr + mmio750) > +#define PEEK32(addr) readl((addr) + mmio750) > +#define POKE32(addr, data) writel((data), (addr) + mmio750) Those are funny macros, how about just making them an inline function so that we get the correct type-checking and better documentation as to what is going on with them? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index e63b8b293816..a5f910344373 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -10,8 +10,8 @@ #include <linux/uaccess.h> /* software control endianness */ -#define PEEK32(addr) readl(addr + mmio750) -#define POKE32(addr, data) writel(data, addr + mmio750) +#define PEEK32(addr) readl((addr) + mmio750) +#define POKE32(addr, data) writel((data), (addr) + mmio750) extern void __iomem *mmio750;
checkpatch noticed possible precedence issues resulting in the definition of PEEK32 and POKE32. So, these arguments should be enclosed in parentheses. Signed-off-by: Matthieu Simon <gmatthsim@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)