| Message ID | 1486347584-6762-3-git-send-email-hoegeun.kwon@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, I think the subject is not really matching the real work. You are rather removing the OF graph from DSI node. On Mon, Feb 06, 2017 at 11:19:41AM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. So > removed the ports and moved burst, esc clock-frequency property to the > top. Keep the commit style and tense - imperative mode (see submitting-patches.rstsubmitting-patches.rst), so last sentence could look like: "Remove the ports node abd move burst and esc clock frequency properties to the parent (DSI node)." The information which is missing is the answer for WHY? Why are you doing this? Does the patch depends on 1/5? Best regards, Krzysztof > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 6ce93a3..77ba238 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -298,23 +298,11 @@ > status = "okay"; > vddcore-supply = <&ldo6_reg>; > vddio-supply = <&ldo7_reg>; > + samsung,burst-clock-frequency = <512000000>; > + samsung,esc-clock-frequency = <16000000>; > samsung,pll-clock-frequency = <24000000>; > pinctrl-names = "default"; > pinctrl-0 = <&te_irq>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@1 { > - reg = <1>; > - > - dsi_out: endpoint { > - samsung,burst-clock-frequency = <512000000>; > - samsung,esc-clock-frequency = <16000000>; > - }; > - }; > - }; > }; > > &hdmi { > -- > 1.9.1 >
Hi krzysztof, On 02/08/2017 05:13 AM, Krzysztof Kozlowski wrote: > Hi, > > I think the subject is not really matching the real work. You are rather > removing the OF graph from DSI node. > > On Mon, Feb 06, 2017 at 11:19:41AM +0900, Hoegeun Kwon wrote: >> The OF graph is not needed because the panel is a child of dsi. So >> removed the ports and moved burst, esc clock-frequency property to the >> top. > Keep the commit style and tense - imperative mode (see > submitting-patches.rstsubmitting-patches.rst), so last sentence could > look like: Hi Krzysztof, Thanks for your review. I will write a clear subject on the next version. > > "Remove the ports node abd move burst and esc clock frequency properties > to the parent (DSI node)." > > The information which is missing is the answer for WHY? Why are you > doing this? The current mipi-dsi must have at least one OF graph. However, for example, dsi and panel are parent-child relationships, so OF graph is not needed, and fimd and dsi are not connected to the OF graph. In this case, an error occurred in dsi_parse in the code before patch (1/5). So I modified dsi_parse_dt. > > Does the patch depends on 1/5? Yes, it is. The 2/5 to 5/5 patches depend on the 1/5 patch. Best regards, Hoegeun > > Best regards, > Krzysztof > >> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 16 ++-------------- >> 1 file changed, 2 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index 6ce93a3..77ba238 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -298,23 +298,11 @@ >> status = "okay"; >> vddcore-supply = <&ldo6_reg>; >> vddio-supply = <&ldo7_reg>; >> + samsung,burst-clock-frequency = <512000000>; >> + samsung,esc-clock-frequency = <16000000>; >> samsung,pll-clock-frequency = <24000000>; >> pinctrl-names = "default"; >> pinctrl-0 = <&te_irq>; >> - >> - ports { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - >> - port@1 { >> - reg = <1>; >> - >> - dsi_out: endpoint { >> - samsung,burst-clock-frequency = <512000000>; >> - samsung,esc-clock-frequency = <16000000>; >> - }; >> - }; >> - }; >> }; >> >> &hdmi { >> -- >> 1.9.1 >> > >
On Wed, Feb 8, 2017 at 9:24 AM, Hoegeun Kwon <hoegeun.kwon@samsung.com> wrote: > >> >> "Remove the ports node abd move burst and esc clock frequency properties >> to the parent (DSI node)." >> >> The information which is missing is the answer for WHY? Why are you >> doing this? > > > The current mipi-dsi must have at least one OF graph. > However, for example, dsi and panel are parent-child relationships, > so OF graph is not needed, and fimd and dsi are not connected to the OF > graph. > In this case, an error occurred in dsi_parse in the code before patch (1/5). The error occurred in case of DSI + FIMD? I do not get it whether you are removing the something which is not needed or fixing something. > So I modified dsi_parse_dt. > >> >> Does the patch depends on 1/5? > > > Yes, it is. > The 2/5 to 5/5 patches depend on the 1/5 patch. So that's a break of DT ABI for no clear (yet) reasons. Please mention this in 1/5 patch and explain what is really fixed. Best regards, Krzysztof
On 02/08/2017 04:32 PM, Krzysztof Kozlowski wrote: > On Wed, Feb 8, 2017 at 9:24 AM, Hoegeun Kwon <hoegeun.kwon@samsung.com> wrote: >>> "Remove the ports node abd move burst and esc clock frequency properties >>> to the parent (DSI node)." >>> >>> The information which is missing is the answer for WHY? Why are you >>> doing this? >> >> The current mipi-dsi must have at least one OF graph. >> However, for example, dsi and panel are parent-child relationships, >> so OF graph is not needed, and fimd and dsi are not connected to the OF >> graph. >> In this case, an error occurred in dsi_parse in the code before patch (1/5). > The error occurred in case of DSI + FIMD? I do not get it whether you > are removing the something which is not needed or fixing something. > >> So I modified dsi_parse_dt. >> >>> Does the patch depends on 1/5? >> >> Yes, it is. >> The 2/5 to 5/5 patches depend on the 1/5 patch. > So that's a break of DT ABI for no clear (yet) reasons. Please mention > this in 1/5 patch and explain what is really fixed. I would like to post the s6e63j0x03 panel driver for exynos3250. However, as Rob Herring noted, dsi + panel is a parental relationship, so OF grpah is not needed. Therefore, the current dsi_parse_dt function will throw an error, because there is no linked OF graph for case such as fimd + dsi + panel. I think that the OF graph of dsi should be deleted even if it is not the purpose of the s6e63j0x03 panel driver. So the 1/5 patch parse the Pll, burst and esc clock frequency properties in dsi_parse_dt and modified to create a bridge_node only if there is an OF graph associated with dsi. Best Regards, Hoegeun > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
On Wed, Feb 8, 2017 at 12:09 PM, Hoegeun Kwon <hoegeun.kwon@samsung.com> wrote: > On 02/08/2017 04:32 PM, Krzysztof Kozlowski wrote: >> >> On Wed, Feb 8, 2017 at 9:24 AM, Hoegeun Kwon <hoegeun.kwon@samsung.com> >> wrote: >>>> >>>> "Remove the ports node abd move burst and esc clock frequency properties >>>> to the parent (DSI node)." >>>> >>>> The information which is missing is the answer for WHY? Why are you >>>> doing this? >>> >>> >>> The current mipi-dsi must have at least one OF graph. >>> However, for example, dsi and panel are parent-child relationships, >>> so OF graph is not needed, and fimd and dsi are not connected to the OF >>> graph. >>> In this case, an error occurred in dsi_parse in the code before patch >>> (1/5). >> >> The error occurred in case of DSI + FIMD? I do not get it whether you >> are removing the something which is not needed or fixing something. >> >>> So I modified dsi_parse_dt. >>> >>>> Does the patch depends on 1/5? >>> >>> >>> Yes, it is. >>> The 2/5 to 5/5 patches depend on the 1/5 patch. >> >> So that's a break of DT ABI for no clear (yet) reasons. Please mention >> this in 1/5 patch and explain what is really fixed. > > > I would like to post the s6e63j0x03 panel driver for exynos3250. > However, as Rob Herring noted, dsi + panel is a parental relationship, > so OF grpah is not needed. > Therefore, the current dsi_parse_dt function will throw an error, > because there is no linked OF graph for case such as fimd + dsi + panel. > I think that the OF graph of dsi should be deleted even if it is not > the purpose of the s6e63j0x03 panel driver. > > So the 1/5 patch parse the Pll, burst and esc clock frequency properties > in dsi_parse_dt and modified to create a bridge_node only if there is > an OF graph associated with dsi. > Thanks, now it makes sense. Such clear explanation should be part of commit 1/5 as a proof that ABI breakage is needed. BR, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 6ce93a3..77ba238 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -298,23 +298,11 @@ status = "okay"; vddcore-supply = <&ldo6_reg>; vddio-supply = <&ldo7_reg>; + samsung,burst-clock-frequency = <512000000>; + samsung,esc-clock-frequency = <16000000>; samsung,pll-clock-frequency = <24000000>; pinctrl-names = "default"; pinctrl-0 = <&te_irq>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@1 { - reg = <1>; - - dsi_out: endpoint { - samsung,burst-clock-frequency = <512000000>; - samsung,esc-clock-frequency = <16000000>; - }; - }; - }; }; &hdmi {
The OF graph is not needed because the panel is a child of dsi. So removed the ports and moved burst, esc clock-frequency property to the top. Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)