| Message ID | b0894e503195b13a5ed6319e897e673f376a748d.1486496890.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 8 Feb 2017 01:24:14 +0530 "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote: > kprobe_exceptions_notify() is not used on some of the architectures such > as arm[64] and powerpc anymore. Introduce a weak variant for such > architectures. > Good catch! Acked-by: Masami Hiramatsu <mhiramat@kernel.org> for all patches in this series. Thank you! > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > --- > kernel/kprobes.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 43460104f119..60a702a05684 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1705,6 +1705,12 @@ void unregister_kprobes(struct kprobe **kps, int num) > } > EXPORT_SYMBOL_GPL(unregister_kprobes); > > +int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self, > + unsigned long val, void *data) > +{ > + return NOTIFY_DONE; > +} > + > static struct notifier_block kprobe_exceptions_nb = { > .notifier_call = kprobe_exceptions_notify, > .priority = 0x7fffffff /* we need to be notified first */ > -- > 2.11.0 >
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes: > kprobe_exceptions_notify() is not used on some of the architectures such > as arm[64] and powerpc anymore. Introduce a weak variant for such > architectures. I'll merge patch 1 & 3 via the powerpc tree for v4.11. You can then send patch 2 to the arm guys after -rc1, or for 4.12. cheers
* Michael Ellerman <mpe@ellerman.id.au> wrote: > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes: > > > kprobe_exceptions_notify() is not used on some of the architectures such > > as arm[64] and powerpc anymore. Introduce a weak variant for such > > architectures. > > I'll merge patch 1 & 3 via the powerpc tree for v4.11. Acked-by: Ingo Molnar <mingo@kernel.org> Thanks, Ingo
On 2017/02/10 02:41PM, Michael Ellerman wrote: > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes: > > > kprobe_exceptions_notify() is not used on some of the architectures such > > as arm[64] and powerpc anymore. Introduce a weak variant for such > > architectures. > > I'll merge patch 1 & 3 via the powerpc tree for v4.11. > > You can then send patch 2 to the arm guys after -rc1, or for 4.12. Sure, thanks! - Naveen
On Tue, 2017-02-07 at 19:54:14 UTC, "Naveen N. Rao" wrote: > kprobe_exceptions_notify() is not used on some of the architectures such > as arm[64] and powerpc anymore. Introduce a weak variant for such > architectures. > > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/fc62d0207ae0ebc9d19df68394c0dc cheers
diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 43460104f119..60a702a05684 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1705,6 +1705,12 @@ void unregister_kprobes(struct kprobe **kps, int num) } EXPORT_SYMBOL_GPL(unregister_kprobes); +int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self, + unsigned long val, void *data) +{ + return NOTIFY_DONE; +} + static struct notifier_block kprobe_exceptions_nb = { .notifier_call = kprobe_exceptions_notify, .priority = 0x7fffffff /* we need to be notified first */
kprobe_exceptions_notify() is not used on some of the architectures such as arm[64] and powerpc anymore. Introduce a weak variant for such architectures. Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> --- kernel/kprobes.c | 6 ++++++ 1 file changed, 6 insertions(+)