| Message ID | 1486531862-31945-1-git-send-email-dawei.chien@mediatek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On 02/08/2017 06:31 AM, Dawei Chien wrote: > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > However, Currently thermal driver don't need read TEMP_MSR3 since > thermal controller only use 3 sensors for each thermal bank. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- Actually the commit message should state: Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") ...and get backported to v4.9 and v4.10. Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Regards, Matthias > drivers/thermal/mtk_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 34169c3..c124151 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -191,7 +191,7 @@ struct mtk_thermal { > }; > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > }; > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Matthias, On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: > > On 02/08/2017 06:31 AM, Dawei Chien wrote: > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > > However, Currently thermal driver don't need read TEMP_MSR3 since > > thermal controller only use 3 sensors for each thermal bank. > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > --- > > Actually the commit message should state: > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > ...and get backported to v4.9 and v4.10. > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > Regards, > Matthias Thank you for your review. I would add below commit message on next version. However, currently 8173 thermal driver would not read TEMP_MSR3 since thermal driver only use 3 sensors on each bank, this patch would not effect temperature. Only if thermal driver use 4 sensors on any thermal bank, would read third sensor two times, and lose fourth sensor of vale. Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > drivers/thermal/mtk_thermal.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > > index 34169c3..c124151 100644 > > --- a/drivers/thermal/mtk_thermal.c > > +++ b/drivers/thermal/mtk_thermal.c > > @@ -191,7 +191,7 @@ struct mtk_thermal { > > }; > > > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > > }; > > > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { > > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote: > Hi, Matthias, > > On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: > > > > On 02/08/2017 06:31 AM, Dawei Chien wrote: > > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > > > However, Currently thermal driver don't need read TEMP_MSR3 since > > > thermal controller only use 3 sensors for each thermal bank. > > > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > > --- > > > > Actually the commit message should state: > > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > > > ...and get backported to v4.9 and v4.10. > > > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > > Regards, > > Matthias > > Thank you for your review. I would add below commit message on next > version. However, currently 8173 thermal driver would not read TEMP_MSR3 > since thermal driver only use 3 sensors on each bank, this patch would > not effect temperature. > Only if thermal driver use 4 sensors on any thermal bank, would read > third sensor two times, and lose fourth sensor of vale. > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > Please send a new version with the tag in the commit message.
On 19/02/17 02:23, Eduardo Valentin wrote: > On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote: >> Hi, Matthias, >> >> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: >>> >>> On 02/08/2017 06:31 AM, Dawei Chien wrote: >>>> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. >>>> However, Currently thermal driver don't need read TEMP_MSR3 since >>>> thermal controller only use 3 sensors for each thermal bank. >>>> >>>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> >>>> --- >>> >>> Actually the commit message should state: >>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") >>> >>> ...and get backported to v4.9 and v4.10. >>> >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >>> >>> Regards, >>> Matthias >> >> Thank you for your review. I would add below commit message on next >> version. However, currently 8173 thermal driver would not read TEMP_MSR3 >> since thermal driver only use 3 sensors on each bank, this patch would >> not effect temperature. >> Only if thermal driver use 4 sensors on any thermal bank, would read >> third sensor two times, and lose fourth sensor of vale. >> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") >> > > Please send a new version with the tag in the commit message. > And don't forget to add stable@vger.kernel.org so that the fix ends up in the older kernels as well. Regards, Matthias
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index 34169c3..c124151 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -191,7 +191,7 @@ struct mtk_thermal { }; const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 }; const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. However, Currently thermal driver don't need read TEMP_MSR3 since thermal controller only use 3 sensors for each thermal bank. Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> --- drivers/thermal/mtk_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)