| Message ID | 1487249883-7013-1-git-send-email-alex.hung@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Thursday 16 February 2017 20:58:03 Alex Hung wrote: > This is to support Latitude 7480 and many other newer Dell laptops. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> Looks good. Maybe should be this change backported to stable? Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > --- > drivers/platform/x86/dell-laptop.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index 277656c..6174854 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -109,6 +109,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = { > }, > }, > { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ > + }, > + }, > + { > .ident = "Dell Computer Corporation", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
On Thu, Feb 16, 2017 at 02:22:21PM +0100, Pali Rohár wrote: > On Thursday 16 February 2017 20:58:03 Alex Hung wrote: > > This is to support Latitude 7480 and many other newer Dell laptops. > > > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > > Looks good. Maybe should be this change backported to stable? Applied. I'd want to see testing on the previous kernels to ensure all the necessary support for those laptops has also been backported before sending DMI matches back. We don't want to end up with just the DMI matches in stable kernels, but inadvertently omit some functional change those machines require which have been added since the stable release. Thanks,
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 277656c..6174854 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -109,6 +109,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = { }, }, { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ + }, + }, + { .ident = "Dell Computer Corporation", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
This is to support Latitude 7480 and many other newer Dell laptops. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/platform/x86/dell-laptop.c | 6 ++++++ 1 file changed, 6 insertions(+)