| Message ID | 20170214213005.2848151-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote: > A randconfig build ran into this rare link error: > > drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops' > drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops' > > This adds the missing 'select'. > > Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Queued as a fix for 4.11, thanks! Maxime
On Thu, Feb 16, 2017 at 6:53 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote: >> A randconfig build ran into this rare link error: >> >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops' >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops' >> >> This adds the missing 'select'. >> >> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Queued as a fix for 4.11, thanks! I just checked my old patches and this seems to still be required as of 4.11-rc2. I see it in linux-next through sunxi/sunxi/for-next, but not as part of a clk-fixes merge. Arnd
Hi Arnd, On Mon, Mar 13, 2017 at 05:24:10PM +0100, Arnd Bergmann wrote: > On Thu, Feb 16, 2017 at 6:53 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote: > >> A randconfig build ran into this rare link error: > >> > >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops' > >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops' > >> > >> This adds the missing 'select'. > >> > >> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver") > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > Queued as a fix for 4.11, thanks! > > I just checked my old patches and this seems to still be required as of > 4.11-rc2. I see it in linux-next through sunxi/sunxi/for-next, but not as > part of a clk-fixes merge. Sorry, I went to holidays without sending the PR. I just did, hopefully, it should be on Linus' way for the next rc. Maxime
diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig index 695bbf9ef428..b6e2aa5d0246 100644 --- a/drivers/clk/sunxi-ng/Kconfig +++ b/drivers/clk/sunxi-ng/Kconfig @@ -70,6 +70,7 @@ config SUN5I_CCU select SUNXI_CCU_MULT select SUNXI_CCU_NK select SUNXI_CCU_NKM + select SUNXI_CCU_NKMP select SUNXI_CCU_NM select SUNXI_CCU_MP select SUNXI_CCU_PHASE
A randconfig build ran into this rare link error: drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops' drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops' This adds the missing 'select'. Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/clk/sunxi-ng/Kconfig | 1 + 1 file changed, 1 insertion(+)