diff mbox

[v2,1/3] fpga: Add flag to indicate bitstream needs decrypting

Message ID 1487624123-13579-1-git-send-email-mdf@kernel.org (mailing list archive)
State Accepted, archived
Delegated to: Moritz Fischer
Headers show

Commit Message

Moritz Fischer Feb. 20, 2017, 8:55 p.m. UTC 
From: Moritz Fischer <mdf@kernel.org>

Add a flag that is passed to the write_init() callback, indicating
that the bitstream is encrypted.

The low-level driver will deal with the flag, or return an error,
if encrypted bitstreams are not supported.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
Cc: Alan Tull <atull@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
---

Changes from v1:
- Renamed flag from FPGA_MGR_DECRYPT_BITSTREAM->FPGA_MGR_ENCRYPTED_BITSTREAM

---
 include/linux/fpga/fpga-mgr.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Michal Simek Feb. 21, 2017, 1:55 p.m. UTC | #1 
On 20.2.2017 21:55, mdf@kernel.org wrote:
> From: Moritz Fischer <mdf@kernel.org>
> 
> Add a flag that is passed to the write_init() callback, indicating
> that the bitstream is encrypted.
> 
> The low-level driver will deal with the flag, or return an error,
> if encrypted bitstreams are not supported.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-fpga@vger.kernel.org
> ---
> 
> Changes from v1:
> - Renamed flag from FPGA_MGR_DECRYPT_BITSTREAM->FPGA_MGR_ENCRYPTED_BITSTREAM
> 
> ---
>  include/linux/fpga/fpga-mgr.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 57beb5d..e2ef94f 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
>   */
>  #define FPGA_MGR_PARTIAL_RECONFIG	BIT(0)
>  #define FPGA_MGR_EXTERNAL_CONFIG	BIT(1)
> +#define FPGA_MGR_ENCRYPTED_BITSTREAM	BIT(2)
>  
>  /**
>   * struct fpga_image_info - information specific to a FPGA image
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull Feb. 21, 2017, 4:35 p.m. UTC | #2 
On Tue, Feb 21, 2017 at 7:55 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 20.2.2017 21:55, mdf@kernel.org wrote:
>> From: Moritz Fischer <mdf@kernel.org>
>>
>> Add a flag that is passed to the write_init() callback, indicating
>> that the bitstream is encrypted.
>>
>> The low-level driver will deal with the flag, or return an error,
>> if encrypted bitstreams are not supported.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-fpga@vger.kernel.org
>> ---
>>
>> Changes from v1:
>> - Renamed flag from FPGA_MGR_DECRYPT_BITSTREAM->FPGA_MGR_ENCRYPTED_BITSTREAM
>>
>> ---
>>  include/linux/fpga/fpga-mgr.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>> index 57beb5d..e2ef94f 100644
>> --- a/include/linux/fpga/fpga-mgr.h
>> +++ b/include/linux/fpga/fpga-mgr.h
>> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
>>   */
>>  #define FPGA_MGR_PARTIAL_RECONFIG    BIT(0)
>>  #define FPGA_MGR_EXTERNAL_CONFIG     BIT(1)
>> +#define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2)
>>
>>  /**
>>   * struct fpga_image_info - information specific to a FPGA image
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>

Acked-by: Alan Tull <atull@kernel.org>

>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull Feb. 21, 2017, 6:26 p.m. UTC | #3 
On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>

Hi Greg,

Would it be helpful for us to resend patches for you to take with you
on cc?  Or is it enough that they are on lkml?

Thanks,
Alan Tull

wrote:
> On Tue, Feb 21, 2017 at 7:55 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 20.2.2017 21:55, mdf@kernel.org wrote:
>>> From: Moritz Fischer <mdf@kernel.org>
>>>
>>> Add a flag that is passed to the write_init() callback, indicating
>>> that the bitstream is encrypted.
>>>
>>> The low-level driver will deal with the flag, or return an error,
>>> if encrypted bitstreams are not supported.
>>>
>>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>>> Cc: Alan Tull <atull@kernel.org>
>>> Cc: Michal Simek <michal.simek@xilinx.com>
>>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>>> Cc: linux-kernel@vger.kernel.org
>>> Cc: linux-fpga@vger.kernel.org
>>> ---
>>>
>>> Changes from v1:
>>> - Renamed flag from FPGA_MGR_DECRYPT_BITSTREAM->FPGA_MGR_ENCRYPTED_BITSTREAM
>>>
>>> ---
>>>  include/linux/fpga/fpga-mgr.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>>> index 57beb5d..e2ef94f 100644
>>> --- a/include/linux/fpga/fpga-mgr.h
>>> +++ b/include/linux/fpga/fpga-mgr.h
>>> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
>>>   */
>>>  #define FPGA_MGR_PARTIAL_RECONFIG    BIT(0)
>>>  #define FPGA_MGR_EXTERNAL_CONFIG     BIT(1)
>>> +#define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2)
>>>
>>>  /**
>>>   * struct fpga_image_info - information specific to a FPGA image
>>>
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Acked-by: Alan Tull <atull@kernel.org>
>
>>
>> Thanks,
>> Michal
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Simek Feb. 21, 2017, 6:36 p.m. UTC | #4 
On 21.2.2017 19:26, Alan Tull wrote:
> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
> 
> Hi Greg,
> 
> Would it be helpful for us to resend patches for you to take with you
> on cc?  Or is it enough that they are on lkml?

Can I know the reason for this? I know that there were some discussion
in past. But just add them to your linux-fpga.git repo and send pull
request to Greg and proper time when he expects that.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull Feb. 21, 2017, 6:38 p.m. UTC | #5 
On Tue, Feb 21, 2017 at 12:36 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 21.2.2017 19:26, Alan Tull wrote:
>> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
>>
>> Hi Greg,
>>
>> Would it be helpful for us to resend patches for you to take with you
>> on cc?  Or is it enough that they are on lkml?
>
> Can I know the reason for this? I know that there were some discussion
> in past. But just add them to your linux-fpga.git repo and send pull
> request to Greg and proper time when he expects that.
>

Greg said it was easier for him to take them from email.

Alan

> Thanks,
> Michal
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman Feb. 22, 2017, 7:15 a.m. UTC | #6 
On Tue, Feb 21, 2017 at 12:26:17PM -0600, Alan Tull wrote:
> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
> 
> Hi Greg,
> 
> Would it be helpful for us to resend patches for you to take with you
> on cc?  Or is it enough that they are on lkml?

Yes, please send patches with your signed-off-by: for what I should
take.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Simek Feb. 22, 2017, 8:22 a.m. UTC | #7 
On 22.2.2017 08:15, Greg Kroah-Hartman wrote:
> On Tue, Feb 21, 2017 at 12:26:17PM -0600, Alan Tull wrote:
>> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
>>
>> Hi Greg,
>>
>> Would it be helpful for us to resend patches for you to take with you
>> on cc?  Or is it enough that they are on lkml?
> 
> Yes, please send patches with your signed-off-by: for what I should
> take.

Does it make sense to have git repo in MAINTAINERS file then?

T:	git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman Feb. 22, 2017, 1:04 p.m. UTC | #8 
On Wed, Feb 22, 2017 at 09:22:19AM +0100, Michal Simek wrote:
> On 22.2.2017 08:15, Greg Kroah-Hartman wrote:
> > On Tue, Feb 21, 2017 at 12:26:17PM -0600, Alan Tull wrote:
> >> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
> >>
> >> Hi Greg,
> >>
> >> Would it be helpful for us to resend patches for you to take with you
> >> on cc?  Or is it enough that they are on lkml?
> > 
> > Yes, please send patches with your signed-off-by: for what I should
> > take.
> 
> Does it make sense to have git repo in MAINTAINERS file then?
> 
> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git

Why not, that doesn't mean that's where they get pulled from, but
rather, where the latest version of the patches can be found at.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Simek Feb. 22, 2017, 1:24 p.m. UTC | #9 
On 22.2.2017 14:04, Greg Kroah-Hartman wrote:
> On Wed, Feb 22, 2017 at 09:22:19AM +0100, Michal Simek wrote:
>> On 22.2.2017 08:15, Greg Kroah-Hartman wrote:
>>> On Tue, Feb 21, 2017 at 12:26:17PM -0600, Alan Tull wrote:
>>>> On Tue, Feb 21, 2017 at 10:35 AM, Alan Tull <delicious.quinoa@gmail.com>
>>>>
>>>> Hi Greg,
>>>>
>>>> Would it be helpful for us to resend patches for you to take with you
>>>> on cc?  Or is it enough that they are on lkml?
>>>
>>> Yes, please send patches with your signed-off-by: for what I should
>>> take.
>>
>> Does it make sense to have git repo in MAINTAINERS file then?
>>
>> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git
> 
> Why not, that doesn't mean that's where they get pulled from, but
> rather, where the latest version of the patches can be found at.

ok.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
index 57beb5d..e2ef94f 100644
--- a/include/linux/fpga/fpga-mgr.h
+++ b/include/linux/fpga/fpga-mgr.h
@@ -70,6 +70,7 @@  enum fpga_mgr_states {
  */
 #define FPGA_MGR_PARTIAL_RECONFIG	BIT(0)
 #define FPGA_MGR_EXTERNAL_CONFIG	BIT(1)
+#define FPGA_MGR_ENCRYPTED_BITSTREAM	BIT(2)
 
 /**
  * struct fpga_image_info - information specific to a FPGA image