diff mbox

drm: zte: fix static checker warning on variable 'fmt'

Message ID 1487598551-28310-1-git-send-email-shawnguo@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Guo Feb. 20, 2017, 1:49 p.m. UTC 
From: Shawn Guo <shawn.guo@linaro.org>

Commit 4e986d3705df ("drm: zte: add overlay plane support") introduces
the following static checker warning:

 drivers/gpu/drm/zte/zx_plane.c:170 zx_vl_rsz_setup()
 warn: always true condition '(fmt >= 0) => (0-u32max >= 0)'

Fix it by change 'fmt' type to integer.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 4e986d3705df ("drm: zte: add overlay plane support")
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/gpu/drm/zte/zx_plane.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sean Paul Feb. 21, 2017, 9:22 p.m. UTC | #1 
On Mon, Feb 20, 2017 at 8:49 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
>
> Commit 4e986d3705df ("drm: zte: add overlay plane support") introduces
> the following static checker warning:
>
>  drivers/gpu/drm/zte/zx_plane.c:170 zx_vl_rsz_setup()
>  warn: always true condition '(fmt >= 0) => (0-u32max >= 0)'
>
> Fix it by change 'fmt' type to integer.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 4e986d3705df ("drm: zte: add overlay plane support")
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
>  drivers/gpu/drm/zte/zx_plane.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c
> index 1d08ba381098..d646ac931663 100644
> --- a/drivers/gpu/drm/zte/zx_plane.c
> +++ b/drivers/gpu/drm/zte/zx_plane.c
> @@ -159,7 +159,7 @@ static void zx_vl_rsz_setup(struct zx_plane *zplane, uint32_t format,
>         void __iomem *rsz = zplane->rsz;
>         u32 src_chroma_w = src_w;
>         u32 src_chroma_h = src_h;
> -       u32 fmt;
> +       int fmt;
>
>         /* Set up source and destination resolution */
>         zx_writel(rsz + RSZ_SRC_CFG, RSZ_VER(src_h - 1) | RSZ_HOR(src_w - 1));
> @@ -203,7 +203,7 @@ static void zx_vl_plane_atomic_update(struct drm_plane *plane,
>         u32 src_x, src_y, src_w, src_h;
>         u32 dst_x, dst_y, dst_w, dst_h;
>         uint32_t format;
> -       u32 fmt;
> +       int fmt;
>         int num_planes;
>         int i;
>
> --
> 1.9.1
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c
index 1d08ba381098..d646ac931663 100644
--- a/drivers/gpu/drm/zte/zx_plane.c
+++ b/drivers/gpu/drm/zte/zx_plane.c
@@ -159,7 +159,7 @@  static void zx_vl_rsz_setup(struct zx_plane *zplane, uint32_t format,
 	void __iomem *rsz = zplane->rsz;
 	u32 src_chroma_w = src_w;
 	u32 src_chroma_h = src_h;
-	u32 fmt;
+	int fmt;
 
 	/* Set up source and destination resolution */
 	zx_writel(rsz + RSZ_SRC_CFG, RSZ_VER(src_h - 1) | RSZ_HOR(src_w - 1));
@@ -203,7 +203,7 @@  static void zx_vl_plane_atomic_update(struct drm_plane *plane,
 	u32 src_x, src_y, src_w, src_h;
 	u32 dst_x, dst_y, dst_w, dst_h;
 	uint32_t format;
-	u32 fmt;
+	int fmt;
 	int num_planes;
 	int i;