| Message ID | 20110627153234.6bea33aa@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 27, 2011 at 3:32 PM, Jean Delvare wrote: > * print_hex_dump_bytes() already includes a log level, so we shouldn't > add one. That log level is KERN_DEBUG so use the same for our header > for consistency. > * print_hex_dump_bytes() properly puts a newline at the end of the > last line, so there is no reason why we would add another one. > > Signed-off-by: Jean Delvare <khali@linux-fr.org> > Cc: David Airlie <airlied@linux.ie> Please also consider the alternative patch I posted here a week ago: http://lists.freedesktop.org/archives/dri-devel/2011-June/012264.html It preserves KERN_ERR, however it does not remove the extra newline. Cheers, Tormod
--- linux-3.0-rc4.orig/drivers/gpu/drm/drm_edid.c 2011-06-22 16:55:11.000000000 +0200 +++ linux-3.0-rc4/drivers/gpu/drm/drm_edid.c 2011-06-27 15:11:53.000000000 +0200 @@ -184,9 +184,9 @@ drm_edid_block_valid(u8 *raw_edid) bad: if (raw_edid) { - printk(KERN_ERR "Raw EDID:\n"); - print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH); - printk(KERN_ERR "\n"); + printk(KERN_DEBUG "Raw EDID:\n"); + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, + raw_edid, EDID_LENGTH); } return 0; }
* print_hex_dump_bytes() already includes a log level, so we shouldn't add one. That log level is KERN_DEBUG so use the same for our header for consistency. * print_hex_dump_bytes() properly puts a newline at the end of the last line, so there is no reason why we would add another one. Signed-off-by: Jean Delvare <khali@linux-fr.org> Cc: David Airlie <airlied@linux.ie> --- drivers/gpu/drm/drm_edid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)