| Message ID | 1488278415-2786-3-git-send-email-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 28, 2017 at 12:40:15PM +0200, Claudiu Beznea wrote: > sama5d2 can use the same atmel_pwm_data as sama5d3. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > Documentation/devicetree/bindings/pwm/atmel-pwm.txt | 1 + > drivers/pwm/pwm-atmel.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt > index 02331b9..c8c831d 100644 > --- a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt > +++ b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: should be one of: > - "atmel,at91sam9rl-pwm" > - "atmel,sama5d3-pwm" > + - "atmel,sama5d2-pwm" Perhaps sama5d3 should be a fallback, then you don't need a driver change. Rob
Hi, On 03.03.2017 08:21, Rob Herring wrote: > On Tue, Feb 28, 2017 at 12:40:15PM +0200, Claudiu Beznea wrote: >> sama5d2 can use the same atmel_pwm_data as sama5d3. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> Documentation/devicetree/bindings/pwm/atmel-pwm.txt | 1 + >> drivers/pwm/pwm-atmel.c | 3 +++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt >> index 02331b9..c8c831d 100644 >> --- a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt >> +++ b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt >> @@ -4,6 +4,7 @@ Required properties: >> - compatible: should be one of: >> - "atmel,at91sam9rl-pwm" >> - "atmel,sama5d3-pwm" >> + - "atmel,sama5d2-pwm" > Perhaps sama5d3 should be a fallback, then you don't need a driver > change. > > Rob sama5d2 PWM controller have additional features. We intend to support some of these. This is why I choose to add specific compatible string for it. Thank you, Claudiu Beznea
diff --git a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt index 02331b9..c8c831d 100644 --- a/Documentation/devicetree/bindings/pwm/atmel-pwm.txt +++ b/Documentation/devicetree/bindings/pwm/atmel-pwm.txt @@ -4,6 +4,7 @@ Required properties: - compatible: should be one of: - "atmel,at91sam9rl-pwm" - "atmel,sama5d3-pwm" + - "atmel,sama5d2-pwm" - reg: physical base address and length of the controller's registers - #pwm-cells: Should be 3. See pwm.txt in this directory for a description of the cells format. diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index 014b86c..209e877 100644 --- a/drivers/pwm/pwm-atmel.c +++ b/drivers/pwm/pwm-atmel.c @@ -346,6 +346,9 @@ static const struct of_device_id atmel_pwm_dt_ids[] = { .compatible = "atmel,sama5d3-pwm", .data = &atmel_pwm_data_v2, }, { + .compatible = "atmel,sama5d2-pwm", + .data = &atmel_pwm_data_v2, + }, { /* sentinel */ }, };
sama5d2 can use the same atmel_pwm_data as sama5d3. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- Documentation/devicetree/bindings/pwm/atmel-pwm.txt | 1 + drivers/pwm/pwm-atmel.c | 3 +++ 2 files changed, 4 insertions(+)