diff mbox

[v7,1/6] ARM: dts: sun8i: drop skeleton.dtsi inclusion in H3 DTSI

Message ID 20170305233138.64574-2-icenowy@aosc.xyz (mailing list archive)
State New, archived
Headers show

Commit Message

Icenowy Zheng March 5, 2017, 11:31 p.m. UTC
The skeleton.dtsi file is now deprecated, and do not exist in ARM64
environment.

Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
chip, drop skeleton.dtsi inclusion now.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
New patch extracted in v7.

 arch/arm/boot/dts/sun8i-h3.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Maxime Ripard March 6, 2017, 10:35 a.m. UTC | #1
Hi,

On Mon, Mar 06, 2017 at 07:31:33AM +0800, Icenowy Zheng wrote:
> The skeleton.dtsi file is now deprecated, and do not exist in ARM64
> environment.
> 
> Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
> chip, drop skeleton.dtsi inclusion now.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Your prefix (and in the three later patches) should be
ARM: sun8i: h3

Maxime
Icenowy Zheng March 6, 2017, 10:46 a.m. UTC | #2
06.03.2017, 18:35, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Mon, Mar 06, 2017 at 07:31:33AM +0800, Icenowy Zheng wrote:
>>  The skeleton.dtsi file is now deprecated, and do not exist in ARM64
>>  environment.
>>
>>  Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
>>  chip, drop skeleton.dtsi inclusion now.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> Your prefix (and in the three later patches) should be
> ARM: sun8i: h3

Oh I think we never added SoC name in prefix...

>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
Chen-Yu Tsai March 6, 2017, 10:48 a.m. UTC | #3
On Mon, Mar 6, 2017 at 6:46 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>
>
> 06.03.2017, 18:35, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
>> Hi,
>>
>> On Mon, Mar 06, 2017 at 07:31:33AM +0800, Icenowy Zheng wrote:
>>>  The skeleton.dtsi file is now deprecated, and do not exist in ARM64
>>>  environment.
>>>
>>>  Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
>>>  chip, drop skeleton.dtsi inclusion now.
>>>
>>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>
>> Your prefix (and in the three later patches) should be
>> ARM: sun8i: h3
>
> Oh I think we never added SoC name in prefix...

It's better to add them for sun8i, which encompasses a whole
bunch of SoCs, unlike the older sun[4-7]i. Even sun5i patches
have them.

ChenYu
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 27780b97c863..9a3435527fde 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -40,8 +40,6 @@ 
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "skeleton.dtsi"
-
 #include <dt-bindings/clock/sun8i-h3-ccu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/pinctrl/sun4i-a10.h>