| Message ID | 20170311172527.16368-5-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 03/11/2017 09:25 AM, Krzysztof Kozlowski wrote: > Watchdog module does not have external dependencies so it can be safely > enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > boards. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > arch/arm/boot/dts/s3c64xx.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi > index 0ccb414cd268..6caec5f27d38 100644 > --- a/arch/arm/boot/dts/s3c64xx.dtsi > +++ b/arch/arm/boot/dts/s3c64xx.dtsi > @@ -100,7 +100,6 @@ > interrupts = <26>; > clock-names = "watchdog"; > clocks = <&clocks PCLK_WDT>; > - status = "disabled"; > }; > > i2c0: i2c@7f004000 { > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > Watchdog module does not have external dependencies so it can be safely > enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > boards. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Please first fix the driver w.r.t. infinite interrupt in soft mode issue and only then enable it on more hardware. IOW this patch should be placed after patch #7 in the series. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: >> Watchdog module does not have external dependencies so it can be safely >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based >> boards. >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Please first fix the driver w.r.t. infinite interrupt in soft mode > issue and only then enable it on more hardware. IOW this patch > should be placed after patch #7 in the series. The soft-interrupt mode is not the default one so this should not cause any issues by default but I got your point. Makes sense. The pity is the timing. There wasn't much interest in the patchset (no comments since 24 of Feb) so I merged it yesterday evening. Does it brake any platform/board? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > >> Watchdog module does not have external dependencies so it can be safely > >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > >> boards. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > Please first fix the driver w.r.t. infinite interrupt in soft mode > > issue and only then enable it on more hardware. IOW this patch > > should be placed after patch #7 in the series. > > The soft-interrupt mode is not the default one so this should not > cause any issues by default but I got your point. Makes sense. The > pity is the timing. There wasn't much interest in the patchset (no > comments since 24 of Feb) so I merged it yesterday evening. Does it > brake any platform/board? OK, let it be as it as it doesn't break the default setup. However please consider the fact that posting revised patches (v2 was posted *yesterday*) for a review and then merging them the same day is not a good practice.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 14, 2017 at 3:30 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote: >> On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz >> <b.zolnierkie@samsung.com> wrote: >> > >> > Hi, >> > >> > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: >> >> Watchdog module does not have external dependencies so it can be safely >> >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based >> >> boards. >> >> >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> > >> > Please first fix the driver w.r.t. infinite interrupt in soft mode >> > issue and only then enable it on more hardware. IOW this patch >> > should be placed after patch #7 in the series. >> >> The soft-interrupt mode is not the default one so this should not >> cause any issues by default but I got your point. Makes sense. The >> pity is the timing. There wasn't much interest in the patchset (no >> comments since 24 of Feb) so I merged it yesterday evening. Does it >> brake any platform/board? > > OK, let it be as it as it doesn't break the default setup. > > However please consider the fact that posting revised patches > (v2 was posted *yesterday*) for a review and then merging them > the same day is not a good practice.. v2 was posted on March 11, not yesterday but I got the point that the rest of world is working from Monday not Sunday. :) And v1 was on 24 of Feb. Usually I try to give them more time but recently there is so less interest in this that I gave up waiting. I will give them more time in the future. Thanks for review! Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi index 0ccb414cd268..6caec5f27d38 100644 --- a/arch/arm/boot/dts/s3c64xx.dtsi +++ b/arch/arm/boot/dts/s3c64xx.dtsi @@ -100,7 +100,6 @@ interrupts = <26>; clock-names = "watchdog"; clocks = <&clocks PCLK_WDT>; - status = "disabled"; }; i2c0: i2c@7f004000 {
Watchdog module does not have external dependencies so it can be safely enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based boards. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/boot/dts/s3c64xx.dtsi | 1 - 1 file changed, 1 deletion(-)