| Message ID | 20170311190124.11512-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Dear all, All patches in this series looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Best Regards, Chanwoo Choi On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote: > Static struct regulator_ops is not modified so can be made const for > code safeness. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/regulator/max1586.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c > index 2c1228d5796a..6779c2b53674 100644 > --- a/drivers/regulator/max1586.c > +++ b/drivers/regulator/max1586.c > @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev, > * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back > * the set up value. > */ > -static struct regulator_ops max1586_v3_ops = { > +static const struct regulator_ops max1586_v3_ops = { > .get_voltage_sel = max1586_v3_get_voltage_sel, > .set_voltage_sel = max1586_v3_set_voltage_sel, > .list_voltage = regulator_list_voltage_linear, > .map_voltage = regulator_map_voltage_linear, > }; > > -static struct regulator_ops max1586_v6_ops = { > +static const struct regulator_ops max1586_v6_ops = { > .get_voltage_sel = max1586_v6_get_voltage_sel, > .set_voltage_sel = max1586_v6_set_voltage_sel, > .list_voltage = regulator_list_voltage_table, > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c index 2c1228d5796a..6779c2b53674 100644 --- a/drivers/regulator/max1586.c +++ b/drivers/regulator/max1586.c @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev, * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back * the set up value. */ -static struct regulator_ops max1586_v3_ops = { +static const struct regulator_ops max1586_v3_ops = { .get_voltage_sel = max1586_v3_get_voltage_sel, .set_voltage_sel = max1586_v3_set_voltage_sel, .list_voltage = regulator_list_voltage_linear, .map_voltage = regulator_map_voltage_linear, }; -static struct regulator_ops max1586_v6_ops = { +static const struct regulator_ops max1586_v6_ops = { .get_voltage_sel = max1586_v6_get_voltage_sel, .set_voltage_sel = max1586_v6_set_voltage_sel, .list_voltage = regulator_list_voltage_table,
Static struct regulator_ops is not modified so can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/regulator/max1586.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)