| Message ID | 20170228190815.10699-1-icenowy@aosc.xyz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 28, 2017 at 8:08 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote: > Allwinner pin controllers are also GPIO controllers. > > Currently, if GPIOLIB is forgot to be chosen, the build of > pinctrl-sunxi.c will fail for lacking a lot of gpiochip_* functions. > > Select GPIOLIB to ensure this driver can be built. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > --- > This bug is found when I try to add sunxi drivers on an ARM64 > allnoconfig, in order to prove that sunxi-ng ccu driver depends on > reset_controller framework. > > I proved the latter dependency, but how to satisfy it still needs > some discussion. Patch applied. This is the right thing to do. We used to have a restriction such that a pin control driver could not simply select GPIOLIB, because the selection had to be done from the platform instead. But we have fixed that! We can now select GPIOLIB directly from any driver that needs it. Yours, Linus Walleij
diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig index 816015cf7053..e25d0daa660a 100644 --- a/drivers/pinctrl/sunxi/Kconfig +++ b/drivers/pinctrl/sunxi/Kconfig @@ -4,6 +4,7 @@ config PINCTRL_SUNXI bool select PINMUX select GENERIC_PINCONF + select GPIOLIB config PINCTRL_SUN4I_A10 def_bool MACH_SUN4I
Allwinner pin controllers are also GPIO controllers. Currently, if GPIOLIB is forgot to be chosen, the build of pinctrl-sunxi.c will fail for lacking a lot of gpiochip_* functions. Select GPIOLIB to ensure this driver can be built. Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> --- This bug is found when I try to add sunxi drivers on an ARM64 allnoconfig, in order to prove that sunxi-ng ccu driver depends on reset_controller framework. I proved the latter dependency, but how to satisfy it still needs some discussion. drivers/pinctrl/sunxi/Kconfig | 1 + 1 file changed, 1 insertion(+)