| Message ID | 20170314123451.GA51889@lkp-sb04.lkp.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, > vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL); > - if (IS_ERR(vbuf)) > + if (!vbuf) > return ERR_CAST(vbuf); Well, ERR_CAST(vbuf) isn't correct either ... correct fix has been committed to drm-misc-next today and should show up in linux-next shortly. cheers, Gerd
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -97,7 +97,7 @@ virtio_gpu_get_vbuf(struct virtio_gpu_de struct virtio_gpu_vbuffer *vbuf; vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL); - if (IS_ERR(vbuf)) + if (!vbuf) return ERR_CAST(vbuf); memset(vbuf, 0, VBUFFER_SIZE);
drivers/gpu/drm/virtio/virtgpu_vq.c:100:5-11: ERROR: allocation function on line 99 returns NULL not ERR_PTR on failure The various basic memory allocation functions don't return ERR_PTR Generated by: scripts/coccinelle/null/eno.cocci Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)