| Message ID | e89902c0c99d0daf9ef821dd7a9c67e866b18a94.1488798062.git.roliveir@synopsys.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 06, 2017 at 11:16:33AM +0000, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt There's no changelog here, so I can't tell if anything is changed, but I acked v7. Please add acks when sending new versions.
Hi Rob On 3/15/2017 4:42 PM, Rob Herring wrote: > On Mon, Mar 06, 2017 at 11:16:33AM +0000, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> >> --- >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt > > There's no changelog here, so I can't tell if anything is changed, but I > acked v7. Please add acks when sending new versions. > The changelog is in the cover letter, although I didn't specify which changes where made in the driver and which were made in the Documentation. The only change was removing the clock name since there was only one clock used. Should I keep your ack?
On Wed, Mar 15, 2017 at 11:51 AM, Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> wrote: > Hi Rob > > On 3/15/2017 4:42 PM, Rob Herring wrote: >> On Mon, Mar 06, 2017 at 11:16:33AM +0000, Ramiro Oliveira wrote: >>> Create device tree bindings documentation. >>> >>> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> >>> --- >>> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ >>> 1 file changed, 35 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt >> >> There's no changelog here, so I can't tell if anything is changed, but I >> acked v7. Please add acks when sending new versions. >> > > The changelog is in the cover letter, although I didn't specify which changes > where made in the driver and which were made in the Documentation. > > The only change was removing the clock name since there was only one clock used. > > Should I keep your ack? Yes. Rob
Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> The device tree binding description looks perfect from my perspective. Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> -- With best wishes, Vladimir
diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt new file mode 100644 index 000000000000..22e44945b661 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt @@ -0,0 +1,35 @@ +Omnivision OV5647 raw image sensor +--------------------------------- + +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces +and CCI (I2C compatible) control bus. + +Required properties: + +- compatible : "ovti,ov5647". +- reg : I2C slave address of the sensor. +- clocks : Reference to the xclk clock. + +The common video interfaces bindings (see video-interfaces.txt) should be +used to specify link to the image data receiver. The OV5647 device +node should contain one 'port' child node with an 'endpoint' subnode. + +Endpoint node mandatory properties: + +- remote-endpoint: A phandle to the bus receiver's endpoint node. + +Example: + + i2c@2000 { + ... + ov: camera@36 { + compatible = "ovti,ov5647"; + reg = <0x36>; + clocks = <&camera_clk>; + port { + camera_1: endpoint { + remote-endpoint = <&csi1_ep1>; + }; + }; + }; + };
Create device tree bindings documentation. Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> --- .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt