| Message ID | 20170321001411.GA142235@beast (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-03-21 9:14 GMT+09:00 Kees Cook <keescook@chromium.org>: > If a structure is marked with __attribute__((designated_init)) from > GCC or Sparse, it needs to have all static initializers using designated > initialization. Fail the build for any missing cases. This attribute will > be used by the randstruct plugin to make sure randomized structures are > being correctly initialized. > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > v2: update subject to more clearly describe change, Masahiro Yamada > --- Applied to linux-kbuild/kbuild. Thanks!
diff --git a/Makefile b/Makefile index b841fb36beb2..142ab7b96130 100644 --- a/Makefile +++ b/Makefile @@ -795,6 +795,9 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=date-time) # enforce correct pointer usage KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) +# Require designated initializers for all marked structures +KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init) + # use the deterministic mode of AR if available KBUILD_ARFLAGS := $(call ar-option,D)
If a structure is marked with __attribute__((designated_init)) from GCC or Sparse, it needs to have all static initializers using designated initialization. Fail the build for any missing cases. This attribute will be used by the randstruct plugin to make sure randomized structures are being correctly initialized. Signed-off-by: Kees Cook <keescook@chromium.org> --- v2: update subject to more clearly describe change, Masahiro Yamada --- Makefile | 3 +++ 1 file changed, 3 insertions(+)