| Message ID | 1490193218-24806-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks for this patch, Jani. Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> Regards Shashank On 3/22/2017 4:33 PM, Jani Nikula wrote: > Fix sparse warning: > > drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol > 'drm_scdc_get_scrambling_status' was not declared. Should it be static? > > Fixes: 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB") > Cc: Shashank Sharma <shashank.sharma@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_scdc_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > index ab6bcfbceba9..c25122bb490a 100644 > --- a/include/drm/drm_scdc_helper.h > +++ b/include/drm/drm_scdc_helper.h > @@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset, > return drm_scdc_write(adapter, offset, &value, sizeof(value)); > } > > +bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter); > + > /** > * drm_scdc_set_scrambling - enable scrambling > * @adapter: I2C adapter for DDC channel
On Wed, 22 Mar 2017, "Sharma, Shashank" <shashank.sharma@intel.com> wrote: > Thanks for this patch, Jani. > > Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> And pushed to drm-misc-next, thanks for the review. BR, Jani. > > > Regards > Shashank > On 3/22/2017 4:33 PM, Jani Nikula wrote: >> Fix sparse warning: >> >> drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol >> 'drm_scdc_get_scrambling_status' was not declared. Should it be static? >> >> Fixes: 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB") >> Cc: Shashank Sharma <shashank.sharma@intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> include/drm/drm_scdc_helper.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h >> index ab6bcfbceba9..c25122bb490a 100644 >> --- a/include/drm/drm_scdc_helper.h >> +++ b/include/drm/drm_scdc_helper.h >> @@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset, >> return drm_scdc_write(adapter, offset, &value, sizeof(value)); >> } >> >> +bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter); >> + >> /** >> * drm_scdc_set_scrambling - enable scrambling >> * @adapter: I2C adapter for DDC channel >
diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h index ab6bcfbceba9..c25122bb490a 100644 --- a/include/drm/drm_scdc_helper.h +++ b/include/drm/drm_scdc_helper.h @@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset, return drm_scdc_write(adapter, offset, &value, sizeof(value)); } +bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter); + /** * drm_scdc_set_scrambling - enable scrambling * @adapter: I2C adapter for DDC channel
Fix sparse warning: drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol 'drm_scdc_get_scrambling_status' was not declared. Should it be static? Fixes: 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB") Cc: Shashank Sharma <shashank.sharma@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- include/drm/drm_scdc_helper.h | 2 ++ 1 file changed, 2 insertions(+)