diff mbox

hpsa: fix volume offline state

Message ID 1490024568-4301-1-git-send-email-thenzl@redhat.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Tomas Henzl March 20, 2017, 3:42 p.m. UTC
In a previous patch a hpsa_scsi_dev_t.volume_offline update line
has been removed, so let us put it back..

Fixes: 85b29008d8 (hpsa: update check for logical volume status)

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
 drivers/scsi/hpsa.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Don Brace March 20, 2017, 4:15 p.m. UTC | #1
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Monday, March 20, 2017 10:43 AM
> To: linux-scsi@vger.kernel.org
> Cc: Don Brace <don.brace@microsemi.com>; joseph.szczypek@hpe.com
> Subject: [PATCH] hpsa: fix volume offline state
> 
> EXTERNAL EMAIL
> 
> 
> In a previous patch a hpsa_scsi_dev_t.volume_offline update line
> has been removed, so let us put it back..
> 
> Fixes: 85b29008d8 (hpsa: update check for logical volume status)
> 
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
>  drivers/scsi/hpsa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 0d0be7754a..9d659aaace 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -3885,6 +3885,7 @@ static int hpsa_update_device_info(struct
> ctlr_info *h,
>                 if (h->fw_support & MISC_FW_RAID_OFFLOAD_BASIC)
>                         hpsa_get_ioaccel_status(h, scsi3addr, this_device);
>                 volume_offline = hpsa_volume_offline(h, scsi3addr);
> +               this_device->volume_offline = volume_offline;
>                 if (volume_offline == HPSA_LV_FAILED) {
>                         rc = HPSA_LV_FAILED;
>                         dev_err(&h->pdev->dev,
> --
> 2.7.4

Acked-by: Don Brace <don.brace@microsemi.com>

Thanks Tomas.
Martin K. Petersen March 23, 2017, 2:13 p.m. UTC | #2
Tomas Henzl <thenzl@redhat.com> writes:

> In a previous patch a hpsa_scsi_dev_t.volume_offline update line
> has been removed, so let us put it back..
>
> Fixes: 85b29008d8 (hpsa: update check for logical volume status)

Applied to 4.11/scsi-fixes.
diff mbox

Patch

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 0d0be7754a..9d659aaace 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3885,6 +3885,7 @@  static int hpsa_update_device_info(struct ctlr_info *h,
 		if (h->fw_support & MISC_FW_RAID_OFFLOAD_BASIC)
 			hpsa_get_ioaccel_status(h, scsi3addr, this_device);
 		volume_offline = hpsa_volume_offline(h, scsi3addr);
+		this_device->volume_offline = volume_offline;
 		if (volume_offline == HPSA_LV_FAILED) {
 			rc = HPSA_LV_FAILED;
 			dev_err(&h->pdev->dev,