| Message ID | 1490350537-2566-1-git-send-email-paul.durrant@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 24/03/17 10:15, Paul Durrant wrote: > This patch defines a new bit in the mask used to instruct QEMU to unplug > emulated devices. See thread [1] for the related discussion. > > [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html I don't think including a link like this is really a good way to summarize what's going on. The rationale for the change, at least at a very basic level, should be included in the git tree itself. We can't be confident that link will be around for as long as someone might want to know why this decision was made. -George
> -----Original Message----- > From: George Dunlap [mailto:george.dunlap@citrix.com] > Sent: 24 March 2017 10:49 > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org > Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunlap > <George.Dunlap@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Jan > Beulich <jbeulich@suse.com>; Konrad Rzeszutek Wilk > <konrad.wilk@oracle.com>; Stefano Stabellini <sstabellini@kernel.org>; Tim > (Xen.org) <tim@xen.org>; Wei Liu <wei.liu2@citrix.com> > Subject: Re: [PATCH] docs: update HVM emulated unplug protocol to cover > NVMe disks > > On 24/03/17 10:15, Paul Durrant wrote: > > This patch defines a new bit in the mask used to instruct QEMU to unplug > > emulated devices. See thread [1] for the related discussion. > > > > [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html > > I don't think including a link like this is really a good way to > summarize what's going on. The rationale for the change, at least at a > very basic level, should be included in the git tree itself. We can't > be confident that link will be around for as long as someone might want > to know why this decision was made. > Ok, I'll send v2 with a summary inline. Paul > -George
On 24/03/17 10:49, Paul Durrant wrote: >> -----Original Message----- >> From: George Dunlap [mailto:george.dunlap@citrix.com] >> Sent: 24 March 2017 10:49 >> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org >> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunlap >> <George.Dunlap@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Jan >> Beulich <jbeulich@suse.com>; Konrad Rzeszutek Wilk >> <konrad.wilk@oracle.com>; Stefano Stabellini <sstabellini@kernel.org>; Tim >> (Xen.org) <tim@xen.org>; Wei Liu <wei.liu2@citrix.com> >> Subject: Re: [PATCH] docs: update HVM emulated unplug protocol to cover >> NVMe disks >> >> On 24/03/17 10:15, Paul Durrant wrote: >>> This patch defines a new bit in the mask used to instruct QEMU to unplug >>> emulated devices. See thread [1] for the related discussion. >>> >>> [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html >> >> I don't think including a link like this is really a good way to >> summarize what's going on. The rationale for the change, at least at a >> very basic level, should be included in the git tree itself. We can't >> be confident that link will be around for as long as someone might want >> to know why this decision was made. >> > > Ok, I'll send v2 with a summary inline. Thanks! -George
diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 8ead0c5..f6b27ed 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -32,12 +32,13 @@ drivers): blacklisted and should not load. 6. The drivers write a two-byte bitmask of devices to unplug to IO - port `0x10`. The defined fields are: + port `0x10`. The defined bits are: - * `1` -- All emulated disks (not including CD drives) - * `2` -- All emulated NICs - * `4` -- All IDE disks except for the primary master (not including CD - drives) + * `0` -- All emulated IDE and SCSI disks (not including CD drives). + * `1` -- All emulated NICs. + * `2` -- All IDE disks except for the primary master (not including CD + drives). This is overridden by bit 0. + * `3` -- All emulated NVMe disks. The relevant emulated devices then disappear from the relevant buses. For most guest operating systems, you want to do this
This patch defines a new bit in the mask used to instruct QEMU to unplug emulated devices. See thread [1] for the related discussion. [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- Cc: Andrew Cooper <andrew.cooper3@citrix.com> Cc: George Dunlap <George.Dunlap@eu.citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Jan Beulich <jbeulich@suse.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Tim Deegan <tim@xen.org> Cc: Wei Liu <wei.liu2@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)