diff mbox

[v10,3/6] drm/edid: detect SCDC support in HF-VSDB

Message ID 1489404244-16608-4-git-send-email-shashank.sharma@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sharma, Shashank March 13, 2017, 11:24 a.m. UTC 
This patch does following:
- Adds a new structure (drm_hdmi_info) in drm_display_info.
  This structure will be used to save and indicate if sink
  supports advanced HDMI 2.0 features
- Adds another structure drm_scdc within drm_hdmi_info, to
  reflect scdc support and capabilities in connected HDMI 2.0 sink.
- Checks the HF-VSDB block for presence of SCDC, and marks it
  in scdc structure
- If SCDC is present, checks if sink is capable of generating
  SCDC read request, and marks it in scdc structure.

V2: Addressed review comments
 Thierry:
 - Fix typos in commit message and make abbreviation consistent
   across the commit message.
 - Change structure object name from hdmi_info -> hdmi
 - Fix typos and abbreviations in description of structure drm_hdmi_info
   end the description with a full stop.
 - Create a structure drm_scdc, and keep all information related to SCDC
   register set (supported, read request supported) etc in it.

Ville:
 - Change rr -> read_request
 - Call drm_detect_scrambling function drm_parse_hf_vsdb so that all
   of HF-VSDB parsing can be kept in same function, in incremental
   patches.

V3: Rebase.
V4: Rebase.
V5: Rebase.
V6: Rebase.
V7: Added R-B from Jose.
V8: Rebase.
V9: Rebase.
V10: Rebase.

Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Jose Abreu <joabreu@synopsys.com>
---
 drivers/gpu/drm/drm_edid.c  | 14 ++++++++++++++
 include/drm/drm_connector.h | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)

Comments

Daniel Vetter March 24, 2017, 7:08 p.m. UTC | #1 
On Mon, Mar 13, 2017 at 12:24 PM, Shashank Sharma
<shashank.sharma@intel.com> wrote:
> +/**
> + * struct drm_hdmi_info - runtime information about the connected HDMI sink
> + *
> + * Describes if a given display supports advanced HDMI 2.0 features.
> + * This information is available in CEA-861-F extension blocks (like HF-VSDB).
> + */
> +struct drm_hdmi_info {
> +       struct drm_scdc scdc;

This creates a new warning when building docs. Please fix.
-Daniel
Sharma, Shashank March 25, 2017, 9:23 a.m. UTC | #2 
Added description for the variable in this patch:
https://patchwork.freedesktop.org/patch/146424/ 

Regards
Shashank
-----Original Message-----
From: daniel.vetter@ffwll.ch [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter

Sent: Friday, March 24, 2017 9:08 PM
To: Sharma, Shashank <shashank.sharma@intel.com>
Cc: Syrjala, Ville <ville.syrjala@linux.intel.com>; Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>; Vetter, Daniel <daniel.vetter@intel.com>; intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v10 3/6] drm/edid: detect SCDC support in HF-VSDB

On Mon, Mar 13, 2017 at 12:24 PM, Shashank Sharma <shashank.sharma@intel.com> wrote:
> +/**

> + * struct drm_hdmi_info - runtime information about the connected 

> +HDMI sink

> + *

> + * Describes if a given display supports advanced HDMI 2.0 features.

> + * This information is available in CEA-861-F extension blocks (like HF-VSDB).

> + */

> +struct drm_hdmi_info {

> +       struct drm_scdc scdc;


This creates a new warning when building docs. Please fix.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Sharma, Shashank March 25, 2017, 9:35 a.m. UTC | #3 
Please use updated version of the patch [V4]:
https://patchwork.freedesktop.org/patch/146426/ 
(previous one had a merge conflict due to my local patch)

Regards
Shashank
-----Original Message-----
From: Sharma, Shashank 

Sent: Saturday, March 25, 2017 11:23 AM
To: 'Daniel Vetter' <daniel@ffwll.ch>
Cc: Syrjala, Ville <ville.syrjala@linux.intel.com>; Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>; Vetter, Daniel <daniel.vetter@intel.com>; intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri-devel@lists.freedesktop.org>
Subject: RE: [Intel-gfx] [PATCH v10 3/6] drm/edid: detect SCDC support in HF-VSDB

Added description for the variable in this patch:
https://patchwork.freedesktop.org/patch/146424/ 

Regards
Shashank
-----Original Message-----
From: daniel.vetter@ffwll.ch [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter

Sent: Friday, March 24, 2017 9:08 PM
To: Sharma, Shashank <shashank.sharma@intel.com>
Cc: Syrjala, Ville <ville.syrjala@linux.intel.com>; Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>; Vetter, Daniel <daniel.vetter@intel.com>; intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v10 3/6] drm/edid: detect SCDC support in HF-VSDB

On Mon, Mar 13, 2017 at 12:24 PM, Shashank Sharma <shashank.sharma@intel.com> wrote:
> +/**

> + * struct drm_hdmi_info - runtime information about the connected 

> +HDMI sink

> + *

> + * Describes if a given display supports advanced HDMI 2.0 features.

> + * This information is available in CEA-861-F extension blocks (like HF-VSDB).

> + */

> +struct drm_hdmi_info {

> +       struct drm_scdc scdc;


This creates a new warning when building docs. Please fix.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 3e0aafa..d64b7bd 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3817,6 +3817,18 @@  enum hdmi_quantization_range
 }
 EXPORT_SYMBOL(drm_default_rgb_quant_range);
 
+static void drm_parse_hdmi_forum_vsdb(struct drm_connector *connector,
+				 const u8 *hf_vsdb)
+{
+	struct drm_hdmi_info *hdmi = &connector->display_info.hdmi;
+
+	if (hf_vsdb[6] & 0x80) {
+		hdmi->scdc.supported = true;
+		if (hf_vsdb[6] & 0x40)
+			hdmi->scdc.read_request = true;
+	}
+}
+
 static void drm_parse_hdmi_deep_color_info(struct drm_connector *connector,
 					   const u8 *hdmi)
 {
@@ -3931,6 +3943,8 @@  static void drm_parse_cea_ext(struct drm_connector *connector,
 
 		if (cea_db_is_hdmi_vsdb(db))
 			drm_parse_hdmi_vsdb_video(connector, db);
+		if (cea_db_is_hdmi_forum_vsdb(db))
+			drm_parse_hdmi_forum_vsdb(connector, db);
 	}
 }
 
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index fabb35a..bf9d6f5 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -87,6 +87,34 @@  enum subpixel_order {
 	SubPixelVerticalRGB,
 	SubPixelVerticalBGR,
 	SubPixelNone,
+
+};
+
+/*
+ * struct drm_scdc - Information about scdc capabilities of a HDMI 2.0 sink
+ *
+ * Provides SCDC register support and capabilities related information on a
+ * HDMI 2.0 sink. In case of a HDMI 1.4 sink, all parameter must be 0.
+ */
+struct drm_scdc {
+	/**
+	 * @supported: status control & data channel present.
+	 */
+	bool supported;
+	/**
+	 * @read_request: sink is capable of generating scdc read request.
+	 */
+	bool read_request;
+};
+
+/**
+ * struct drm_hdmi_info - runtime information about the connected HDMI sink
+ *
+ * Describes if a given display supports advanced HDMI 2.0 features.
+ * This information is available in CEA-861-F extension blocks (like HF-VSDB).
+ */
+struct drm_hdmi_info {
+	struct drm_scdc scdc;
 };
 
 /**
@@ -204,6 +232,11 @@  struct drm_display_info {
 	 * @cea_rev: CEA revision of the HDMI sink.
 	 */
 	u8 cea_rev;
+
+	/**
+	 * @hdmi: advance features of a HDMI sink.
+	 */
+	struct drm_hdmi_info hdmi;
 };
 
 int drm_display_info_set_bus_formats(struct drm_display_info *info,