| Message ID | 20170314164653.15771-5-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, 14 Mar 2017, Krzysztof Kozlowski wrote: > The MFD-specific header will go away because it duplicates defines from > exynos-regs-pmu.h. > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/mfd/exynos-lpass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c > index 2e064fb8826f..8bebad92a385 100644 > --- a/drivers/mfd/exynos-lpass.c > +++ b/drivers/mfd/exynos-lpass.c > @@ -18,11 +18,11 @@ > #include <linux/io.h> > #include <linux/module.h> > #include <linux/mfd/syscon.h> > -#include <linux/mfd/syscon/exynos5-pmu.h> > #include <linux/of.h> > #include <linux/of_platform.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > +#include <linux/soc/samsung/exynos-regs-pmu.h> > #include <linux/types.h> > > /* LPASS Top register definitions */ > @@ -83,7 +83,7 @@ static void exynos_lpass_enable(struct exynos_lpass *lpass) > > /* Activate related PADs from retention state */ > regmap_write(lpass->pmu, EXYNOS5433_PAD_RETENTION_AUD_OPTION, > - EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR); > + EXYNOS_WAKEUP_FROM_LOWPWR); > > exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET); > exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET);
On Wed, Mar 15, 2017 at 12:10 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 14 Mar 2017, Krzysztof Kozlowski wrote: > >> The MFD-specific header will go away because it duplicates defines from >> exynos-regs-pmu.h. >> >> Reported-by: kbuild test robot <fengguang.wu@intel.com> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >> --- >> drivers/mfd/exynos-lpass.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied, thanks. Hi, This is also needed for patch 5/5 in the set so I was wondering if this can be put on separate branch and then shared if phy maintainers would need it? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 15 Mar 2017, Krzysztof Kozlowski wrote: > On Wed, Mar 15, 2017 at 12:10 PM, Lee Jones <lee.jones@linaro.org> wrote: > > On Tue, 14 Mar 2017, Krzysztof Kozlowski wrote: > > > >> The MFD-specific header will go away because it duplicates defines from > >> exynos-regs-pmu.h. > >> > >> Reported-by: kbuild test robot <fengguang.wu@intel.com> > >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > >> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > >> --- > >> drivers/mfd/exynos-lpass.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Applied, thanks. > > Hi, > > This is also needed for patch 5/5 in the set so I was wondering if > this can be put on separate branch and then shared if phy maintainers > would need it? What is the dependency?
On Wed, Mar 15, 2017 at 2:12 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Wed, 15 Mar 2017, Krzysztof Kozlowski wrote: > >> On Wed, Mar 15, 2017 at 12:10 PM, Lee Jones <lee.jones@linaro.org> wrote: >> > On Tue, 14 Mar 2017, Krzysztof Kozlowski wrote: >> > >> >> The MFD-specific header will go away because it duplicates defines from >> >> exynos-regs-pmu.h. >> >> >> >> Reported-by: kbuild test robot <fengguang.wu@intel.com> >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> >> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >> >> --- >> >> drivers/mfd/exynos-lpass.c | 4 ++-- >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > Applied, thanks. >> >> Hi, >> >> This is also needed for patch 5/5 in the set so I was wondering if >> this can be put on separate branch and then shared if phy maintainers >> would need it? > > What is the dependency? This patch removes the last usage of define from header we want to remove (linux/mfd/syscon/exynos5-pmu.h). The next patch (5/5) removes the header as there are no more users. BTW, I hope you got all the mails from this patchset including cover letter. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 23, 2017 at 12:51 PM, Lee Jones <lee.jones@linaro.org> wrote: > Enjoy! > > The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-phy-v4.12 > > for you to fetch changes up to f7f6c060547c51691f9b943e6c33f63675c1a0a9: > > mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header (2017-03-23 10:47:27 +0000) > > ---------------------------------------------------------------- > Immutable branch between MFD and PHY due for the v4.12 merge window > > ---------------------------------------------------------------- > Krzysztof Kozlowski (1): > mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header > > drivers/mfd/exynos-lpass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks. Kishon, This is the dependency for last patch in v4 of: https://www.spinics.net/lists/arm-kernel/msg568609.html Everything else is acked and ready for you to apply. Any comments? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 23 March 2017 04:21 PM, Lee Jones wrote: > Enjoy! > > The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-phy-v4.12 merged this to linux-phy. Thanks Kishon > > for you to fetch changes up to f7f6c060547c51691f9b943e6c33f63675c1a0a9: > > mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header (2017-03-23 10:47:27 +0000) > > ---------------------------------------------------------------- > Immutable branch between MFD and PHY due for the v4.12 merge window > > ---------------------------------------------------------------- > Krzysztof Kozlowski (1): > mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header > > drivers/mfd/exynos-lpass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index 2e064fb8826f..8bebad92a385 100644 --- a/drivers/mfd/exynos-lpass.c +++ b/drivers/mfd/exynos-lpass.c @@ -18,11 +18,11 @@ #include <linux/io.h> #include <linux/module.h> #include <linux/mfd/syscon.h> -#include <linux/mfd/syscon/exynos5-pmu.h> #include <linux/of.h> #include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/soc/samsung/exynos-regs-pmu.h> #include <linux/types.h> /* LPASS Top register definitions */ @@ -83,7 +83,7 @@ static void exynos_lpass_enable(struct exynos_lpass *lpass) /* Activate related PADs from retention state */ regmap_write(lpass->pmu, EXYNOS5433_PAD_RETENTION_AUD_OPTION, - EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR); + EXYNOS_WAKEUP_FROM_LOWPWR); exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET); exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET);