diff mbox

[v3,16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

Message ID 20170403091444.29876-17-clabbe.montjoie@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Corentin Labbe April 3, 2017, 9:14 a.m. UTC
The dwmac-sun8i hardware is present on the pine64
It uses an external PHY via RMII.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Maxime Ripard April 3, 2017, 11:38 a.m. UTC | #1
On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the pine64
> It uses an external PHY via RMII.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Looks fine, but please use "arm64: allwinner: pine64: " as your title
prefix. It applies to all your other patches (and the arm ones should
be "arm: <family>: <soc-or-board>:".

Thanks!
Maxime
Corentin Labbe April 7, 2017, 12:48 p.m. UTC | #2
On Mon, Apr 03, 2017 at 01:38:47PM +0200, Maxime Ripard wrote:
> On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> > The dwmac-sun8i hardware is present on the pine64
> > It uses an external PHY via RMII.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> 
> Looks fine, but please use "arm64: allwinner: pine64: " as your title
> prefix. It applies to all your other patches (and the arm ones should
> be "arm: <family>: <soc-or-board>:".
> 

Will fix them

Thanks
Corentin Labbe
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index c680ed3..6aee3d5 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -109,3 +109,19 @@ 
 &usbphy {
 	status = "okay";
 };
+
+&mdio {
+	ext_rmii_phy1: ethernet-phy@1 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <1>;
+	};
+};
+
+&emac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&rmii_pins>;
+	phy-mode = "rmii";
+	phy-handle = <&ext_rmii_phy1>;
+	status = "okay";
+
+};