diff mbox

[-next,v2] ARM: hisi: fix error return code in hip04_smp_init()

Message ID 20170205163255.28589-1-weiyj.lk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun Feb. 5, 2017, 4:32 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return error code -ENODEV from the of_find_compatible_node()
error handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: fix file module
---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Wei Xu April 10, 2017, 3:23 p.m. UTC | #1 
Hi Yongjun,

On 2017/2/5 16:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thanks!
Applied to the hisilicon soc tree.

Best Regards,
Wei

> ---
> v1 -> v2: fix file module
> ---
>  arch/arm/mach-hisi/platmcpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
>  					 &hip04_boot_method[0], 4);
>  	if (ret)
>  		goto err;
> +
> +	ret = -ENODEV;
>  	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
>  	if (!np_sctl)
>  		goto err;
> 
> 
>
diff mbox

Patch

diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
index a6c1176..f0fff21 100644
--- a/arch/arm/mach-hisi/platmcpm.c
+++ b/arch/arm/mach-hisi/platmcpm.c
@@ -279,6 +279,8 @@  static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;