Message ID | 1490617217-30192-9-git-send-email-nicolas.dichtel@6wind.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, Mar 27, 2017 at 02:20:13PM +0200, Nicolas Dichtel wrote: > This patch prepares the uapi export by fixing the following error: > > .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) > char cru_name[CRYPTO_MAX_ALG_NAME]; > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Can we revert this patch please? I had forgotten about it when increasing the in-kernel CRYPTO_MAX_ALG_NAME so it now conflicts with the crypto tree. The crypto tree has fixed the problem in a different way. Thanks,
diff --git a/include/linux/crypto.h b/include/linux/crypto.h index c0b0cf3d2d2f..cc2425ba8527 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -24,6 +24,7 @@ #include <linux/slab.h> #include <linux/string.h> #include <linux/uaccess.h> +#include <uapi/linux/crypto.h> /* * Autoloaded crypto modules should only use a prefixed name to avoid allowing @@ -123,7 +124,6 @@ /* * Miscellaneous stuff. */ -#define CRYPTO_MAX_ALG_NAME 64 /* * The macro CRYPTO_MINALIGN_ATTR (along with the void * type in the actual diff --git a/include/uapi/linux/crypto.h b/include/uapi/linux/crypto.h new file mode 100644 index 000000000000..e342c5a5ac50 --- /dev/null +++ b/include/uapi/linux/crypto.h @@ -0,0 +1,14 @@ +/* + * Copyright (c) 2017 Nicolas Dichtel <nicolas.dichtel@6wind.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + */ + +#ifndef _UAPI_CRYPTO_H +#define _UAPI_CRYPTO_H + +#define CRYPTO_MAX_ALG_NAME 64 + +#endif /* _UAPI_CRYPTO_H */ diff --git a/include/uapi/linux/cryptouser.h b/include/uapi/linux/cryptouser.h index c6a09c5261e7..751e7daef54a 100644 --- a/include/uapi/linux/cryptouser.h +++ b/include/uapi/linux/cryptouser.h @@ -18,6 +18,10 @@ * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. */ +#ifndef _UAPI_CRYPTOUSER_H +#define _UAPI_CRYPTOUSER_H + +#include <linux/crypto.h> #include <linux/types.h> /* Netlink configuration messages. */ @@ -121,3 +125,5 @@ struct crypto_report_acomp { #define CRYPTO_REPORT_MAXSIZE (sizeof(struct crypto_user_alg) + \ sizeof(struct crypto_report_blkcipher)) + +#endif /* _UAPI_CRYPTOUSER_H */