diff mbox

[3/3] drm/panel: add backlight dependency for sitronix-st7789v

Message ID 20170419180326.303994-1-arnd@arndb.de (mailing list archive)
State New, archived
Headers show

Commit Message

Arnd Bergmann April 19, 2017, 6:03 p.m. UTC
Without the dependency, we run into a link error:

drivers/gpu/drm/panel/panel-sitronix-st7789v.o: In function `st7789v_probe':
panel-sitronix-st7789v.c:(.text.st7789v_probe+0xc0): undefined reference to `of_find_backlight_by_node'

Fixes: 7142afb3a186 ("drm/panel: Add driver for sitronix ST7789V LCD controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Hoegeun Kwon April 20, 2017, 1:37 a.m. UTC | #1
On 04/20/2017 03:03 AM, Arnd Bergmann wrote:
> Without the dependency, we run into a link error:
>
> drivers/gpu/drm/panel/panel-sitronix-st7789v.o: In function `st7789v_probe':
> panel-sitronix-st7789v.c:(.text.st7789v_probe+0xc0): undefined reference to `of_find_backlight_by_node'
>
> Fixes: 7142afb3a186 ("drm/panel: Add driver for sitronix ST7789V LCD controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>

Best regards,
Hoegeun

> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 6eb9774284df..04d068177e16 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -101,6 +101,7 @@ config DRM_PANEL_SHARP_LS043T1LE01
>   config DRM_PANEL_SITRONIX_ST7789V
>   	tristate "Sitronix ST7789V panel"
>   	depends on OF && SPI
> +	depends on BACKLIGHT_CLASS_DEVICE
>   	help
>   	  Say Y here if you want to enable support for the Sitronix
>   	  ST7789V controller for 240x320 LCD panels
Thierry Reding June 14, 2017, 6:13 p.m. UTC | #2
On Wed, Apr 19, 2017 at 08:03:08PM +0200, Arnd Bergmann wrote:
> Without the dependency, we run into a link error:
> 
> drivers/gpu/drm/panel/panel-sitronix-st7789v.o: In function `st7789v_probe':
> panel-sitronix-st7789v.c:(.text.st7789v_probe+0xc0): undefined reference to `of_find_backlight_by_node'
> 
> Fixes: 7142afb3a186 ("drm/panel: Add driver for sitronix ST7789V LCD controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to drm-misc-next, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 6eb9774284df..04d068177e16 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -101,6 +101,7 @@  config DRM_PANEL_SHARP_LS043T1LE01
 config DRM_PANEL_SITRONIX_ST7789V
 	tristate "Sitronix ST7789V panel"
 	depends on OF && SPI
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here if you want to enable support for the Sitronix
 	  ST7789V controller for 240x320 LCD panels