diff mbox

[3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

Message ID 9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

SF Markus Elfring April 25, 2017, 8:30 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 25 Apr 2017 22:00:05 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement here.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

subhashj@codeaurora.org April 26, 2017, 5:59 p.m. UTC | #1 
On 2017-04-25 13:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 25 Apr 2017 22:00:05 +0200
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: void function return statements are not generally useful
> 
> Thus remove such a statement here.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/scsi/ufs/ufshcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5216e33e61a3..9018f26a5667 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4966,7 +4966,6 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
> 
>  out:
>  	pm_runtime_put_sync(hba->dev);
> -	return;
>  }
> 
>  /* Complete requests that have door-bell cleared */

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
diff mbox

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5216e33e61a3..9018f26a5667 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4966,7 +4966,6 @@  static void ufshcd_exception_event_handler(struct work_struct *work)
 
 out:
 	pm_runtime_put_sync(hba->dev);
-	return;
 }
 
 /* Complete requests that have door-bell cleared */