| Message ID | 149332526341.32431.11307248841385136294.stgit@zeus.hardeman.nu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Thu, 27 Apr 2017 22:34:23 +0200 David Härdeman <david@hardeman.nu> escreveu: > It is currently impossible to distinguish between scancodes which have > been generated using different protocols (and scancodes can, and will, > overlap). > > For example: > RC5 message to address 0x00, command 0x03 has scancode 0x00000503 > JVC message to address 0x00, command 0x03 has scancode 0x00000503 > > It is only possible to distinguish (and parse) scancodes by known the > scancode *and* the protocol. > > Setting and getting keycodes in the input subsystem used to be done via > the EVIOC[GS]KEYCODE ioctl and "unsigned int[2]" (one int for scancode > and one for the keycode). > > The interface has now been extended to use the EVIOC[GS]KEYCODE_V2 ioctl > which uses the following struct: > > struct input_keymap_entry { > __u8 flags; > __u8 len; > __u16 index; > __u32 keycode; > __u8 scancode[32]; > }; > > (scancode can of course be even bigger, thanks to the len member). > > This patch changes how the "input_keymap_entry" struct is interpreted > by rc-core by casting it to "rc_keymap_entry": > > struct rc_scancode { > __u16 protocol; > __u16 reserved[3]; > __u64 scancode; > } > > struct rc_keymap_entry { > __u8 flags; > __u8 len; > __u16 index; > __u32 keycode; > union { > struct rc_scancode rc; > __u8 raw[32]; > }; > }; > > The u64 scancode member is large enough for all current protocols and it > would be possible to extend it in the future should it be necessary for > some exotic protocol. > > The main advantage with this change is that the protocol is made explicit, > which means that we're not throwing away data (the protocol type). > > This also means that struct rc_map no longer hardcodes the protocol, meaning > that keytables with mixed entries are possible. > > Heuristics are also added to hopefully do the right thing with older > ioctls in order to preserve backwards compatibility. > > Note that the heuristics are not 100% guaranteed to get things right. > That is unavoidable since the protocol information simply isn't there > when userspace calls the previous ioctl() types. > > However, that is somewhat mitigated by the fact that the "only" > userspace binary which might need to change is ir-keytable. Userspace > programs which simply consume input events (i.e. the vast majority) > won't have to change. Nack. No userspace breakages are allowed. There's no way to warrant that ir-keytable version is compatible with a certain Kernel version. Thanks, Mauro
On Thu, Apr 27, 2017 at 10:34:23PM +0200, David Härdeman wrote: > It is currently impossible to distinguish between scancodes which have > been generated using different protocols (and scancodes can, and will, > overlap). > > For example: > RC5 message to address 0x00, command 0x03 has scancode 0x00000503 > JVC message to address 0x00, command 0x03 has scancode 0x00000503 > > It is only possible to distinguish (and parse) scancodes by known the > scancode *and* the protocol. > > Setting and getting keycodes in the input subsystem used to be done via > the EVIOC[GS]KEYCODE ioctl and "unsigned int[2]" (one int for scancode > and one for the keycode). > > The interface has now been extended to use the EVIOC[GS]KEYCODE_V2 ioctl > which uses the following struct: > > struct input_keymap_entry { > __u8 flags; > __u8 len; > __u16 index; > __u32 keycode; > __u8 scancode[32]; > }; > > (scancode can of course be even bigger, thanks to the len member). > > This patch changes how the "input_keymap_entry" struct is interpreted > by rc-core by casting it to "rc_keymap_entry": > > struct rc_scancode { > __u16 protocol; > __u16 reserved[3]; > __u64 scancode; > } > > struct rc_keymap_entry { > __u8 flags; > __u8 len; > __u16 index; > __u32 keycode; > union { > struct rc_scancode rc; > __u8 raw[32]; > }; > }; > > The u64 scancode member is large enough for all current protocols and it > would be possible to extend it in the future should it be necessary for > some exotic protocol. > > The main advantage with this change is that the protocol is made explicit, > which means that we're not throwing away data (the protocol type). > > This also means that struct rc_map no longer hardcodes the protocol, meaning > that keytables with mixed entries are possible. > > Heuristics are also added to hopefully do the right thing with older > ioctls in order to preserve backwards compatibility. The current ioctls do not provide any protocol information, so they should continue to match any protocol. Those heuristics aren't good enough. Another way of doing is to have a bitmask of protocols, and default to RC_BIT_ALL for current ioctls. > Note that the heuristics are not 100% guaranteed to get things right. > That is unavoidable since the protocol information simply isn't there > when userspace calls the previous ioctl() types. > > However, that is somewhat mitigated by the fact that the "only" > userspace binary which might need to change is ir-keytable. Userspace > programs which simply consume input events (i.e. the vast majority) > won't have to change. For this to be accepted we would need ir-keytable changes too so it can be tested. > > Signed-off-by: David Härdeman <david@hardeman.nu> > --- > drivers/media/rc/ati_remote.c | 1 > drivers/media/rc/imon.c | 7 +- > drivers/media/rc/rc-main.c | 188 +++++++++++++++++++++++++++++------------ > include/media/rc-core.h | 26 +++++- > include/media/rc-map.h | 5 + > 5 files changed, 165 insertions(+), 62 deletions(-) > > diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c > index 9cf3e69de16a..cc81b938471f 100644 > --- a/drivers/media/rc/ati_remote.c > +++ b/drivers/media/rc/ati_remote.c > @@ -546,6 +546,7 @@ static void ati_remote_input_report(struct urb *urb) > * set, assume this is a scrollwheel up/down event. > */ > wheel_keycode = rc_g_keycode_from_table(ati_remote->rdev, > + RC_TYPE_OTHER, > scancode & 0x78); > > if (wheel_keycode == KEY_RESERVED) { > diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c > index 3489010601b5..c724a1a5e9cd 100644 > --- a/drivers/media/rc/imon.c > +++ b/drivers/media/rc/imon.c > @@ -1274,14 +1274,15 @@ static u32 imon_remote_key_lookup(struct imon_context *ictx, u32 scancode) > bool is_release_code = false; > > /* Look for the initial press of a button */ > - keycode = rc_g_keycode_from_table(ictx->rdev, scancode); > + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, scancode); > ictx->rc_toggle = 0x0; > ictx->rc_scancode = scancode; > > /* Look for the release of a button */ > if (keycode == KEY_RESERVED) { > release = scancode & ~0x4000; > - keycode = rc_g_keycode_from_table(ictx->rdev, release); > + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, > + release); > if (keycode != KEY_RESERVED) > is_release_code = true; > } > @@ -1310,7 +1311,7 @@ static u32 imon_mce_key_lookup(struct imon_context *ictx, u32 scancode) > scancode = scancode | MCE_KEY_MASK | MCE_TOGGLE_BIT; > > ictx->rc_scancode = scancode; > - keycode = rc_g_keycode_from_table(ictx->rdev, scancode); > + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, scancode); > > /* not used in mce mode, but make sure we know its false */ > ictx->release_code = false; > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index 881af208a19a..ad5545301588 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -105,7 +105,7 @@ EXPORT_SYMBOL_GPL(rc_map_unregister); > > > static struct rc_map_table empty[] = { > - { 0x2a, KEY_COFFEE }, > + { RC_TYPE_OTHER, 0x2a, KEY_COFFEE }, > }; > > static struct rc_map_list empty_map = { > @@ -121,7 +121,6 @@ static struct rc_map_list empty_map = { > * ir_create_table() - initializes a scancode table > * @rc_map: the rc_map to initialize > * @name: name to assign to the table > - * @rc_type: ir type to assign to the new table > * @size: initial size of the table > * @return: zero on success or a negative error code > * > @@ -129,12 +128,11 @@ static struct rc_map_list empty_map = { > * memory to hold at least the specified number of elements. > */ > static int ir_create_table(struct rc_map *rc_map, > - const char *name, u64 rc_type, size_t size) > + const char *name, size_t size) > { > rc_map->name = kstrdup(name, GFP_KERNEL); > if (!rc_map->name) > return -ENOMEM; > - rc_map->rc_type = rc_type; > rc_map->alloc = roundup_pow_of_two(size * sizeof(struct rc_map_table)); > rc_map->size = rc_map->alloc / sizeof(struct rc_map_table); > rc_map->scan = kmalloc(rc_map->alloc, GFP_KERNEL); > @@ -234,16 +232,20 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, > > /* Did the user wish to remove the mapping? */ > if (new_keycode == KEY_RESERVED || new_keycode == KEY_UNKNOWN) { > - IR_dprintk(1, "#%d: Deleting scan 0x%04x\n", > - index, rc_map->scan[index].scancode); > + IR_dprintk(1, "#%d: Deleting proto 0x%04x, scan 0x%08llx\n", > + index, rc_map->scan[index].protocol, > + (unsigned long long)rc_map->scan[index].scancode); > rc_map->len--; > memmove(&rc_map->scan[index], &rc_map->scan[index+ 1], > (rc_map->len - index) * sizeof(struct rc_map_table)); > } else { > - IR_dprintk(1, "#%d: %s scan 0x%04x with key 0x%04x\n", > + IR_dprintk(1, "#%d: %s proto 0x%04x, scan 0x%08llx " > + "with key 0x%04x\n", > index, > old_keycode == KEY_RESERVED ? "New" : "Replacing", > - rc_map->scan[index].scancode, new_keycode); > + rc_map->scan[index].protocol, > + (unsigned long long)rc_map->scan[index].scancode, > + new_keycode); > rc_map->scan[index].keycode = new_keycode; > __set_bit(new_keycode, dev->input_dev->keybit); > } > @@ -270,9 +272,9 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, > * ir_establish_scancode() - set a keycode in the scancode->keycode table > * @dev: the struct rc_dev device descriptor > * @rc_map: scancode table to be searched > - * @scancode: the desired scancode > - * @resize: controls whether we allowed to resize the table to > - * accommodate not yet present scancodes > + * @entry: the entry to be added to the table > + * @resize: controls whether we are allowed to resize the table to > + * accomodate not yet present scancodes > * @return: index of the mapping containing scancode in question > * or -1U in case of failure. > * > @@ -282,7 +284,7 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, > */ > static unsigned int ir_establish_scancode(struct rc_dev *dev, > struct rc_map *rc_map, > - unsigned int scancode, > + struct rc_map_table *entry, > bool resize) > { > unsigned int i; > @@ -296,16 +298,27 @@ static unsigned int ir_establish_scancode(struct rc_dev *dev, > * indicate the valid bits of the scancodes. > */ > if (dev->scancode_mask) > - scancode &= dev->scancode_mask; > + entry->scancode &= dev->scancode_mask; > > - /* First check if we already have a mapping for this ir command */ > + /* > + * First check if we already have a mapping for this command. > + * Note that the keytable is sorted first on protocol and second > + * on scancode (lowest to highest). > + */ > for (i = 0; i < rc_map->len; i++) { > - if (rc_map->scan[i].scancode == scancode) > - return i; > + if (rc_map->scan[i].protocol < entry->protocol) > + continue; > + > + if (rc_map->scan[i].protocol > entry->protocol) > + break; > > - /* Keytable is sorted from lowest to highest scancode */ > - if (rc_map->scan[i].scancode >= scancode) > + if (rc_map->scan[i].scancode < entry->scancode) > + continue; > + > + if (rc_map->scan[i].scancode > entry->scancode) > break; > + > + return i; > } > > /* No previous mapping found, we might need to grow the table */ > @@ -318,7 +331,8 @@ static unsigned int ir_establish_scancode(struct rc_dev *dev, > if (i < rc_map->len) > memmove(&rc_map->scan[i + 1], &rc_map->scan[i], > (rc_map->len - i) * sizeof(struct rc_map_table)); > - rc_map->scan[i].scancode = scancode; > + rc_map->scan[i].scancode = entry->scancode; > + rc_map->scan[i].protocol = entry->protocol; > rc_map->scan[i].keycode = KEY_RESERVED; > rc_map->len++; > > @@ -340,8 +354,10 @@ static inline enum rc_type guess_protocol(struct rc_dev *rdev) > return rc_bitmap_to_type(rdev->enabled_protocols); > else if (hweight64(rdev->allowed_protocols) == 1) > return rc_bitmap_to_type(rdev->allowed_protocols); > + else if (rc_map->len > 0) > + return rc_map->scan[0].protocol; > else > - return rc_map->rc_type; > + return RC_TYPE_OTHER; > } > > /** > @@ -384,10 +400,12 @@ static int ir_setkeycode(struct input_dev *idev, > struct rc_dev *rdev = input_get_drvdata(idev); > struct rc_map *rc_map = &rdev->rc_map; > unsigned int index; > - unsigned int scancode; > + struct rc_map_table entry; > int retval = 0; > unsigned long flags; > > + entry.keycode = ke->keycode; > + > spin_lock_irqsave(&rc_map->lock, flags); > > if (ke->flags & INPUT_KEYMAP_BY_INDEX) { > @@ -396,19 +414,42 @@ static int ir_setkeycode(struct input_dev *idev, > retval = -EINVAL; > goto out; > } > - } else { > + } else if (ke->len == sizeof(int)) { > + /* Old EVIOCSKEYCODE[_V2] ioctl */ > + u32 scancode; > retval = input_scancode_to_scalar(ke, &scancode); > if (retval) > goto out; > > - if (guess_protocol(rdev) == RC_TYPE_NEC) > - scancode = to_nec32(scancode); > + entry.scancode = scancode; > + entry.protocol = guess_protocol(rdev); > + if (entry.protocol == RC_TYPE_NEC) > + entry.scancode = to_nec32(scancode); > > - index = ir_establish_scancode(rdev, rc_map, scancode, true); > + index = ir_establish_scancode(rdev, rc_map, &entry, true); > if (index >= rc_map->len) { > retval = -ENOMEM; > goto out; > } > + } else if (ke->len == sizeof(struct rc_scancode)) { > + /* New EVIOCSKEYCODE_V2 ioctl */ > + const struct rc_keymap_entry *rke = (struct rc_keymap_entry *)ke; > + entry.protocol = rke->rc.protocol; > + entry.scancode = rke->rc.scancode; > + > + if (rke->rc.reserved[0] || rke->rc.reserved[1] || rke->rc.reserved[2]) { > + retval = -EINVAL; > + goto out; > + } > + > + index = ir_establish_scancode(rdev, rc_map, &entry, true); > + if (index >= rc_map->len) { > + retval = -ENOMEM; > + goto out; > + } > + } else { > + retval = -EINVAL; > + goto out; > } > > *old_keycode = ir_update_mapping(rdev, rc_map, index, ke->keycode); > @@ -431,11 +472,11 @@ static int ir_setkeytable(struct rc_dev *dev, > const struct rc_map *from) > { > struct rc_map *rc_map = &dev->rc_map; > + struct rc_map_table entry; > unsigned int i, index; > int rc; > > - rc = ir_create_table(rc_map, from->name, > - from->rc_type, from->size); > + rc = ir_create_table(rc_map, from->name, from->size); > if (rc) > return rc; > > @@ -443,18 +484,19 @@ static int ir_setkeytable(struct rc_dev *dev, > rc_map->size, rc_map->alloc); > > for (i = 0; i < from->size; i++) { > - index = ir_establish_scancode(dev, rc_map, > - from->rc_type == RC_TYPE_NEC ? > - to_nec32(from->scan[i].scancode) : > - from->scan[i].scancode, > - false); > + if (from->rc_type == RC_TYPE_NEC) > + entry.scancode = to_nec32(from->scan[i].scancode); > + else > + entry.scancode = from->scan[i].scancode; > + > + entry.protocol = from->rc_type; > + index = ir_establish_scancode(dev, rc_map, &entry, false); > if (index >= rc_map->len) { > rc = -ENOMEM; > break; > } > > - ir_update_mapping(dev, rc_map, index, > - from->scan[i].keycode); > + ir_update_mapping(dev, rc_map, index, from->scan[i].keycode); > } > > if (rc) > @@ -466,6 +508,7 @@ static int ir_setkeytable(struct rc_dev *dev, > /** > * ir_lookup_by_scancode() - locate mapping by scancode > * @rc_map: the struct rc_map to search > + * @protocol: protocol to look for in the table > * @scancode: scancode to look for in the table > * @return: index in the table, -1U if not found > * > @@ -473,17 +516,24 @@ static int ir_setkeytable(struct rc_dev *dev, > * given scancode. > */ > static unsigned int ir_lookup_by_scancode(const struct rc_map *rc_map, > - unsigned int scancode) > + u16 protocol, u64 scancode) > { > int start = 0; > int end = rc_map->len - 1; > int mid; > + struct rc_map_table *m; > > while (start <= end) { > mid = (start + end) / 2; > - if (rc_map->scan[mid].scancode < scancode) > + m = &rc_map->scan[mid]; > + > + if (m->protocol < protocol) > + start = mid + 1; > + else if (m->protocol > protocol) > + end = mid - 1; > + else if (m->scancode < scancode) > start = mid + 1; > - else if (rc_map->scan[mid].scancode > scancode) > + else if (m->scancode > scancode) > end = mid - 1; > else > return mid; > @@ -504,35 +554,60 @@ static unsigned int ir_lookup_by_scancode(const struct rc_map *rc_map, > static int ir_getkeycode(struct input_dev *idev, > struct input_keymap_entry *ke) > { > + struct rc_keymap_entry *rke = (struct rc_keymap_entry *)ke; > struct rc_dev *rdev = input_get_drvdata(idev); > struct rc_map *rc_map = &rdev->rc_map; > struct rc_map_table *entry; > unsigned long flags; > unsigned int index; > - unsigned int scancode; > int retval; > > spin_lock_irqsave(&rc_map->lock, flags); > > if (ke->flags & INPUT_KEYMAP_BY_INDEX) { > index = ke->index; > - } else { > + } else if (ke->len == sizeof(int)) { > + /* Legacy EVIOCGKEYCODE ioctl */ > + u32 scancode; > + u16 protocol; > + > retval = input_scancode_to_scalar(ke, &scancode); > if (retval) > goto out; > > - if (guess_protocol(rdev) == RC_TYPE_NEC) > + protocol = guess_protocol(rdev); > + if (protocol == RC_TYPE_NEC) > scancode = to_nec32(scancode); > - index = ir_lookup_by_scancode(rc_map, scancode); > + > + index = ir_lookup_by_scancode(rc_map, protocol, scancode); > + > + } else if (ke->len == sizeof(struct rc_scancode)) { > + /* New EVIOCGKEYCODE_V2 ioctl */ > + if (rke->rc.reserved[0] || rke->rc.reserved[1] || rke->rc.reserved[2]) { > + retval = -EINVAL; > + goto out; > + } > + > + index = ir_lookup_by_scancode(rc_map, > + rke->rc.protocol, rke->rc.scancode); > + > + } else { > + retval = -EINVAL; > + goto out; > } > > if (index < rc_map->len) { > entry = &rc_map->scan[index]; > - > ke->index = index; > ke->keycode = entry->keycode; > - ke->len = sizeof(entry->scancode); > - memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode)); > + if (ke->len == sizeof(int)) { > + u32 scancode = entry->scancode; > + memcpy(ke->scancode, &scancode, sizeof(scancode)); > + } else { > + ke->len = sizeof(struct rc_scancode); > + rke->rc.protocol = entry->protocol; > + rke->rc.scancode = entry->scancode; > + } > > } else if (!(ke->flags & INPUT_KEYMAP_BY_INDEX)) { > /* > @@ -557,6 +632,7 @@ static int ir_getkeycode(struct input_dev *idev, > /** > * rc_g_keycode_from_table() - gets the keycode that corresponds to a scancode > * @dev: the struct rc_dev descriptor of the device > + * @protocol: the protocol to look for > * @scancode: the scancode to look for > * @return: the corresponding keycode, or KEY_RESERVED > * > @@ -564,7 +640,8 @@ static int ir_getkeycode(struct input_dev *idev, > * keycode. Normally it should not be used since drivers should have no > * interest in keycodes. > */ > -u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode) > +u32 rc_g_keycode_from_table(struct rc_dev *dev, > + enum rc_type protocol, u64 scancode) > { > struct rc_map *rc_map = &dev->rc_map; > unsigned int keycode; > @@ -573,15 +650,16 @@ u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode) > > spin_lock_irqsave(&rc_map->lock, flags); > > - index = ir_lookup_by_scancode(rc_map, scancode); > + index = ir_lookup_by_scancode(rc_map, protocol, scancode); > keycode = index < rc_map->len ? > rc_map->scan[index].keycode : KEY_RESERVED; > > spin_unlock_irqrestore(&rc_map->lock, flags); > > if (keycode != KEY_RESERVED) > - IR_dprintk(1, "%s: scancode 0x%04x keycode 0x%02x\n", > - dev->input_name, scancode, keycode); > + IR_dprintk(1, "%s: protocol 0x%04x scancode 0x%08llx keycode 0x%02x\n", > + dev->input_name, protocol, > + (unsigned long long)scancode, keycode); > > return keycode; > } > @@ -733,10 +811,11 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_type protocol, > * This routine is used to signal that a key has been pressed on the > * remote control. > */ > -void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle) > +void rc_keydown(struct rc_dev *dev, enum rc_type protocol, > + u64 scancode, u8 toggle) > { > unsigned long flags; > - u32 keycode = rc_g_keycode_from_table(dev, scancode); > + u32 keycode = rc_g_keycode_from_table(dev, protocol, scancode); > > spin_lock_irqsave(&dev->keylock, flags); > ir_do_keydown(dev, protocol, scancode, keycode, toggle); > @@ -762,10 +841,10 @@ EXPORT_SYMBOL_GPL(rc_keydown); > * remote control. The driver must manually call rc_keyup() at a later stage. > */ > void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, > - u32 scancode, u8 toggle) > + u64 scancode, u8 toggle) > { > unsigned long flags; > - u32 keycode = rc_g_keycode_from_table(dev, scancode); > + u32 keycode = rc_g_keycode_from_table(dev, protocol, scancode); > > spin_lock_irqsave(&dev->keylock, flags); > ir_do_keydown(dev, protocol, scancode, keycode, toggle); > @@ -1675,7 +1754,10 @@ static int rc_prepare_rx_device(struct rc_dev *dev) > if (rc) > return rc; > > - rc_type = BIT_ULL(rc_map->rc_type); > + if (rc_map->len > 0) > + rc_type = BIT_ULL(rc_map->scan[0].protocol); > + else > + rc_type = RC_TYPE_UNKNOWN; > > if (dev->change_protocol) { > rc = dev->change_protocol(dev, &rc_type); > diff --git a/include/media/rc-core.h b/include/media/rc-core.h > index 78dea39a9b39..ad0ed23a9194 100644 > --- a/include/media/rc-core.h > +++ b/include/media/rc-core.h > @@ -44,6 +44,24 @@ enum rc_driver_type { > RC_DRIVER_IR_RAW_TX, > }; > > +/* This is used for the input EVIOC[SG]KEYCODE_V2 ioctls */ > +struct rc_scancode { > + __u16 protocol; > + __u16 reserved[3]; > + __u64 scancode; > +}; > + > +struct rc_keymap_entry { > + __u8 flags; > + __u8 len; > + __u16 index; > + __u32 keycode; > + union { > + struct rc_scancode rc; > + __u8 raw[32]; > + }; > +}; > + > /** > * struct rc_scancode_filter - Filter scan codes. > * @data: Scancode data to match. > @@ -166,7 +184,7 @@ struct rc_dev { > struct timer_list timer_keyup; > u32 last_keycode; > enum rc_type last_protocol; > - u32 last_scancode; > + u64 last_scancode; > u8 last_toggle; > u32 timeout; > u32 min_timeout; > @@ -262,10 +280,10 @@ int rc_open(struct rc_dev *rdev); > void rc_close(struct rc_dev *rdev); > > void rc_repeat(struct rc_dev *dev); > -void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle); > -void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle); > +void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u64 scancode, u8 toggle); > +void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, u64 scancode, u8 toggle); > void rc_keyup(struct rc_dev *dev); > -u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode); > +u32 rc_g_keycode_from_table(struct rc_dev *dev, enum rc_type protocol, u64 scancode); > > /* > * From rc-raw.c > diff --git a/include/media/rc-map.h b/include/media/rc-map.h > index e5d0559dc523..02f53ed25493 100644 > --- a/include/media/rc-map.h > +++ b/include/media/rc-map.h > @@ -139,8 +139,9 @@ enum rc_type { > * @keycode: Linux input keycode > */ > struct rc_map_table { > - u32 scancode; > - u32 keycode; > + u64 scancode; > + u32 keycode; > + enum rc_type protocol; > }; > > /**
On Fri, Apr 28, 2017 at 12:40:53PM +0100, Sean Young wrote: >On Thu, Apr 27, 2017 at 10:34:23PM +0200, David Härdeman wrote: ... >> This patch changes how the "input_keymap_entry" struct is interpreted >> by rc-core by casting it to "rc_keymap_entry": >> >> struct rc_scancode { >> __u16 protocol; >> __u16 reserved[3]; >> __u64 scancode; >> } >> >> struct rc_keymap_entry { >> __u8 flags; >> __u8 len; >> __u16 index; >> __u32 keycode; >> union { >> struct rc_scancode rc; >> __u8 raw[32]; >> }; >> }; >> >> The u64 scancode member is large enough for all current protocols and it >> would be possible to extend it in the future should it be necessary for >> some exotic protocol. >> >> The main advantage with this change is that the protocol is made explicit, >> which means that we're not throwing away data (the protocol type). >> >> This also means that struct rc_map no longer hardcodes the protocol, meaning >> that keytables with mixed entries are possible. >> >> Heuristics are also added to hopefully do the right thing with older >> ioctls in order to preserve backwards compatibility. > >The current ioctls do not provide any protocol information, so they should >continue to match any protocol. Those heuristics aren't good enough. > >Another way of doing is to have a bitmask of protocols, and default to >RC_BIT_ALL for current ioctls. I've been mulling that approach as well, but slightly different. My alternative approach is based on repurposing RC_TYPE_UNKNOWN as a kind of catch-all which will match any scancode. I'll post a patch showing the alternative approach straight away. >> Note that the heuristics are not 100% guaranteed to get things right. >> That is unavoidable since the protocol information simply isn't there >> when userspace calls the previous ioctl() types. >> >> However, that is somewhat mitigated by the fact that the "only" >> userspace binary which might need to change is ir-keytable. Userspace >> programs which simply consume input events (i.e. the vast majority) >> won't have to change. > >For this to be accepted we would need ir-keytable changes too so it can >be tested. I know. But I'll postpone those patches until we have more of a consensus on the right approach to take.
On Fri, Apr 28, 2017 at 08:31:33AM -0300, Mauro Carvalho Chehab wrote: >Em Thu, 27 Apr 2017 22:34:23 +0200 >David Härdeman <david@hardeman.nu> escreveu: ... >> This patch changes how the "input_keymap_entry" struct is interpreted >> by rc-core by casting it to "rc_keymap_entry": >> >> struct rc_scancode { >> __u16 protocol; >> __u16 reserved[3]; >> __u64 scancode; >> } >> >> struct rc_keymap_entry { >> __u8 flags; >> __u8 len; >> __u16 index; >> __u32 keycode; >> union { >> struct rc_scancode rc; >> __u8 raw[32]; >> }; >> }; >> ... > >Nack. That's not a very constructive approach. If you have a better approach in mind I'm all ears. Because you're surely not suggesting that we stay with the current protocol-less approach forever? >No userspace breakages are allowed. That's a gross oversimplification. A cursory glance at the linux-api mailing list shows plenty of examples of changes that might not be 100% backwards-compatible. Here's an example: http://marc.info/?l=linux-fsdevel&m=149089166918069 That's the kind of discussion we need to have - i.e. the best way to go about this and to minimize the damage to userspace. In that vein, I'll post an alternative approach shortly as the basis for further discussion. >There's no way to warrant that >ir-keytable version is compatible with a certain Kernel version. I know. But we know when an ioctl() is made whether it is a protocol-aware one or not.
On Fri, Apr 28, 2017 at 06:59:11PM +0200, David Härdeman wrote: > On Fri, Apr 28, 2017 at 08:31:33AM -0300, Mauro Carvalho Chehab wrote: > >Em Thu, 27 Apr 2017 22:34:23 +0200 > >David Härdeman <david@hardeman.nu> escreveu: > ... > >> This patch changes how the "input_keymap_entry" struct is interpreted > >> by rc-core by casting it to "rc_keymap_entry": > >> > >> struct rc_scancode { > >> __u16 protocol; > >> __u16 reserved[3]; > >> __u64 scancode; > >> } > >> > >> struct rc_keymap_entry { > >> __u8 flags; > >> __u8 len; > >> __u16 index; > >> __u32 keycode; > >> union { > >> struct rc_scancode rc; > >> __u8 raw[32]; > >> }; > >> }; > >> > ... > > > >Nack. > > That's not a very constructive approach. If you have a better approach > in mind I'm all ears. Because you're surely not suggesting that we stay > with the current protocol-less approach forever? Well, what problem are we trying to solve actually? Looking at the keymaps we have already, there are many scancodes which overlap and only a few of them use a different protocol. So having this feature will not suddenly make it possible to load all our keymaps, it will just make it possible to simultaneously load a few more. > >No userspace breakages are allowed. > > That's a gross oversimplification. This can be implemented without breaking userspace. Sean
On Fri, Apr 28, 2017 at 08:42:13PM +0100, Sean Young wrote: >On Fri, Apr 28, 2017 at 06:59:11PM +0200, David Härdeman wrote: >> On Fri, Apr 28, 2017 at 08:31:33AM -0300, Mauro Carvalho Chehab wrote: >> >Em Thu, 27 Apr 2017 22:34:23 +0200 >> >David Härdeman <david@hardeman.nu> escreveu: >> ... >> >> This patch changes how the "input_keymap_entry" struct is interpreted >> >> by rc-core by casting it to "rc_keymap_entry": >> >> >> ... >> > >> >Nack. >> >> That's not a very constructive approach. If you have a better approach >> in mind I'm all ears. Because you're surely not suggesting that we stay >> with the current protocol-less approach forever? > >Well, what problem are we trying to solve actually? I'm not sure what the confusion is? Last time around we discussed this there seemed to be general agreement that protocol information is useful? >Looking at the keymaps we have already, there are many scancodes which >overlap and only a few of them use a different protocol. So having this >feature will not suddenly make it possible to load all our keymaps, it >will just make it possible to simultaneously load a few more. That's not really the point, overlaps in scancode && protocol cannot be distinguished. But overlaps in scancode can be. I have remotes which overlap in scancode even though they have different protocols. >> >> That's a gross oversimplification. > >This can be implemented without breaking userspace. How?
On Sat, Apr 29, 2017 at 10:44:58AM +0200, David Härdeman wrote: > >This can be implemented without breaking userspace. > > How? The current keymaps we have do not specify the protocol variant, only the protocol (rc6 vs rc6-mce). So to support this, we have to be able to specify multiple protocols at the same time. So I think the protocol should be a bitmask. Also, in your example you re-used RC_TYPE_OTHER to match any protocol; I don't think that is a good solution since there are already keymaps which use other. So if we have an "struct rc_scancode" which looks like: struct rc_scancode { u64 protocol; u64 scancode; }; Then if the keymap protocol is rc6, ir-keytable should set the protocol to RC_BIT_RC6_0 | RC_BIT_RC6_6A_20 | RC_BIT_RC6_6A_24 | RC_BIT_RC6_6A_32 | RC_BIT_RC6_MCE. If the old ioctl is used, then the protocol should be set to RC_BIT_ALL. I can't think of anything what would break with this scheme. Thanks Sean
On Sun, Jun 11, 2017 at 05:17:40PM +0100, Sean Young wrote: >On Sat, Apr 29, 2017 at 10:44:58AM +0200, David Härdeman wrote: >> >This can be implemented without breaking userspace. >> >> How? > >The current keymaps we have do not specify the protocol variant, only >the protocol (rc6 vs rc6-mce). So to support this, we have to be able >to specify multiple protocols at the same time. So I think the protocol >should be a bitmask. > >Also, in your example you re-used RC_TYPE_OTHER to match any protocol; >I don't think that is a good solution since there are already keymaps >which use other. > >So if we have an "struct rc_scancode" which looks like: > >struct rc_scancode { > u64 protocol; > u64 scancode; >}; > >Then if the keymap protocol is rc6, ir-keytable should set the protocol >to RC_BIT_RC6_0 | RC_BIT_RC6_6A_20 | RC_BIT_RC6_6A_24 | RC_BIT_RC6_6A_32 > | RC_BIT_RC6_MCE. > >If the old ioctl is used, then the protocol should be set to RC_BIT_ALL. > >I can't think of anything what would break with this scheme. I've tried coding up that solution before and the problem is that it'll still require heuristics in the presence of a mix of old and new style ioctl():s. For example: old_ioctl_set(0x1234 = KEY_A); new_ioctl_set(PROTOCOL_NEC, 0x1234 = KEY_B); new_ioctl_set(PROTOCOL_JVC, 0x1234 = KEY_C); old_ioctl_get(0x1234) = ? old_ioctl_set(0x1234 = KEY_D); new_ioctl_get(PROTOCOL_NEC, 0x1234) = ?
diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c index 9cf3e69de16a..cc81b938471f 100644 --- a/drivers/media/rc/ati_remote.c +++ b/drivers/media/rc/ati_remote.c @@ -546,6 +546,7 @@ static void ati_remote_input_report(struct urb *urb) * set, assume this is a scrollwheel up/down event. */ wheel_keycode = rc_g_keycode_from_table(ati_remote->rdev, + RC_TYPE_OTHER, scancode & 0x78); if (wheel_keycode == KEY_RESERVED) { diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index 3489010601b5..c724a1a5e9cd 100644 --- a/drivers/media/rc/imon.c +++ b/drivers/media/rc/imon.c @@ -1274,14 +1274,15 @@ static u32 imon_remote_key_lookup(struct imon_context *ictx, u32 scancode) bool is_release_code = false; /* Look for the initial press of a button */ - keycode = rc_g_keycode_from_table(ictx->rdev, scancode); + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, scancode); ictx->rc_toggle = 0x0; ictx->rc_scancode = scancode; /* Look for the release of a button */ if (keycode == KEY_RESERVED) { release = scancode & ~0x4000; - keycode = rc_g_keycode_from_table(ictx->rdev, release); + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, + release); if (keycode != KEY_RESERVED) is_release_code = true; } @@ -1310,7 +1311,7 @@ static u32 imon_mce_key_lookup(struct imon_context *ictx, u32 scancode) scancode = scancode | MCE_KEY_MASK | MCE_TOGGLE_BIT; ictx->rc_scancode = scancode; - keycode = rc_g_keycode_from_table(ictx->rdev, scancode); + keycode = rc_g_keycode_from_table(ictx->rdev, ictx->rc_type, scancode); /* not used in mce mode, but make sure we know its false */ ictx->release_code = false; diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 881af208a19a..ad5545301588 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -105,7 +105,7 @@ EXPORT_SYMBOL_GPL(rc_map_unregister); static struct rc_map_table empty[] = { - { 0x2a, KEY_COFFEE }, + { RC_TYPE_OTHER, 0x2a, KEY_COFFEE }, }; static struct rc_map_list empty_map = { @@ -121,7 +121,6 @@ static struct rc_map_list empty_map = { * ir_create_table() - initializes a scancode table * @rc_map: the rc_map to initialize * @name: name to assign to the table - * @rc_type: ir type to assign to the new table * @size: initial size of the table * @return: zero on success or a negative error code * @@ -129,12 +128,11 @@ static struct rc_map_list empty_map = { * memory to hold at least the specified number of elements. */ static int ir_create_table(struct rc_map *rc_map, - const char *name, u64 rc_type, size_t size) + const char *name, size_t size) { rc_map->name = kstrdup(name, GFP_KERNEL); if (!rc_map->name) return -ENOMEM; - rc_map->rc_type = rc_type; rc_map->alloc = roundup_pow_of_two(size * sizeof(struct rc_map_table)); rc_map->size = rc_map->alloc / sizeof(struct rc_map_table); rc_map->scan = kmalloc(rc_map->alloc, GFP_KERNEL); @@ -234,16 +232,20 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, /* Did the user wish to remove the mapping? */ if (new_keycode == KEY_RESERVED || new_keycode == KEY_UNKNOWN) { - IR_dprintk(1, "#%d: Deleting scan 0x%04x\n", - index, rc_map->scan[index].scancode); + IR_dprintk(1, "#%d: Deleting proto 0x%04x, scan 0x%08llx\n", + index, rc_map->scan[index].protocol, + (unsigned long long)rc_map->scan[index].scancode); rc_map->len--; memmove(&rc_map->scan[index], &rc_map->scan[index+ 1], (rc_map->len - index) * sizeof(struct rc_map_table)); } else { - IR_dprintk(1, "#%d: %s scan 0x%04x with key 0x%04x\n", + IR_dprintk(1, "#%d: %s proto 0x%04x, scan 0x%08llx " + "with key 0x%04x\n", index, old_keycode == KEY_RESERVED ? "New" : "Replacing", - rc_map->scan[index].scancode, new_keycode); + rc_map->scan[index].protocol, + (unsigned long long)rc_map->scan[index].scancode, + new_keycode); rc_map->scan[index].keycode = new_keycode; __set_bit(new_keycode, dev->input_dev->keybit); } @@ -270,9 +272,9 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, * ir_establish_scancode() - set a keycode in the scancode->keycode table * @dev: the struct rc_dev device descriptor * @rc_map: scancode table to be searched - * @scancode: the desired scancode - * @resize: controls whether we allowed to resize the table to - * accommodate not yet present scancodes + * @entry: the entry to be added to the table + * @resize: controls whether we are allowed to resize the table to + * accomodate not yet present scancodes * @return: index of the mapping containing scancode in question * or -1U in case of failure. * @@ -282,7 +284,7 @@ static unsigned int ir_update_mapping(struct rc_dev *dev, */ static unsigned int ir_establish_scancode(struct rc_dev *dev, struct rc_map *rc_map, - unsigned int scancode, + struct rc_map_table *entry, bool resize) { unsigned int i; @@ -296,16 +298,27 @@ static unsigned int ir_establish_scancode(struct rc_dev *dev, * indicate the valid bits of the scancodes. */ if (dev->scancode_mask) - scancode &= dev->scancode_mask; + entry->scancode &= dev->scancode_mask; - /* First check if we already have a mapping for this ir command */ + /* + * First check if we already have a mapping for this command. + * Note that the keytable is sorted first on protocol and second + * on scancode (lowest to highest). + */ for (i = 0; i < rc_map->len; i++) { - if (rc_map->scan[i].scancode == scancode) - return i; + if (rc_map->scan[i].protocol < entry->protocol) + continue; + + if (rc_map->scan[i].protocol > entry->protocol) + break; - /* Keytable is sorted from lowest to highest scancode */ - if (rc_map->scan[i].scancode >= scancode) + if (rc_map->scan[i].scancode < entry->scancode) + continue; + + if (rc_map->scan[i].scancode > entry->scancode) break; + + return i; } /* No previous mapping found, we might need to grow the table */ @@ -318,7 +331,8 @@ static unsigned int ir_establish_scancode(struct rc_dev *dev, if (i < rc_map->len) memmove(&rc_map->scan[i + 1], &rc_map->scan[i], (rc_map->len - i) * sizeof(struct rc_map_table)); - rc_map->scan[i].scancode = scancode; + rc_map->scan[i].scancode = entry->scancode; + rc_map->scan[i].protocol = entry->protocol; rc_map->scan[i].keycode = KEY_RESERVED; rc_map->len++; @@ -340,8 +354,10 @@ static inline enum rc_type guess_protocol(struct rc_dev *rdev) return rc_bitmap_to_type(rdev->enabled_protocols); else if (hweight64(rdev->allowed_protocols) == 1) return rc_bitmap_to_type(rdev->allowed_protocols); + else if (rc_map->len > 0) + return rc_map->scan[0].protocol; else - return rc_map->rc_type; + return RC_TYPE_OTHER; } /** @@ -384,10 +400,12 @@ static int ir_setkeycode(struct input_dev *idev, struct rc_dev *rdev = input_get_drvdata(idev); struct rc_map *rc_map = &rdev->rc_map; unsigned int index; - unsigned int scancode; + struct rc_map_table entry; int retval = 0; unsigned long flags; + entry.keycode = ke->keycode; + spin_lock_irqsave(&rc_map->lock, flags); if (ke->flags & INPUT_KEYMAP_BY_INDEX) { @@ -396,19 +414,42 @@ static int ir_setkeycode(struct input_dev *idev, retval = -EINVAL; goto out; } - } else { + } else if (ke->len == sizeof(int)) { + /* Old EVIOCSKEYCODE[_V2] ioctl */ + u32 scancode; retval = input_scancode_to_scalar(ke, &scancode); if (retval) goto out; - if (guess_protocol(rdev) == RC_TYPE_NEC) - scancode = to_nec32(scancode); + entry.scancode = scancode; + entry.protocol = guess_protocol(rdev); + if (entry.protocol == RC_TYPE_NEC) + entry.scancode = to_nec32(scancode); - index = ir_establish_scancode(rdev, rc_map, scancode, true); + index = ir_establish_scancode(rdev, rc_map, &entry, true); if (index >= rc_map->len) { retval = -ENOMEM; goto out; } + } else if (ke->len == sizeof(struct rc_scancode)) { + /* New EVIOCSKEYCODE_V2 ioctl */ + const struct rc_keymap_entry *rke = (struct rc_keymap_entry *)ke; + entry.protocol = rke->rc.protocol; + entry.scancode = rke->rc.scancode; + + if (rke->rc.reserved[0] || rke->rc.reserved[1] || rke->rc.reserved[2]) { + retval = -EINVAL; + goto out; + } + + index = ir_establish_scancode(rdev, rc_map, &entry, true); + if (index >= rc_map->len) { + retval = -ENOMEM; + goto out; + } + } else { + retval = -EINVAL; + goto out; } *old_keycode = ir_update_mapping(rdev, rc_map, index, ke->keycode); @@ -431,11 +472,11 @@ static int ir_setkeytable(struct rc_dev *dev, const struct rc_map *from) { struct rc_map *rc_map = &dev->rc_map; + struct rc_map_table entry; unsigned int i, index; int rc; - rc = ir_create_table(rc_map, from->name, - from->rc_type, from->size); + rc = ir_create_table(rc_map, from->name, from->size); if (rc) return rc; @@ -443,18 +484,19 @@ static int ir_setkeytable(struct rc_dev *dev, rc_map->size, rc_map->alloc); for (i = 0; i < from->size; i++) { - index = ir_establish_scancode(dev, rc_map, - from->rc_type == RC_TYPE_NEC ? - to_nec32(from->scan[i].scancode) : - from->scan[i].scancode, - false); + if (from->rc_type == RC_TYPE_NEC) + entry.scancode = to_nec32(from->scan[i].scancode); + else + entry.scancode = from->scan[i].scancode; + + entry.protocol = from->rc_type; + index = ir_establish_scancode(dev, rc_map, &entry, false); if (index >= rc_map->len) { rc = -ENOMEM; break; } - ir_update_mapping(dev, rc_map, index, - from->scan[i].keycode); + ir_update_mapping(dev, rc_map, index, from->scan[i].keycode); } if (rc) @@ -466,6 +508,7 @@ static int ir_setkeytable(struct rc_dev *dev, /** * ir_lookup_by_scancode() - locate mapping by scancode * @rc_map: the struct rc_map to search + * @protocol: protocol to look for in the table * @scancode: scancode to look for in the table * @return: index in the table, -1U if not found * @@ -473,17 +516,24 @@ static int ir_setkeytable(struct rc_dev *dev, * given scancode. */ static unsigned int ir_lookup_by_scancode(const struct rc_map *rc_map, - unsigned int scancode) + u16 protocol, u64 scancode) { int start = 0; int end = rc_map->len - 1; int mid; + struct rc_map_table *m; while (start <= end) { mid = (start + end) / 2; - if (rc_map->scan[mid].scancode < scancode) + m = &rc_map->scan[mid]; + + if (m->protocol < protocol) + start = mid + 1; + else if (m->protocol > protocol) + end = mid - 1; + else if (m->scancode < scancode) start = mid + 1; - else if (rc_map->scan[mid].scancode > scancode) + else if (m->scancode > scancode) end = mid - 1; else return mid; @@ -504,35 +554,60 @@ static unsigned int ir_lookup_by_scancode(const struct rc_map *rc_map, static int ir_getkeycode(struct input_dev *idev, struct input_keymap_entry *ke) { + struct rc_keymap_entry *rke = (struct rc_keymap_entry *)ke; struct rc_dev *rdev = input_get_drvdata(idev); struct rc_map *rc_map = &rdev->rc_map; struct rc_map_table *entry; unsigned long flags; unsigned int index; - unsigned int scancode; int retval; spin_lock_irqsave(&rc_map->lock, flags); if (ke->flags & INPUT_KEYMAP_BY_INDEX) { index = ke->index; - } else { + } else if (ke->len == sizeof(int)) { + /* Legacy EVIOCGKEYCODE ioctl */ + u32 scancode; + u16 protocol; + retval = input_scancode_to_scalar(ke, &scancode); if (retval) goto out; - if (guess_protocol(rdev) == RC_TYPE_NEC) + protocol = guess_protocol(rdev); + if (protocol == RC_TYPE_NEC) scancode = to_nec32(scancode); - index = ir_lookup_by_scancode(rc_map, scancode); + + index = ir_lookup_by_scancode(rc_map, protocol, scancode); + + } else if (ke->len == sizeof(struct rc_scancode)) { + /* New EVIOCGKEYCODE_V2 ioctl */ + if (rke->rc.reserved[0] || rke->rc.reserved[1] || rke->rc.reserved[2]) { + retval = -EINVAL; + goto out; + } + + index = ir_lookup_by_scancode(rc_map, + rke->rc.protocol, rke->rc.scancode); + + } else { + retval = -EINVAL; + goto out; } if (index < rc_map->len) { entry = &rc_map->scan[index]; - ke->index = index; ke->keycode = entry->keycode; - ke->len = sizeof(entry->scancode); - memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode)); + if (ke->len == sizeof(int)) { + u32 scancode = entry->scancode; + memcpy(ke->scancode, &scancode, sizeof(scancode)); + } else { + ke->len = sizeof(struct rc_scancode); + rke->rc.protocol = entry->protocol; + rke->rc.scancode = entry->scancode; + } } else if (!(ke->flags & INPUT_KEYMAP_BY_INDEX)) { /* @@ -557,6 +632,7 @@ static int ir_getkeycode(struct input_dev *idev, /** * rc_g_keycode_from_table() - gets the keycode that corresponds to a scancode * @dev: the struct rc_dev descriptor of the device + * @protocol: the protocol to look for * @scancode: the scancode to look for * @return: the corresponding keycode, or KEY_RESERVED * @@ -564,7 +640,8 @@ static int ir_getkeycode(struct input_dev *idev, * keycode. Normally it should not be used since drivers should have no * interest in keycodes. */ -u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode) +u32 rc_g_keycode_from_table(struct rc_dev *dev, + enum rc_type protocol, u64 scancode) { struct rc_map *rc_map = &dev->rc_map; unsigned int keycode; @@ -573,15 +650,16 @@ u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode) spin_lock_irqsave(&rc_map->lock, flags); - index = ir_lookup_by_scancode(rc_map, scancode); + index = ir_lookup_by_scancode(rc_map, protocol, scancode); keycode = index < rc_map->len ? rc_map->scan[index].keycode : KEY_RESERVED; spin_unlock_irqrestore(&rc_map->lock, flags); if (keycode != KEY_RESERVED) - IR_dprintk(1, "%s: scancode 0x%04x keycode 0x%02x\n", - dev->input_name, scancode, keycode); + IR_dprintk(1, "%s: protocol 0x%04x scancode 0x%08llx keycode 0x%02x\n", + dev->input_name, protocol, + (unsigned long long)scancode, keycode); return keycode; } @@ -733,10 +811,11 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_type protocol, * This routine is used to signal that a key has been pressed on the * remote control. */ -void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle) +void rc_keydown(struct rc_dev *dev, enum rc_type protocol, + u64 scancode, u8 toggle) { unsigned long flags; - u32 keycode = rc_g_keycode_from_table(dev, scancode); + u32 keycode = rc_g_keycode_from_table(dev, protocol, scancode); spin_lock_irqsave(&dev->keylock, flags); ir_do_keydown(dev, protocol, scancode, keycode, toggle); @@ -762,10 +841,10 @@ EXPORT_SYMBOL_GPL(rc_keydown); * remote control. The driver must manually call rc_keyup() at a later stage. */ void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, - u32 scancode, u8 toggle) + u64 scancode, u8 toggle) { unsigned long flags; - u32 keycode = rc_g_keycode_from_table(dev, scancode); + u32 keycode = rc_g_keycode_from_table(dev, protocol, scancode); spin_lock_irqsave(&dev->keylock, flags); ir_do_keydown(dev, protocol, scancode, keycode, toggle); @@ -1675,7 +1754,10 @@ static int rc_prepare_rx_device(struct rc_dev *dev) if (rc) return rc; - rc_type = BIT_ULL(rc_map->rc_type); + if (rc_map->len > 0) + rc_type = BIT_ULL(rc_map->scan[0].protocol); + else + rc_type = RC_TYPE_UNKNOWN; if (dev->change_protocol) { rc = dev->change_protocol(dev, &rc_type); diff --git a/include/media/rc-core.h b/include/media/rc-core.h index 78dea39a9b39..ad0ed23a9194 100644 --- a/include/media/rc-core.h +++ b/include/media/rc-core.h @@ -44,6 +44,24 @@ enum rc_driver_type { RC_DRIVER_IR_RAW_TX, }; +/* This is used for the input EVIOC[SG]KEYCODE_V2 ioctls */ +struct rc_scancode { + __u16 protocol; + __u16 reserved[3]; + __u64 scancode; +}; + +struct rc_keymap_entry { + __u8 flags; + __u8 len; + __u16 index; + __u32 keycode; + union { + struct rc_scancode rc; + __u8 raw[32]; + }; +}; + /** * struct rc_scancode_filter - Filter scan codes. * @data: Scancode data to match. @@ -166,7 +184,7 @@ struct rc_dev { struct timer_list timer_keyup; u32 last_keycode; enum rc_type last_protocol; - u32 last_scancode; + u64 last_scancode; u8 last_toggle; u32 timeout; u32 min_timeout; @@ -262,10 +280,10 @@ int rc_open(struct rc_dev *rdev); void rc_close(struct rc_dev *rdev); void rc_repeat(struct rc_dev *dev); -void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle); -void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, u32 scancode, u8 toggle); +void rc_keydown(struct rc_dev *dev, enum rc_type protocol, u64 scancode, u8 toggle); +void rc_keydown_notimeout(struct rc_dev *dev, enum rc_type protocol, u64 scancode, u8 toggle); void rc_keyup(struct rc_dev *dev); -u32 rc_g_keycode_from_table(struct rc_dev *dev, u32 scancode); +u32 rc_g_keycode_from_table(struct rc_dev *dev, enum rc_type protocol, u64 scancode); /* * From rc-raw.c diff --git a/include/media/rc-map.h b/include/media/rc-map.h index e5d0559dc523..02f53ed25493 100644 --- a/include/media/rc-map.h +++ b/include/media/rc-map.h @@ -139,8 +139,9 @@ enum rc_type { * @keycode: Linux input keycode */ struct rc_map_table { - u32 scancode; - u32 keycode; + u64 scancode; + u32 keycode; + enum rc_type protocol; }; /**
It is currently impossible to distinguish between scancodes which have been generated using different protocols (and scancodes can, and will, overlap). For example: RC5 message to address 0x00, command 0x03 has scancode 0x00000503 JVC message to address 0x00, command 0x03 has scancode 0x00000503 It is only possible to distinguish (and parse) scancodes by known the scancode *and* the protocol. Setting and getting keycodes in the input subsystem used to be done via the EVIOC[GS]KEYCODE ioctl and "unsigned int[2]" (one int for scancode and one for the keycode). The interface has now been extended to use the EVIOC[GS]KEYCODE_V2 ioctl which uses the following struct: struct input_keymap_entry { __u8 flags; __u8 len; __u16 index; __u32 keycode; __u8 scancode[32]; }; (scancode can of course be even bigger, thanks to the len member). This patch changes how the "input_keymap_entry" struct is interpreted by rc-core by casting it to "rc_keymap_entry": struct rc_scancode { __u16 protocol; __u16 reserved[3]; __u64 scancode; } struct rc_keymap_entry { __u8 flags; __u8 len; __u16 index; __u32 keycode; union { struct rc_scancode rc; __u8 raw[32]; }; }; The u64 scancode member is large enough for all current protocols and it would be possible to extend it in the future should it be necessary for some exotic protocol. The main advantage with this change is that the protocol is made explicit, which means that we're not throwing away data (the protocol type). This also means that struct rc_map no longer hardcodes the protocol, meaning that keytables with mixed entries are possible. Heuristics are also added to hopefully do the right thing with older ioctls in order to preserve backwards compatibility. Note that the heuristics are not 100% guaranteed to get things right. That is unavoidable since the protocol information simply isn't there when userspace calls the previous ioctl() types. However, that is somewhat mitigated by the fact that the "only" userspace binary which might need to change is ir-keytable. Userspace programs which simply consume input events (i.e. the vast majority) won't have to change. Signed-off-by: David Härdeman <david@hardeman.nu> --- drivers/media/rc/ati_remote.c | 1 drivers/media/rc/imon.c | 7 +- drivers/media/rc/rc-main.c | 188 +++++++++++++++++++++++++++++------------ include/media/rc-core.h | 26 +++++- include/media/rc-map.h | 5 + 5 files changed, 165 insertions(+), 62 deletions(-)