| Message ID | 20170508021002.12262-1-tommy0705c@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 08, 2017 at 10:10:02AM +0800, Daichou wrote: > These comments were already fixed in 2013. > btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup > btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed. Patch is ok, thanks. (I'll just reformat the changelog.) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a29dc3fd7152..6db06f4708f7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->assign) { ret = btrfs_add_qgroup_relation(trans, fs_info, sa->src, sa->dst); @@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->create) { ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid); } else { @@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg) qgroupid = root->root_key.objectid; } - /* FIXME: check if the IDs really exist */ ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim); err = btrfs_end_transaction(trans);
These comments were already fixed in 2013. btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed. Signed-off-by: Daichou <tommy0705c@gmail.com> --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-)