| Message ID | 1494356693-13190-2-git-send-email-sstabellini@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/09/2017 02:04 PM, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. > > CID: 1374831 > > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org> > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake <eblake@redhat.com> > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On Tue, 9 May 2017 12:04:52 -0700 Stefano Stabellini <sstabellini@kernel.org> wrote: > Assert that the return value is not an error. This issue was found by > Coverity. > > CID: 1374831 > > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org> > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake <eblake@redhat.com> > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Greg Kurz <groug@kaod.org> > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 4d9189e..16894ad 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) > { > int f; > f = fcntl(fd, F_GETFD); > - fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > } > > /*
On 09/05/2017 21:04, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. > > CID: 1374831 > > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org> > CC: groug@kaod.org > CC: pbonzini@redhat.com > CC: Eric Blake <eblake@redhat.com> Queued, thanks. Paolo > --- > util/oslib-posix.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 4d9189e..16894ad 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) > { > int f; > f = fcntl(fd, F_GETFD); > - fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); > + assert(f != -1); > } > > /* >
On Thu, 11 May 2017, Paolo Bonzini wrote: > On 09/05/2017 21:04, Stefano Stabellini wrote: > > Assert that the return value is not an error. This issue was found by > > Coverity. > > > > CID: 1374831 > > > > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org> > > CC: groug@kaod.org > > CC: pbonzini@redhat.com > > CC: Eric Blake <eblake@redhat.com> > > Queued, thanks. I am about to send a pull request with the rest of the series, but I'll leave this one to you. Cheers, Stefano > > --- > > util/oslib-posix.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > > index 4d9189e..16894ad 100644 > > --- a/util/oslib-posix.c > > +++ b/util/oslib-posix.c > > @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) > > { > > int f; > > f = fcntl(fd, F_GETFD); > > - fcntl(fd, F_SETFD, f | FD_CLOEXEC); > > + assert(f != -1); > > + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); > > + assert(f != -1); > > } > > > > /* > > >
diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4d9189e..16894ad 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) { int f; f = fcntl(fd, F_GETFD); - fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f != -1); + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f != -1); } /*
Assert that the return value is not an error. This issue was found by Coverity. CID: 1374831 Signed-off-by: Stefano Stabellini <sstabellini@kernel.org> CC: groug@kaod.org CC: pbonzini@redhat.com CC: Eric Blake <eblake@redhat.com> --- util/oslib-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)