| Message ID | e5482112927d6b31aba43b88f1faba6c9fd96ab3.1494624795.git.tony.luck@intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Friday, May 12, 2017 02:42:12 PM Luck, Tony wrote: > From: Tony Luck <tony.luck@intel.com> > > Version 6.1 of the ACPI specification. Section 18.3.1 "Boot Error > Source" clarified that the format of the Boot Error Region is a "Generic > Error Status Block". So we don't need separate (but identical) "struct > acpi_bert_region" and "struct acpi_hest_generic_status". > > Code using acpi_bert_region has been changed to use acpi_hest_generic_status > instead. So we can delete the definition now. > > Cc: Len Brown <lenb@kernel.org> > Cc: Huang Ying <ying.huang@intel.com> > Cc: Borislav Petkov <bp@suse.de> > Cc: Tomasz Nowicki <tomasz.nowicki@linaro.org> > Cc: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> > Cc: Tyler Baicar <tbaicar@codeaurora.org> > Cc: linux-acpi@vger.kernel.org > Reviewed-by: Borislav Petkov <bp@suse.de> > Signed-off-by: Tony Luck <tony.luck@intel.com> > --- > include/acpi/actbl1.h | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h > index b4ce55c008b0..b44663a87bd1 100644 > --- a/include/acpi/actbl1.h > +++ b/include/acpi/actbl1.h > @@ -126,17 +126,11 @@ struct acpi_whea_header { > struct acpi_table_bert { > struct acpi_table_header header; /* Common ACPI table header */ > u32 region_length; /* Length of the boot error region */ > - u64 address; /* Physical address of the error region */ > -}; > - > -/* Boot Error Region (not a subtable, pointed to by Address field above) */ > - > -struct acpi_bert_region { > - u32 block_status; /* Type of error information */ > - u32 raw_data_offset; /* Offset to raw error data */ > - u32 raw_data_length; /* Length of raw error data */ > - u32 data_length; /* Length of generic error data */ > - u32 error_severity; /* Severity code */ > + u64 address; /* > + * Physical address of the error region > + * which is a Generic Error Status Block > + * (struct acpi_hest_generic_status) > + */ > }; > > /* Values for block_status flags above */ > Well, again, this is an ACPICA header and by changing it in the kernel alone we make it out of sync with the upstream, which may be a problem for the maintainers thereof when they port changes from the upstream ACPICA to the kernel. So, (a) do we have to change it and (b) can that be routed through the upstream? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 12, 2017 at 11:46:31PM +0200, Rafael J. Wysocki wrote: > Well, again, this is an ACPICA header and by changing it in the kernel alone > we make it out of sync with the upstream, which may be a problem for the > maintainers thereof when they port changes from the upstream ACPICA to the > kernel. > > So, (a) do we have to change it and (b) can that be routed through the > upstream? a) No ... we don't have to b) Yes. What is the process / mailing list to make an ACPICA change? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, May 12, 2017 03:32:51 PM Luck, Tony wrote: > On Fri, May 12, 2017 at 11:46:31PM +0200, Rafael J. Wysocki wrote: > > Well, again, this is an ACPICA header and by changing it in the kernel alone > > we make it out of sync with the upstream, which may be a problem for the > > maintainers thereof when they port changes from the upstream ACPICA to the > > kernel. > > > > So, (a) do we have to change it and (b) can that be routed through the > > upstream? > > a) No ... we don't have to OK > b) Yes. What is the process / mailing list to make an ACPICA change? The relevant information is there in MAINTAINERS. The process is to post changes to the devel mailing list, as per MAINTAINERS, but it should be sufficient to CC the ACPICA maintainers, which I did, and talk to them. :-) Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index b4ce55c008b0..b44663a87bd1 100644 --- a/include/acpi/actbl1.h +++ b/include/acpi/actbl1.h @@ -126,17 +126,11 @@ struct acpi_whea_header { struct acpi_table_bert { struct acpi_table_header header; /* Common ACPI table header */ u32 region_length; /* Length of the boot error region */ - u64 address; /* Physical address of the error region */ -}; - -/* Boot Error Region (not a subtable, pointed to by Address field above) */ - -struct acpi_bert_region { - u32 block_status; /* Type of error information */ - u32 raw_data_offset; /* Offset to raw error data */ - u32 raw_data_length; /* Length of raw error data */ - u32 data_length; /* Length of generic error data */ - u32 error_severity; /* Severity code */ + u64 address; /* + * Physical address of the error region + * which is a Generic Error Status Block + * (struct acpi_hest_generic_status) + */ }; /* Values for block_status flags above */