diff mbox

[1/2] ubifs: Fix inode data budget in ubifs_mknod

Message ID 1494979038-19361-1-git-send-email-cheol.lee@lge.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hyeoncheol Lee May 16, 2017, 11:57 p.m. UTC 
Assign inode data budget to budget request correctly.

Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
---
 fs/ubifs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger May 17, 2017, 6:58 a.m. UTC | #1 
Hyunchul,

Am 17.05.2017 um 01:57 schrieb Hyunchul Lee:
> Assign inode data budget to budget request correctly.
> 
> Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
> ---
>  fs/ubifs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index b777bdd..df67236 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -1050,7 +1050,6 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  	int sz_change;
>  	int err, devlen = 0;
>  	struct ubifs_budget_req req = { .new_ino = 1, .new_dent = 1,
> -					.new_ino_d = ALIGN(devlen, 8),
>  					.dirtied_ino = 1 };
>  	struct fscrypt_name nm;
>  
> @@ -1068,6 +1067,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  		devlen = ubifs_encode_dev(dev, rdev);
>  	}
>  
> +	req.new_ino_d = ALIGN(devlen, 8);

Good find!

Thanks,
//richard
diff mbox

Patch

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index b777bdd..df67236 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1050,7 +1050,6 @@  static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 	int sz_change;
 	int err, devlen = 0;
 	struct ubifs_budget_req req = { .new_ino = 1, .new_dent = 1,
-					.new_ino_d = ALIGN(devlen, 8),
 					.dirtied_ino = 1 };
 	struct fscrypt_name nm;
 
@@ -1068,6 +1067,7 @@  static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 		devlen = ubifs_encode_dev(dev, rdev);
 	}
 
+	req.new_ino_d = ALIGN(devlen, 8);
 	err = ubifs_budget_space(c, &req);
 	if (err) {
 		kfree(dev);