| Message ID | 20170518113104.54400-1-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 18, 2017 at 04:38:01PM +0000, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915/guc: Remove stale comment for q_fail > URL : https://patchwork.freedesktop.org/series/24622/ > State : warning > > == Summary == > > Series 24622v1 Series without cover letter > https://patchwork.freedesktop.org/api/1.0/series/24622/revisions/1/mbox/ > > Test gem_exec_flush: > Subgroup basic-batch-kernel-default-uc: > fail -> PASS (fi-snb-2600) fdo#100007 > Test kms_flip: > Subgroup basic-flip-vs-dpms: > pass -> DMESG-WARN (fi-skl-6700hq) Unrelated to guc debugfs changes: [ 396.647050] [drm:intel_dp_start_link_train [i915]] *ERROR* failed to enable link training Michal > > fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007 > > fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:449s > fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:434s > fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:588s > fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:513s > fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:496s > fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:491s > fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:414s > fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:407s > fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:420s > fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:489s > fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:460s > fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:465s > fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:462s > fi-skl-6700hq total:278 pass:260 dwarn:1 dfail:0 fail:0 skip:17 time:569s > fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:466s > fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:499s > fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:440s > fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:532s > fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:405s > > ab08cb2750e769d074b2f147c8298ccd0cd08340 drm-tip: 2017y-05m-18d-15h-36m-17s UTC integration manifest > e106859 drm/i915/guc: Remove last submission result from debugfs > e75fc1c drm/i915/guc: Remove failed doorbell stat from debugfs > 19d608b drm/i915/guc: Remove stale comment for q_fail > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4739/
On Thu, May 18, 2017 at 07:12:37PM +0200, Michal Wajdeczko wrote: > On Thu, May 18, 2017 at 04:38:01PM +0000, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/3] drm/i915/guc: Remove stale comment for q_fail > > URL : https://patchwork.freedesktop.org/series/24622/ > > State : warning > > > > == Summary == > > > > Series 24622v1 Series without cover letter > > https://patchwork.freedesktop.org/api/1.0/series/24622/revisions/1/mbox/ > > > > Test gem_exec_flush: > > Subgroup basic-batch-kernel-default-uc: > > fail -> PASS (fi-snb-2600) fdo#100007 > > Test kms_flip: > > Subgroup basic-flip-vs-dpms: > > pass -> DMESG-WARN (fi-skl-6700hq) > > Unrelated to guc debugfs changes: > > [ 396.647050] [drm:intel_dp_start_link_train [i915]] *ERROR* failed to enable link training And pushed. Thanks, -Chris
On Thu, 18 May 2017, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote: > This member was dropped long time ago. > > Fixes: 774439e1 ("drm/i915/guc: re-optimise i915_guc_client layout") For future reference, please only use Fixes: to indicate actual bugs fixed. I use the tag to track fixes that need to be backported, stale comments or typo fixes or whatnot need not, and excessive Fixes: use leads to noise for me. That said, when in doubt, err on the side of adding one. Thanks, Jani. > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > drivers/gpu/drm/i915/intel_uc.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h > index 7618b71..8d52a37 100644 > --- a/drivers/gpu/drm/i915/intel_uc.h > +++ b/drivers/gpu/drm/i915/intel_uc.h > @@ -59,8 +59,6 @@ struct drm_i915_gem_request; > * available in the work queue (note, the queue is shared, > * not per-engine). It is OK for this to be nonzero, but > * it should not be huge! > - * q_fail: failed to enqueue a work item. This should never happen, > - * because we check for space beforehand. > * b_fail: failed to ring the doorbell. This should never happen, unless > * somehow the hardware misbehaves, or maybe if the GuC firmware > * crashes? We probably need to reset the GPU to recover.
diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h index 7618b71..8d52a37 100644 --- a/drivers/gpu/drm/i915/intel_uc.h +++ b/drivers/gpu/drm/i915/intel_uc.h @@ -59,8 +59,6 @@ struct drm_i915_gem_request; * available in the work queue (note, the queue is shared, * not per-engine). It is OK for this to be nonzero, but * it should not be huge! - * q_fail: failed to enqueue a work item. This should never happen, - * because we check for space beforehand. * b_fail: failed to ring the doorbell. This should never happen, unless * somehow the hardware misbehaves, or maybe if the GuC firmware * crashes? We probably need to reset the GPU to recover.
This member was dropped long time ago. Fixes: 774439e1 ("drm/i915/guc: re-optimise i915_guc_client layout") Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/intel_uc.h | 2 -- 1 file changed, 2 deletions(-)