KVM: irqchip: make a variable unsigned

Commit Message

Dan Carpenter May 19, 2017, 9:26 p.m. UTC

This doesn't change runtime behavior, but we're passing u32 values to
here so let's make everything consistent.

Signed-off-by: Dan Carpenter <[e-mail]>

Comments

kernel test robot May 21, 2017, 8:48 a.m. UTC | #1

Hi Dan,

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v4.12-rc1 next-20170519]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dan-Carpenter/KVM-irqchip-make-a-variable-unsigned/20170521-140440
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

>> arch/powerpc/kvm/book3s.c:977:5: error: conflicting types for 'kvm_irq_map_gsi'
    int kvm_irq_map_gsi(struct kvm *kvm,
        ^~~~~~~~~~~~~~~
   In file included from arch/powerpc/kvm/book3s.c:17:0:
   include/linux/kvm_host.h:877:5: note: previous declaration of 'kvm_irq_map_gsi' was here
    int kvm_irq_map_gsi(struct kvm *kvm,
        ^~~~~~~~~~~~~~~

vim +/kvm_irq_map_gsi +977 arch/powerpc/kvm/book3s.c

5af50993 Benjamin Herrenschmidt 2017-04-05  971  				 struct kvm *kvm, int irq_source_id, int level,
5af50993 Benjamin Herrenschmidt 2017-04-05  972  				 bool line_status)
5af50993 Benjamin Herrenschmidt 2017-04-05  973  {
5af50993 Benjamin Herrenschmidt 2017-04-05  974  	return kvm_set_irq(kvm, irq_source_id, e->gsi, level, line_status);
5af50993 Benjamin Herrenschmidt 2017-04-05  975  }
5af50993 Benjamin Herrenschmidt 2017-04-05  976  
5af50993 Benjamin Herrenschmidt 2017-04-05 @977  int kvm_irq_map_gsi(struct kvm *kvm,
5af50993 Benjamin Herrenschmidt 2017-04-05  978  		    struct kvm_kernel_irq_routing_entry *entries, int gsi)
5af50993 Benjamin Herrenschmidt 2017-04-05  979  {
5af50993 Benjamin Herrenschmidt 2017-04-05  980  	entries->gsi = gsi;

:::::: The code at line 977 was first introduced by commit
:::::: 5af50993850a48ba749b122173d789ea90976c72 KVM: PPC: Book3S HV: Native usage of the XIVE interrupt controller

:::::: TO: Benjamin Herrenschmidt <[e-mail]>
:::::: CC: Michael Ellerman <[e-mail]>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Patch

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 8c0664309815..e9ee5f17ae8d 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -875,7 +875,7 @@  struct kvm_irq_ack_notifier {
 };
 
 int kvm_irq_map_gsi(struct kvm *kvm,
-		    struct kvm_kernel_irq_routing_entry *entries, int gsi);
+		    struct kvm_kernel_irq_routing_entry *entries, u32 gsi);
 int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin);
 
 int kvm_set_irq(struct kvm *kvm, int irq_source_id, u32 irq, int level,
diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
index 31e40c9e81df..493a7cdba1d7 100644
--- a/virt/kvm/irqchip.c
+++ b/virt/kvm/irqchip.c
@@ -32,7 +32,8 @@ 
 #include "irq.h"
 
 int kvm_irq_map_gsi(struct kvm *kvm,
-		    struct kvm_kernel_irq_routing_entry *entries, int gsi)
+		    struct kvm_kernel_irq_routing_entry *entries,
+		    u32 gsi)
 {
 	struct kvm_irq_routing_table *irq_rt;
 	struct kvm_kernel_irq_routing_entry *e;