diff mbox

[v2,1/2] binding for stm32 cec driver

Message ID 1494939383-18937-2-git-send-email-benjamin.gaignard@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Benjamin Gaignard May 16, 2017, 12:56 p.m. UTC
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
 .../devicetree/bindings/media/st,stm32-cec.txt        | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt

Comments

Rob Herring (Arm) May 23, 2017, 12:14 a.m. UTC | #1
On Tue, May 16, 2017 at 02:56:22PM +0200, Benjamin Gaignard wrote:

Commit message?

Preferred subject prefix is "dt-bindings: media: ..."

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
>  .../devicetree/bindings/media/st,stm32-cec.txt        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
> new file mode 100644
> index 0000000..6be2381
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
> @@ -0,0 +1,19 @@
> +STMicroelectronics STM32 CEC driver
> +
> +Required properties:
> + - compatible : value should be "st,stm32-cec"

All stm32 chips have same CEC block?

> + - reg : Physical base address of the IP registers and length of memory
> +	 mapped region.
> + - clocks : from common clock binding: handle to CEC clocks
> + - clock-names : from common clock binding: must be "cec" and "hdmi-cec".
> + - interrupts : CEC interrupt number to the CPU.
> +
> +Example for stm32f746:
> +
> +cec: cec@40006c00 {
> +	compatible = "st,stm32-cec";
> +	reg = <0x40006C00 0x400>;
> +	interrupts = <94>;
> +	clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
> +	clock-names = "cec", "hdmi-cec";
> +};
> -- 
> 1.9.1
>
Benjamin Gaignard May 23, 2017, 7:15 a.m. UTC | #2
2017-05-23 2:14 GMT+02:00 Rob Herring <robh@kernel.org>:
> On Tue, May 16, 2017 at 02:56:22PM +0200, Benjamin Gaignard wrote:
>
> Commit message?

is missing, sorry..

>
> Preferred subject prefix is "dt-bindings: media: ..."

ok

>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> ---
>>  .../devicetree/bindings/media/st,stm32-cec.txt        | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
>> new file mode 100644
>> index 0000000..6be2381
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
>> @@ -0,0 +1,19 @@
>> +STMicroelectronics STM32 CEC driver
>> +
>> +Required properties:
>> + - compatible : value should be "st,stm32-cec"
>
> All stm32 chips have same CEC block?

yes the block is the same for all stm32 f4/f7/h7 chips

>
>> + - reg : Physical base address of the IP registers and length of memory
>> +      mapped region.
>> + - clocks : from common clock binding: handle to CEC clocks
>> + - clock-names : from common clock binding: must be "cec" and "hdmi-cec".
>> + - interrupts : CEC interrupt number to the CPU.
>> +
>> +Example for stm32f746:
>> +
>> +cec: cec@40006c00 {
>> +     compatible = "st,stm32-cec";
>> +     reg = <0x40006C00 0x400>;
>> +     interrupts = <94>;
>> +     clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
>> +     clock-names = "cec", "hdmi-cec";
>> +};
>> --
>> 1.9.1
>>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
new file mode 100644
index 0000000..6be2381
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
@@ -0,0 +1,19 @@ 
+STMicroelectronics STM32 CEC driver
+
+Required properties:
+ - compatible : value should be "st,stm32-cec"
+ - reg : Physical base address of the IP registers and length of memory
+	 mapped region.
+ - clocks : from common clock binding: handle to CEC clocks
+ - clock-names : from common clock binding: must be "cec" and "hdmi-cec".
+ - interrupts : CEC interrupt number to the CPU.
+
+Example for stm32f746:
+
+cec: cec@40006c00 {
+	compatible = "st,stm32-cec";
+	reg = <0x40006C00 0x400>;
+	interrupts = <94>;
+	clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
+	clock-names = "cec", "hdmi-cec";
+};