| Message ID | fda73b083e5e67e8fcc9fc2d01a590f689a06c91.1492210847.git.sathyanarayanan.kuppuswamy@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, 14 Apr 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > PMIC mfd driver only exports first level irq for thermal device. > But currently we are reading the irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC thermal irq. > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> This still needs a Maintainer Ack. > --- > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > * None > > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c > index 0f19a39..ef6b322 100644 > --- a/drivers/thermal/intel_bxt_pmic_thermal.c > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) > } > > regmap = pmic->regmap; > - regmap_irq_chip = pmic->irq_chip_data_level2; > + regmap_irq_chip = pmic->irq_chip_data; > > pmic_irq_count = 0; > while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {
Hi Rui/Valentin, Do you have any comments on this patch ? If you agree with this patch, Can you please Ack it ? On 05/22/2017 03:17 AM, Lee Jones wrote: > On Fri, 14 Apr 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > >> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> >> PMIC mfd driver only exports first level irq for thermal device. >> But currently we are reading the irqs from the second level irq >> chip, So this patch fixes this issue by adding support to use >> first level PMIC thermal irq. >> >> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > This still needs a Maintainer Ack. > >> --- >> drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Changes since v1: >> * None >> >> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c >> index 0f19a39..ef6b322 100644 >> --- a/drivers/thermal/intel_bxt_pmic_thermal.c >> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c >> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) >> } >> >> regmap = pmic->regmap; >> - regmap_irq_chip = pmic->irq_chip_data_level2; >> + regmap_irq_chip = pmic->irq_chip_data; >> >> pmic_irq_count = 0; >> while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {
On Fri, 2017-04-14 at 16:25 -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.in > tel.com> > > PMIC mfd driver only exports first level irq for thermal device. > But currently we are reading the irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC thermal irq. > > Signed-off-by: Kuppuswamy Sathyanarayanan > <sathyanarayanan.kuppuswamy@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> -rui > --- > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > * None > > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c > b/drivers/thermal/intel_bxt_pmic_thermal.c > index 0f19a39..ef6b322 100644 > --- a/drivers/thermal/intel_bxt_pmic_thermal.c > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct > platform_device *pdev) > } > > regmap = pmic->regmap; > - regmap_irq_chip = pmic->irq_chip_data_level2; > + regmap_irq_chip = pmic->irq_chip_data; > > pmic_irq_count = 0; > while ((irq = platform_get_irq(pdev, pmic_irq_count)) != > -ENXIO) {
On Tue, 23 May 2017, Zhang Rui wrote: > On Fri, 2017-04-14 at 16:25 -0700, > sathyanarayanan.kuppuswamy@linux.intel.com wrote: > > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.in > > tel.com> > > > > PMIC mfd driver only exports first level irq for thermal device. > > But currently we are reading the irqs from the second level irq > > chip, So this patch fixes this issue by adding support to use > > first level PMIC thermal irq. > > > > Signed-off-by: Kuppuswamy Sathyanarayanan > > <sathyanarayanan.kuppuswamy@linux.intel.com> > > Acked-by: Zhang Rui <rui.zhang@intel.com> I think this is the last Ack. Please collect them all and re-submit the set so I can pick it up. > > --- > > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Changes since v1: > > * None > > > > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c > > b/drivers/thermal/intel_bxt_pmic_thermal.c > > index 0f19a39..ef6b322 100644 > > --- a/drivers/thermal/intel_bxt_pmic_thermal.c > > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct > > platform_device *pdev) > > } > > > > regmap = pmic->regmap; > > - regmap_irq_chip = pmic->irq_chip_data_level2; > > + regmap_irq_chip = pmic->irq_chip_data; > > > > pmic_irq_count = 0; > > while ((irq = platform_get_irq(pdev, pmic_irq_count)) != > > -ENXIO) {
diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c index 0f19a39..ef6b322 100644 --- a/drivers/thermal/intel_bxt_pmic_thermal.c +++ b/drivers/thermal/intel_bxt_pmic_thermal.c @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) } regmap = pmic->regmap; - regmap_irq_chip = pmic->irq_chip_data_level2; + regmap_irq_chip = pmic->irq_chip_data; pmic_irq_count = 0; while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {