| Message ID | 3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Jun 1, 2017 at 1:37 AM, <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > PMIC mfd driver only exports first level irq for thermal device. > But currently we are reading the irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC thermal irq. > Shouldn't be this squashed to patch 2? > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > Acked-by: Zhang Rui <rui.zhang@intel.com> > --- > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > * None > > Changes since v2: > * Rebased on top of latest release. > > Changes since v3: > * Rebased on top of latest release. > > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c > index 0f19a39..ef6b322 100644 > --- a/drivers/thermal/intel_bxt_pmic_thermal.c > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) > } > > regmap = pmic->regmap; > - regmap_irq_chip = pmic->irq_chip_data_level2; > + regmap_irq_chip = pmic->irq_chip_data; > > pmic_irq_count = 0; > while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) { > -- > 2.7.4 >
Hi, On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Jun 1, 2017 at 1:37 AM, > <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: >> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> >> PMIC mfd driver only exports first level irq for thermal device. >> But currently we are reading the irqs from the second level irq >> chip, So this patch fixes this issue by adding support to use >> first level PMIC thermal irq. >> > > Shouldn't be this squashed to patch 2? There is no compilation dependency between patch 2 and 3. But they are functionally dependent. Should we squash functionally dependent patches too ? > >> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> Acked-by: Zhang Rui <rui.zhang@intel.com> >> --- >> drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Changes since v1: >> * None >> >> Changes since v2: >> * Rebased on top of latest release. >> >> Changes since v3: >> * Rebased on top of latest release. >> >> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c >> index 0f19a39..ef6b322 100644 >> --- a/drivers/thermal/intel_bxt_pmic_thermal.c >> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c >> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) >> } >> >> regmap = pmic->regmap; >> - regmap_irq_chip = pmic->irq_chip_data_level2; >> + regmap_irq_chip = pmic->irq_chip_data; >> >> pmic_irq_count = 0; >> while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) { >> -- >> 2.7.4 >> > > > > -- > With Best Regards, > Andy Shevchenko
On Sat, Jun 3, 2017 at 8:28 PM, Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@gmail.com> wrote: > Hi, > > On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Thu, Jun 1, 2017 at 1:37 AM, >> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: >>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>> >>> PMIC mfd driver only exports first level irq for thermal device. >>> But currently we are reading the irqs from the second level irq >>> chip, So this patch fixes this issue by adding support to use >>> first level PMIC thermal irq. >>> >> >> Shouldn't be this squashed to patch 2? > > There is no compilation dependency between patch 2 and 3. But they are > functionally dependent. > > Should we squash functionally dependent patches too ? Let's assume we applied patches 1 and 2, does it mean the regression to the existing behaviour? (For example, device worked improperly in some cases -> stopped working completely)
Hi, On Sat, Jun 3, 2017 at 10:32 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sat, Jun 3, 2017 at 8:28 PM, Sathyanarayanan Kuppuswamy Natarajan > <sathyaosid@gmail.com> wrote: >> Hi, >> >> On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko >> <andy.shevchenko@gmail.com> wrote: >>> On Thu, Jun 1, 2017 at 1:37 AM, >>> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: >>>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>>> >>>> PMIC mfd driver only exports first level irq for thermal device. >>>> But currently we are reading the irqs from the second level irq >>>> chip, So this patch fixes this issue by adding support to use >>>> first level PMIC thermal irq. >>>> >>> >>> Shouldn't be this squashed to patch 2? >> >> There is no compilation dependency between patch 2 and 3. But they are >> functionally dependent. >> >> Should we squash functionally dependent patches too ? > > Let's assume we applied patches 1 and 2, does it mean the regression > to the existing behaviour? Yes, Just applying patch 1 & 2 and not apply patch 3 will create regression in thermal driver. Since there is no compilation dependency between patch 2 & 3 and they are from two different domains, I submitted them separately to make it easier for review. > > (For example, device worked improperly in some cases -> stopped > working completely) > > -- > With Best Regards, > Andy Shevchenko
On Sat, Jun 3, 2017 at 8:53 PM, Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@gmail.com> wrote: > On Sat, Jun 3, 2017 at 10:32 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Sat, Jun 3, 2017 at 8:28 PM, Sathyanarayanan Kuppuswamy Natarajan >> <sathyaosid@gmail.com> wrote: >> Let's assume we applied patches 1 and 2, does it mean the regression >> to the existing behaviour? > > Yes, Just applying patch 1 & 2 and not apply patch 3 will create > regression in thermal driver. > > Since there is no compilation dependency between patch 2 & 3 and they > are from two different domains, I submitted them separately to make it > easier for review. And this is exactly bisectability (level 2 :-) ) issue. Basically you confirmed you need to squash them like I said. >> (For example, device worked improperly in some cases -> stopped >> working completely)
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Following patch set adds chained IRQ support to WCOVE PMIC driver.
Changes since v3:
* Added fix for typec wcove driver.
Changes since v4:
* Squashed following two commits, to keep the patch set bisectable.
usb: typec: typec_wcove: Use charger irq chip to get usbc virq
mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips
Changes since v5:
* Changed irq->IRQ, pmic->PMIC in all commit messages.
* Squashed following two thermal driver related commits.
mfd: intel_soc_pmic_bxtwc: Remove thermal second level irqs
thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq
* Squashed following two GPIO driver related commits.
mfd: intel_soc_pmic_bxtwc: Remove second level irq for gpio device
gpio: gpio-wcove: Use first level PMIC GPIO irq
Kuppuswamy Sathyanarayanan (6):
mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index
mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs
mfd: intel_soc_pmic_bxtwc: Remove second level IRQ for gpio device
mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe
mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips
platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask
drivers/gpio/gpio-wcove.c | 14 +-
drivers/mfd/intel_soc_pmic_bxtwc.c | 232 +++++++++++++++++++++----------
drivers/platform/x86/intel_bxtwc_tmu.c | 4 -
drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
drivers/usb/typec/typec_wcove.c | 2 +-
include/linux/mfd/intel_soc_pmic.h | 5 +-
6 files changed, 175 insertions(+), 84 deletions(-)
On Mon, Jun 5, 2017 at 10:08 PM, <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > Following patch set adds chained IRQ support to WCOVE PMIC driver. Assuming it has been tested, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> to the patches which do not have it yet. > Changes since v3: > * Added fix for typec wcove driver. > > Changes since v4: > * Squashed following two commits, to keep the patch set bisectable. > usb: typec: typec_wcove: Use charger irq chip to get usbc virq > mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips > > Changes since v5: > * Changed irq->IRQ, pmic->PMIC in all commit messages. > * Squashed following two thermal driver related commits. > mfd: intel_soc_pmic_bxtwc: Remove thermal second level irqs > thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq > * Squashed following two GPIO driver related commits. > mfd: intel_soc_pmic_bxtwc: Remove second level irq for gpio device > gpio: gpio-wcove: Use first level PMIC GPIO irq > > Kuppuswamy Sathyanarayanan (6): > mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index > mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs > mfd: intel_soc_pmic_bxtwc: Remove second level IRQ for gpio device > mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe > mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips > platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask > > drivers/gpio/gpio-wcove.c | 14 +- > drivers/mfd/intel_soc_pmic_bxtwc.c | 232 +++++++++++++++++++++---------- > drivers/platform/x86/intel_bxtwc_tmu.c | 4 - > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > drivers/usb/typec/typec_wcove.c | 2 +- > include/linux/mfd/intel_soc_pmic.h | 5 +- > 6 files changed, 175 insertions(+), 84 deletions(-) > > -- > 2.7.4 >
On Mon, Jun 19, 2017 at 5:48 PM, Lee Jones <lee.jones@linaro.org> wrote: > Enjoy! Thanks! I suppose this one kbuild bot doesn't complain about :-) Darren, do we need it or we can survive until v4.13-rc1? > > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: > > Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-x86-v4.13 > > for you to fetch changes up to 94d68594a7b4fd2eec457f22110de644e1c4ee57: > > platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask (2017-06-19 15:45:30 +0100) > > ---------------------------------------------------------------- > Immutable branch between MFD and X86 due for the v4.13 merge window > > ---------------------------------------------------------------- > Kuppuswamy Sathyanarayanan (6): > mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index > mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs > mfd: intel_soc_pmic_bxtwc: Remove second level IRQ for gpio device > mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe > mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips > platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask > > drivers/gpio/gpio-wcove.c | 14 +- > drivers/mfd/intel_soc_pmic_bxtwc.c | 232 +++++++++++++++++++++---------- > drivers/platform/x86/intel_bxtwc_tmu.c | 4 - > drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- > drivers/usb/typec/typec_wcove.c | 2 +- > include/linux/mfd/intel_soc_pmic.h | 5 +- > 6 files changed, 175 insertions(+), 84 deletions(-) > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
On Mon, Jun 19, 2017 at 06:08:27PM +0300, Andy Shevchenko wrote: > On Mon, Jun 19, 2017 at 5:48 PM, Lee Jones <lee.jones@linaro.org> wrote: > > Enjoy! > > Thanks! > > I suppose this one kbuild bot doesn't complain about :-) > > Darren, do we need it or we can survive until v4.13-rc1? I suggest merging it to a local branch for safe keeping and if we see conflicts in subsequent patches, we can apply it. I doubt it will be a problem.
diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c index 0f19a39..ef6b322 100644 --- a/drivers/thermal/intel_bxt_pmic_thermal.c +++ b/drivers/thermal/intel_bxt_pmic_thermal.c @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) } regmap = pmic->regmap; - regmap_irq_chip = pmic->irq_chip_data_level2; + regmap_irq_chip = pmic->irq_chip_data; pmic_irq_count = 0; while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {