diff mbox

thermal: bcm2835: fix an error code in probe()

Message ID 20170614091327.GD29394@elgon.mountain (mailing list archive)
State Accepted
Delegated to: Eduardo Valentin
Headers show

Commit Message

Dan Carpenter June 14, 2017, 9:13 a.m. UTC 
This causes a static checker because we're passing a valid pointer to
PTR_ERR().  "err" is already the correct error code, so we can just
delete this line.

Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Stefan Wahren June 14, 2017, 5:12 p.m. UTC | #1 
> Dan Carpenter <dan.carpenter@oracle.com> hat am 14. Juni 2017 um 11:13 geschrieben:
> 
> 
> This causes a static checker because we're passing a valid pointer to
> PTR_ERR().  "err" is already the correct error code, so we can just
> delete this line.
> 
> Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
> index 0ecf80890c84..e6863c841662 100644
> --- a/drivers/thermal/broadcom/bcm2835_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2835_thermal.c
> @@ -245,7 +245,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
>  		 */
>  		err = tz->ops->get_trip_temp(tz, 0, &trip_temp);
>  		if (err < 0) {
> -			err = PTR_ERR(tz);
>  			dev_err(&pdev->dev,
>  				"Not able to read trip_temp: %d\n",
>  				err);

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks
Stefan
diff mbox

Patch

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 0ecf80890c84..e6863c841662 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -245,7 +245,6 @@  static int bcm2835_thermal_probe(struct platform_device *pdev)
 		 */
 		err = tz->ops->get_trip_temp(tz, 0, &trip_temp);
 		if (err < 0) {
-			err = PTR_ERR(tz);
 			dev_err(&pdev->dev,
 				"Not able to read trip_temp: %d\n",
 				err);