| Message ID | 20170613223710.31719-2-code@mmayer.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 13, 2017 at 03:37:09PM -0700, Markus Mayer wrote: > From: Markus Mayer <mmayer@broadcom.com> > > Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > --- > .../devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt Acked-by: Rob Herring <robh@kernel.org>
On 18 June 2017 at 07:05, Rob Herring <robh@kernel.org> wrote: > On Tue, Jun 13, 2017 at 03:37:09PM -0700, Markus Mayer wrote: >> From: Markus Mayer <mmayer@broadcom.com> >> >> Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). >> >> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >> --- >> .../devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt | 27 ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt > > Acked-by: Rob Herring <robh@kernel.org> Thanks, Rob. To bring up the previous discussion regarding enumerating multiple nodes (so far we need two dpfe nodes for some platforms), how should we go about this? We were originally proposing to use "cell-index", but you said this was OpenFirmware only and couldn't be used in device tree. See https://lkml.org/lkml/2017/4/27/574. We do need to use something, because the driver needs to know if it should be accessing dpfe0 or dpfe1. What should we use? Thanks, -Markus
On 06/19/2017 10:26 AM, Markus Mayer wrote: > On 18 June 2017 at 07:05, Rob Herring <robh@kernel.org> wrote: >> On Tue, Jun 13, 2017 at 03:37:09PM -0700, Markus Mayer wrote: >>> From: Markus Mayer <mmayer@broadcom.com> >>> >>> Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). >>> >>> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >>> --- >>> .../devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt | 27 ++++++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt >> >> Acked-by: Rob Herring <robh@kernel.org> > > Thanks, Rob. > > To bring up the previous discussion regarding enumerating multiple > nodes (so far we need two dpfe nodes for some platforms), how should > we go about this? We were originally proposing to use "cell-index", > but you said this was OpenFirmware only and couldn't be used in device > tree. See https://lkml.org/lkml/2017/4/27/574. > > We do need to use something, because the driver needs to know if it > should be accessing dpfe0 or dpfe1. What should we use? Would aliases work for instance for that purpose?
On 06/13/2017 03:37 PM, Markus Mayer wrote: > From: Markus Mayer <mmayer@broadcom.com> > > Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> Applied with Rob's ack, thanks!
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt new file mode 100644 index 0000000..82d923e --- /dev/null +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt @@ -0,0 +1,27 @@ +DDR PHY Front End (DPFE) for Broadcom STB +========================================= + +DPFE and the DPFE firmware provide an interface for the host CPU to +communicate with the DCPU, which resides inside the DDR PHY. + +There are three memory regions for interacting with the DCPU. These are +specified in a single reg property. + +Required properties: + - compatible: must be "brcm,bcm7271-dpfe-cpu", "brcm,bcm7268-dpfe-cpu" + or "brcm,dpfe-cpu" + - reg: must reference three register ranges + - start address and length of the DCPU register space + - start address and length of the DCPU data memory space + - start address and length of the DCPU instruction memory space + - reg-names: must contain "dpfe-cpu", "dpfe-dmem", and "dpfe-imem"; + they must be in the same order as the register declarations + +Example: + dpfe_cpu0: dpfe-cpu@f1132000 { + compatible = "brcm,bcm7271-dpfe-cpu", "brcm,dpfe-cpu"; + reg = <0xf1132000 0x180 + 0xf1134000 0x1000 + 0xf1138000 0x4000>; + reg-names = "dpfe-cpu", "dpfe-dmem", "dpfe-imem"; + };