diff mbox

[GIT,PULL] ARM: mvebu: dt64 for v4.13 (#2)

Message ID CAK8P3a3UuLFVxZv1o1+gKSafsGgV=vgWRM_yjnT_E4fAUPZx8g@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Arnd Bergmann June 23, 2017, 12:32 p.m. UTC 
On Thu, Jun 22, 2017 at 2:26 PM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> Hi,
>
> Here is the second pull request for dt64 for mvebu for v4.13.
>
> This came only now because I waited for that the drivers part was
> accepted. Now that is was done we can enable the last missing part of
> the infrastructure for the Aramda 7K/8K SoCs.

Pulled into next/dt64, thanks!

> Also note that there is a trivial merge conflict with the mvebu-fixes
> branch. In case of doubt it was resolved in the last merge commit of
> the mvebu/for-next branch.

Thanks, that helped, my initial merge ended up with a typo.

However, while doing the merge, I stumbled over an obviously
broken commit:


commit b1a97f86b7359da7bbd7a8dd2900d62352c04644
Author: Antoine Tenart <antoine.tenart@free-electrons.com>
Date:   Wed May 24 16:10:33 2017 +0200

    arm64: dts: marvell: add dma-mask in crypto nodes for 7k/8k

    The EIP197 cryptographic engine supports 64 bits address width but is
    limited to 40 bits on 7k/8k. Add a dma-mask property in the
    cryptographic engine nodes to reflect this.

    Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
    Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>



Please send a revert for that, and remove the code that tries to
parse the dma-mask from DT from that driver!

       Arnd

Comments

Gregory CLEMENT June 23, 2017, 2:14 p.m. UTC | #1 
Hi Arnd,
 
 On ven., juin 23 2017, Arnd Bergmann <arnd@arndb.de> wrote:


>
>
> Please send a revert for that, and remove the code that tries to
> parse the dma-mask from DT from that driver!

I see on IRC you agree with Antoine about it the driver part. For the DT
part do you want a PR with the revert or just the patch alone?

Thanks,

Gregory

>
>        Arnd
Arnd Bergmann June 23, 2017, 2:28 p.m. UTC | #2 
On Fri, Jun 23, 2017 at 4:14 PM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> Hi Arnd,
>
>  On ven., juin 23 2017, Arnd Bergmann <arnd@arndb.de> wrote:
>
>
>>
>>
>> Please send a revert for that, and remove the code that tries to
>> parse the dma-mask from DT from that driver!
>
> I see on IRC you agree with Antoine about it the driver part. For the DT
> part do you want a PR with the revert or just the patch alone?

Either way is fine, or just let me know (here or on IRC) if I should
just revert the patch and add an explanation myself.

       Arnd
Gregory CLEMENT June 23, 2017, 2:30 p.m. UTC | #3 
Hi Arnd,
 
 On ven., juin 23 2017, Arnd Bergmann <arnd@arndb.de> wrote:

> On Fri, Jun 23, 2017 at 4:14 PM, Gregory CLEMENT
> <gregory.clement@free-electrons.com> wrote:
>> Hi Arnd,
>>
>>  On ven., juin 23 2017, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>>
>>>
>>>
>>> Please send a revert for that, and remove the code that tries to
>>> parse the dma-mask from DT from that driver!
>>
>> I see on IRC you agree with Antoine about it the driver part. For the DT
>> part do you want a PR with the revert or just the patch alone?
>
> Either way is fine, or just let me know (here or on IRC) if I should
> just revert the patch and add an explanation myself.

If you can do it, it's better. You know better than me why we should
revert this patch! :)

Gregory

>
>        Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
index 576e825585c9..e02ac90f7fdf 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
@@ -242,6 +242,7 @@ 
                                interrupt-names = "mem", "ring0", "ring1",
                                "ring2", "ring3", "eip";
                                clocks = <&cpm_syscon0 1 26>;
+                               dma-mask = <0xff 0xffffffff>;
                                status = "disabled";
                        };
                };
diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
index 797208a11f9d..7468fe00fc37 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
@@ -232,6 +232,7 @@ 
                                interrupt-names = "mem", "ring0", "ring1",
                                                  "ring2", "ring3", "eip";
                                clocks = <&cps_syscon0 1 26>;
+                               dma-mask = <0xff 0xffffffff>;
                                status = "disabled";
                        };
                };