diff mbox

generic/401: Test mountpoint not subdir for filetype support

Message ID 63bb7dca-e407-abea-e432-2e946a8fd435@sandeen.net (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Sandeen June 23, 2017, 4:12 p.m. UTC
With pending changes for xfs_info/xfs_growfs, the tool
now requires an actual mount point to work properly.

Change this test to test $SCRATCH_MNT not the subdir
beneath it.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Sorry, forgot [PATCH], adding to make sure Eryu sees it.


--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bill O'Donnell June 23, 2017, 5:20 p.m. UTC | #1
On Fri, Jun 23, 2017 at 11:12:41AM -0500, Eric Sandeen wrote:
> With pending changes for xfs_info/xfs_growfs, the tool
> now requires an actual mount point to work properly.
> 
> Change this test to test $SCRATCH_MNT not the subdir
> beneath it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> Sorry, forgot [PATCH], adding to make sure Eryu sees it.
> 
> diff --git a/tests/generic/401 b/tests/generic/401
> index 04bd1a5..74f2bea 100755
> --- a/tests/generic/401
> +++ b/tests/generic/401
> @@ -79,7 +79,7 @@ mknod $testdir/p p
>  src/t_dir_type $testdir d | grep -F '.' | sort
>  
>  # Test that either all file types are unknown or all are correct
> -if _supports_filetype $testdir; then
> +if _supports_filetype $SCRATCH_MNT; then
>  	# print real file types
>  	src/t_dir_type $testdir | grep -vF '.' | sort
>  else
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eryu Guan June 26, 2017, 3:59 a.m. UTC | #2
On Fri, Jun 23, 2017 at 11:12:41AM -0500, Eric Sandeen wrote:
> With pending changes for xfs_info/xfs_growfs, the tool
> now requires an actual mount point to work properly.
> 
> Change this test to test $SCRATCH_MNT not the subdir
> beneath it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> Sorry, forgot [PATCH], adding to make sure Eryu sees it.

Thanks! Saw it :)

Eryu

> 
> diff --git a/tests/generic/401 b/tests/generic/401
> index 04bd1a5..74f2bea 100755
> --- a/tests/generic/401
> +++ b/tests/generic/401
> @@ -79,7 +79,7 @@ mknod $testdir/p p
>  src/t_dir_type $testdir d | grep -F '.' | sort
>  
>  # Test that either all file types are unknown or all are correct
> -if _supports_filetype $testdir; then
> +if _supports_filetype $SCRATCH_MNT; then
>  	# print real file types
>  	src/t_dir_type $testdir | grep -vF '.' | sort
>  else
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/generic/401 b/tests/generic/401
index 04bd1a5..74f2bea 100755
--- a/tests/generic/401
+++ b/tests/generic/401
@@ -79,7 +79,7 @@  mknod $testdir/p p
 src/t_dir_type $testdir d | grep -F '.' | sort
 
 # Test that either all file types are unknown or all are correct
-if _supports_filetype $testdir; then
+if _supports_filetype $SCRATCH_MNT; then
 	# print real file types
 	src/t_dir_type $testdir | grep -vF '.' | sort
 else