diff mbox

[v2] staging: sm750fb: refactor method and fix potential type inconsistence

Message ID 20170702144033.GA5784@lynnl.wit (mailing list archive)
State New, archived
Headers show

Commit Message

Lynn Lei July 2, 2017, 2:40 p.m. UTC
include PANEL_DISPLAY_CTRL_FPVDDEN control mask

Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH July 3, 2017, 6:20 a.m. UTC | #1
On Sun, Jul 02, 2017 at 10:40:33PM +0800, Lynn Lei wrote:
> include PANEL_DISPLAY_CTRL_FPVDDEN control mask


Does the subject match this?

> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index 0f666dc2729a..c68367e6cdeb 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
>  	u32 reg;
>  	u32 opt[] = {
>  		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
> -		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
> +		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,

Are you sure this is allowed?  Why is this patch correct?

And again, it doesn't match the subject line :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 0f666dc2729a..c68367e6cdeb 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -89,7 +89,7 @@  static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,
 	};
 	u32 size, i;