Message ID | 20170630120446.13994-3-romain.perier@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, Jun 30, 2017 at 02:04:41PM +0200, Romain Perier wrote: > From: Nandor Han <nandor.han@ge.com> > > During DMA startup we have a data race condition since UART port can > receive data that can generate different type of errors. > > This is not necessarily an error since DMA didn't yet started. The > situation is minimized but still present even if we try to clear up the > error before starting the DMA. > > Therefore changing the log to debug type we avoid having "false" error > messages. This doesn't look right. You say the message "DMA transaction error." is wrong sometimes and so hide it a bit by using dev_dbg instead of dev_err. I don't like that. Uwe
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1d35293..188063d 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -994,7 +994,7 @@ static void dma_rx_callback(void *data) status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state); if (status == DMA_ERROR) { - dev_err(sport->port.dev, "DMA transaction error.\n"); + dev_dbg(sport->port.dev, "DMA transaction error.\n"); clear_rx_errors(sport); return; }