| Message ID | 20170627102724.23861-1-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 27, 2017 at 12:27:23PM +0200, Enric Balletbo i Serra wrote: > Add a new powered-while-suspended property to control the behavior of the > TPM suspend/resume. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Changes since v3. > - Rebased on top of linux-next > Rob Herring > - Split DT binding from code patch as is preferred. > > Did not exist on previous versions. > > Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > index 8cb638b..85c8216 100644 > --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > @@ -8,6 +8,12 @@ Required properties: > the firmware event log > - linux,sml-size : size of the memory allocated for the firmware event log > > +Optional properties: > + > +- powered-while-suspended: present when the TPM is left powered on between > + suspend and resume (makes the suspend/resume > + callbacks do nothing). > + > Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) > ---------------------------------------------------------- > > -- > 2.9.3 > So... should I apply this? /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
On Mon, Jul 3, 2017 at 5:57 AM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > On Tue, Jun 27, 2017 at 12:27:23PM +0200, Enric Balletbo i Serra wrote: >> Add a new powered-while-suspended property to control the behavior of the >> TPM suspend/resume. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> Signed-off-by: Sonny Rao <sonnyrao@chromium.org> >> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> Changes since v3. >> - Rebased on top of linux-next >> Rob Herring >> - Split DT binding from code patch as is preferred. >> >> Did not exist on previous versions. >> >> Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> index 8cb638b..85c8216 100644 >> --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> @@ -8,6 +8,12 @@ Required properties: >> the firmware event log >> - linux,sml-size : size of the memory allocated for the firmware event log >> >> +Optional properties: >> + >> +- powered-while-suspended: present when the TPM is left powered on between >> + suspend and resume (makes the suspend/resume >> + callbacks do nothing). >> + >> Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) >> ---------------------------------------------------------- >> >> -- >> 2.9.3 >> > > So... should I apply this? Hi, since you applied the code part, it would make sense to apply the documentation too. > > /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
On Wed, Jul 05, 2017 at 10:19:02AM -0700, Sonny Rao wrote: > On Mon, Jul 3, 2017 at 5:57 AM, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > On Tue, Jun 27, 2017 at 12:27:23PM +0200, Enric Balletbo i Serra wrote: > >> Add a new powered-while-suspended property to control the behavior of the > >> TPM suspend/resume. > >> > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > >> Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > >> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > >> Acked-by: Rob Herring <robh@kernel.org> > >> --- > >> Changes since v3. > >> - Rebased on top of linux-next > >> Rob Herring > >> - Split DT binding from code patch as is preferred. > >> > >> Did not exist on previous versions. > >> > >> Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > >> index 8cb638b..85c8216 100644 > >> --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > >> +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > >> @@ -8,6 +8,12 @@ Required properties: > >> the firmware event log > >> - linux,sml-size : size of the memory allocated for the firmware event log > >> > >> +Optional properties: > >> + > >> +- powered-while-suspended: present when the TPM is left powered on between > >> + suspend and resume (makes the suspend/resume > >> + callbacks do nothing). > >> + > >> Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) > >> ---------------------------------------------------------- > >> > >> -- > >> 2.9.3 > >> > > > > So... should I apply this? > > Hi, since you applied the code part, it would make sense to apply the > documentation too. I can do it. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
On Wed, 2017-07-05 at 10:19 -0700, Sonny Rao wrote: > On Mon, Jul 3, 2017 at 5:57 AM, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > On Tue, Jun 27, 2017 at 12:27:23PM +0200, Enric Balletbo i Serra > > wrote: > > > Add a new powered-while-suspended property to control the > > > behavior of the > > > TPM suspend/resume. > > > > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.c > > > om> > > > Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > > > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > Acked-by: Rob Herring <robh@kernel.org> > > > --- > > > Changes since v3. > > > - Rebased on top of linux-next > > > Rob Herring > > > - Split DT binding from code patch as is preferred. > > > > > > Did not exist on previous versions. > > > > > > Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6 > > > ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm- > > > i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm- > > > i2c.txt > > > index 8cb638b..85c8216 100644 > > > --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > > > +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > > > @@ -8,6 +8,12 @@ Required properties: > > > the firmware event log > > > - linux,sml-size : size of the memory allocated for the firmware > > > event log > > > > > > +Optional properties: > > > + > > > +- powered-while-suspended: present when the TPM is left powered > > > on between > > > + suspend and resume (makes the > > > suspend/resume > > > + callbacks do nothing). > > > + > > > Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) > > > ---------------------------------------------------------- > > > > > > -- > > > 2.9.3 > > > > > > > So... should I apply this? > > Hi, since you applied the code part, it would make sense to apply the > documentation too. > > > > > /Jarkko Applied. Sorry for the delay. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt index 8cb638b..85c8216 100644 --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt @@ -8,6 +8,12 @@ Required properties: the firmware event log - linux,sml-size : size of the memory allocated for the firmware event log +Optional properties: + +- powered-while-suspended: present when the TPM is left powered on between + suspend and resume (makes the suspend/resume + callbacks do nothing). + Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) ----------------------------------------------------------