| Message ID | 1499433165-62475-2-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 278a1df198625dde663978266de549e8317267cf |
| Delegated to: | Simon Horman |
| Headers | show |
Hello! On 07/07/2017 04:12 PM, Biju Das wrote: > Add Ethernet AVB support for r8a7743 SoC. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
Hi Biju, On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add Ethernet AVB support for r8a7743 SoC. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> With the minor nit below fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -605,6 +605,19 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + avb: ethernet@e6800000 { > + compatible = "renesas,etheravb-r8a7743", > + "renesas,etheravb-rcar-gen2"; > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; s/0/GIC_SPI/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the review. > -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: 10 July 2017 08:55 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland > <mark.rutland@arm.com>; Russell King <linux@armlinux.org.uk>; Sergei > Shtylyov <sergei.shtylyov@cogentembedded.com>; Simon Horman > <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris > Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; Linux- > Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support > > Hi Biju, > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add Ethernet AVB support for r8a7743 SoC. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > With the minor nit below fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -605,6 +605,19 @@ > > #size-cells = <0>; > > status = "disabled"; > > }; > > + > > + avb: ethernet@e6800000 { > > + compatible = "renesas,etheravb-r8a7743", > > + "renesas,etheravb-rcar-gen2"; > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; > OK. I will fix this. > s/0/GIC_SPI/ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add Ethernet AVB support for r8a7743 SoC. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > With the minor nit below fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -605,6 +605,19 @@ > > #size-cells = <0>; > > status = "disabled"; > > }; > > + > > + avb: ethernet@e6800000 { > > + compatible = "renesas,etheravb-r8a7743", I do not see a patch to add "renesas,etheravb-r8a7743" to Documentation/devicetree/bindings/net/renesas,ravb.txt If you haven't already done so please post a patch to add this once net-next re-opens. > > + "renesas,etheravb-rcar-gen2"; > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; > > s/0/GIC_SPI/ Thanks, I have applied this patch with the minor update above.
On Mon, Jul 10, 2017 at 10:23:51AM +0200, Simon Horman wrote: > On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote: > > Hi Biju, > > > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > > Add Ethernet AVB support for r8a7743 SoC. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > > With the minor nit below fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > > @@ -605,6 +605,19 @@ > > > #size-cells = <0>; > > > status = "disabled"; > > > }; > > > + > > > + avb: ethernet@e6800000 { > > > + compatible = "renesas,etheravb-r8a7743", > > I do not see a patch to add "renesas,etheravb-r8a7743" to > Documentation/devicetree/bindings/net/renesas,ravb.txt > > If you haven't already done so please post a patch to add this > once net-next re-opens. I now see "ravb: Document binding for r8a7743 SoC" > > > > + "renesas,etheravb-rcar-gen2"; > > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; > > > > s/0/GIC_SPI/ > > Thanks, I have applied this patch with the minor update above. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
Hi Simon, Thanks for the review. Regards, Biju > -----Original Message----- > From: Simon Horman [mailto:horms@verge.net.au] > Sent: 10 July 2017 09:37 > To: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Mark Rutland <mark.rutland@arm.com>; devicetree@vger.kernel.org; > Chris Paterson <Chris.Paterson2@renesas.com>; Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com>; Magnus Damm > <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; Biju Das > <biju.das@bp.renesas.com>; Linux-Renesas <linux-renesas- > soc@vger.kernel.org>; Rob Herring <robh+dt@kernel.org>; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support > > On Mon, Jul 10, 2017 at 10:23:51AM +0200, Simon Horman wrote: > > On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote: > > > Hi Biju, > > > > > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > > > Add Ethernet AVB support for r8a7743 SoC. > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > > > > With the minor nit below fixed: > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > > > @@ -605,6 +605,19 @@ > > > > #size-cells = <0>; > > > > status = "disabled"; > > > > }; > > > > + > > > > + avb: ethernet@e6800000 { > > > > + compatible = "renesas,etheravb-r8a7743", > > > > I do not see a patch to add "renesas,etheravb-r8a7743" to > > Documentation/devicetree/bindings/net/renesas,ravb.txt > > > > If you haven't already done so please post a patch to add this once > > net-next re-opens. > > I now see "ravb: Document binding for r8a7743 SoC" I will send the patch with Rob's comments. > > > > > > + "renesas,etheravb-rcar-gen2"; > > > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > > > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; > > > > > > s/0/GIC_SPI/ > > > > Thanks, I have applied this patch with the minor update above. Thanks Simon. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 8380859..ec8657f 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -605,6 +605,19 @@ #size-cells = <0>; status = "disabled"; }; + + avb: ethernet@e6800000 { + compatible = "renesas,etheravb-r8a7743", + "renesas,etheravb-rcar-gen2"; + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 812>; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 812>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; }; /* External root clock */