Message ID | 1500535910-28705-7-git-send-email-kgunda@codeaurora.org (mailing list archive) |
---|---|
State | Not Applicable, archived |
Delegated to: | Andy Gross |
Headers | show |
On 07/20, Kiran Gunda wrote: > Replace the writel_relaxed with __raw_writel to avoid byte swapping > in pmic_arb_write_data() function. That way the code is independent > of the CPU endianness. > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> This also needs a Fixes tag. Fixes: 111a10bf3e53 ("spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb")
On 2017-07-28 05:31, Stephen Boyd wrote: > On 07/20, Kiran Gunda wrote: >> Replace the writel_relaxed with __raw_writel to avoid byte swapping >> in pmic_arb_write_data() function. That way the code is independent >> of the CPU endianness. >> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> > > This also needs a Fixes tag. > > Fixes: 111a10bf3e53 ("spmi: pmic-arb: rename spmi_pmic_arb_dev to > spmi_pmic_arb") Sure. will add the tag and send the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index b32b5b0..a18ff99 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -230,7 +230,7 @@ static void pmic_arb_write_data(struct spmi_pmic_arb *pmic_arb, const u8 *buf, u32 data = 0; memcpy(&data, buf, (bc & 3) + 1); - pmic_arb_base_write(pmic_arb, reg, data); + __raw_writel(data, pmic_arb->wr_base + reg); } static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,