| Message ID | 20170728133539.516824-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote: > I ran into this build error on linux-next: > > drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type > name 'irqreturn_t' > static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr) > ^~~~~~~~~~~ > drivers/infiniband/hw/hns/hns_roce_eq.c: In function > 'hns_roce_msi_x_interrupt': > drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit > declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [- > Werror=implicit-function-declaration] > return IRQ_RETVAL(int_work); > > I have bisected this to a seemingly unrelated change that happened > to remove some indirect header inclusions. Simply including the > required header explicitly fixes the build failure. > > Fixes: 09c7570480f7 ("xfrm: remove flow cache") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Thanks, applied.
diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c index 50f864935a0e..b39d14b62355 100644 --- a/drivers/infiniband/hw/hns/hns_roce_eq.c +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c @@ -31,6 +31,7 @@ */ #include <linux/platform_device.h> +#include <linux/interrupt.h> #include "hns_roce_common.h" #include "hns_roce_device.h" #include "hns_roce_eq.h"
I ran into this build error on linux-next: drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type name 'irqreturn_t' static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr) ^~~~~~~~~~~ drivers/infiniband/hw/hns/hns_roce_eq.c: In function 'hns_roce_msi_x_interrupt': drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-Werror=implicit-function-declaration] return IRQ_RETVAL(int_work); I have bisected this to a seemingly unrelated change that happened to remove some indirect header inclusions. Simply including the required header explicitly fixes the build failure. Fixes: 09c7570480f7 ("xfrm: remove flow cache") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + 1 file changed, 1 insertion(+)