diff mbox

[4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning

Message ID 20170704152438.GA30443@lynnl.yet (mailing list archive)
State New, archived
Headers show

Commit Message

Lynn Lei July 4, 2017, 3:24 p.m. UTC
Fixed a constant-left comparison warning issue check by
scripts/checkpatch.pl:
  WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
 drivers/video/fbdev/sm712fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartlomiej Zolnierkiewicz Aug. 1, 2017, 12:14 p.m. UTC | #1
On Tuesday, July 04, 2017 11:24:38 PM Lynn Lei wrote:
> Fixed a constant-left comparison warning issue check by
> scripts/checkpatch.pl:
>   WARNING: Comparisons should place the constant on the right side of the test
> 
> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 172e94146878..502d0de2feec 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1478,7 +1478,7 @@  static int smtcfb_pci_probe(struct pci_dev *pdev,
 	}
 
 	/* can support 32 bpp */
-	if (15 == sfb->fb->var.bits_per_pixel)
+	if (sfb->fb->var.bits_per_pixel == 15)
 		sfb->fb->var.bits_per_pixel = 16;
 
 	sfb->fb->var.xres_virtual = sfb->fb->var.xres;