| Message ID | a69b6204-d350-9fb2-67e2-79ab05fd091d@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 01, 2017 at 10:19:35PM +0800, Xiao Liang wrote: > Hello, > > Today I found a minor problem that "xl dmesg --clear" failed to clear Xen's > message buffer. From manual page, it should accept "-c" or "--clear". > I proposed a fix and please help review. I also attached the path in the > mail in case mail client format problem. Thanks > Fail log: > # xl dmesg --clear > option `' not supported. Yes we would accept a patch to add the long option. > > Author: xiliang <xiliang@redhat.com> > Date: Tue Aug 1 17:33:02 2017 +0800 > > tools: updated "xl_info.c" to accept "--clear" as parameter following > "xl dmesg" > In xl man page, adding "-c" or "--clear" following "xl dmesg" can clear > Xen's message buffer. It works in old "xm", so added support to xl. > > Signed-off-by: xiliang <xiliang@redhat.com> > > diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c > index 94bd1fd9ab..d6f723b4ad 100644 > --- a/tools/xl/xl_info.c > +++ b/tools/xl/xl_info.c > @@ -884,8 +884,11 @@ int main_dmesg(int argc, char **argv) > libxl_xen_console_reader *cr; > char *line; > int opt, ret = 1; > + static struct option opts[] = { > + {"clear", 0, 0, 'c'} Missing COMMON_LONG_OPTS And please use git send-email in the future to send your patch directly. See https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches
On Tue, Aug 01, 2017 at 10:19:35PM +0800, Xiao Liang wrote: > From 85c4bb378cb456fba96bbe6cdc8734f493daeb0c Mon Sep 17 00:00:00 2001 > From: xiliang <xiliang@redhat.com> > Date: Tue, 1 Aug 2017 17:33:02 +0800 > Subject: [PATCH] tools: updated "xl_info.c" to accept "--clear" as parameter > following "xl dmesg" In xl man page, adding "-c" or "--clear" following "xl > dmesg" can clear Xen's message buffer. It works in old "xm", so added support > to xl. Also you might want to rework the commit message a bit. When writing the commit message, the first line is going to be the subject line of the email, and the rest the body of the commit message. The subject line can be: xl: add --clear option to dmesg command The body can be: The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
From 85c4bb378cb456fba96bbe6cdc8734f493daeb0c Mon Sep 17 00:00:00 2001 From: xiliang <xiliang@redhat.com> Date: Tue, 1 Aug 2017 17:33:02 +0800 Subject: [PATCH] tools: updated "xl_info.c" to accept "--clear" as parameter following "xl dmesg" In xl man page, adding "-c" or "--clear" following "xl dmesg" can clear Xen's message buffer. It works in old "xm", so added support to xl. Signed-off-by: xiliang <xiliang@redhat.com> --- tools/xl/xl_info.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 94bd1fd9ab..d6f723b4ad 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -884,8 +884,11 @@ int main_dmesg(int argc, char **argv) libxl_xen_console_reader *cr; char *line; int opt, ret = 1; + static struct option opts[] = { + {"clear", 0, 0, 'c'} + }; - SWITCH_FOREACH_OPT(opt, "c", NULL, "dmesg", 0) { + SWITCH_FOREACH_OPT(opt, "c", opts, "dmesg", 0) { case 'c': clear = 1; break; -- 2.13.3
Hello, Today I found a minor problem that "xl dmesg --clear" failed to clear Xen's message buffer. From manual page, it should accept "-c" or "--clear". I proposed a fix and please help review. I also attached the path in the mail in case mail client format problem. Thanks Fail log: # xl dmesg --clear option `' not supported. Author: xiliang <xiliang@redhat.com> Date: Tue Aug 1 17:33:02 2017 +0800 tools: updated "xl_info.c" to accept "--clear" as parameter following "xl dmesg" In xl man page, adding "-c" or "--clear" following "xl dmesg" can clear Xen's message buffer. It works in old "xm", so added support to xl. Signed-off-by: xiliang <xiliang@redhat.com> Thanks, Xiao Liang